* [PATCH v2 0/2] properly define some of PHYs
@ 2020-03-13 5:32 Oleksij Rempel
2020-03-13 5:32 ` [PATCH v2 1/2] ARM: dts: imx6dl-riotboard: properly define rgmii PHY Oleksij Rempel
2020-03-13 5:32 ` [PATCH v2 2/2] ARM: dts: imx6q-marsboard: " Oleksij Rempel
0 siblings, 2 replies; 6+ messages in thread
From: Oleksij Rempel @ 2020-03-13 5:32 UTC (permalink / raw)
To: Andrew Lunn, Florian Fainelli, Heiner Kallweit, Mark Rutland,
Rob Herring, Sascha Hauer, Shawn Guo
Cc: devicetree, netdev, Liam Girdwood, linux-kernel, Oleksij Rempel,
Mark Brown, NXP Linux Team, Pengutronix Kernel Team, Russell King,
Fabio Estevam, David S. Miller, linux-arm-kernel
changes v2:
- remove spaces
Oleksij Rempel (2):
ARM: dts: imx6dl-riotboard: properly define rgmii PHY
ARM: dts: imx6q-marsboard: properly define rgmii PHY
arch/arm/boot/dts/imx6dl-riotboard.dts | 16 +++++++++++++++-
arch/arm/boot/dts/imx6q-marsboard.dts | 15 ++++++++++++++-
2 files changed, 29 insertions(+), 2 deletions(-)
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2 1/2] ARM: dts: imx6dl-riotboard: properly define rgmii PHY
2020-03-13 5:32 [PATCH v2 0/2] properly define some of PHYs Oleksij Rempel
@ 2020-03-13 5:32 ` Oleksij Rempel
2020-03-13 9:56 ` Andrew Lunn
2020-03-13 5:32 ` [PATCH v2 2/2] ARM: dts: imx6q-marsboard: " Oleksij Rempel
1 sibling, 1 reply; 6+ messages in thread
From: Oleksij Rempel @ 2020-03-13 5:32 UTC (permalink / raw)
To: Andrew Lunn, Florian Fainelli, Heiner Kallweit, Mark Rutland,
Rob Herring, Sascha Hauer, Shawn Guo
Cc: devicetree, netdev, Liam Girdwood, linux-kernel, Oleksij Rempel,
Mark Brown, NXP Linux Team, Pengutronix Kernel Team, Russell King,
Fabio Estevam, David S. Miller, linux-arm-kernel
The Atheros AR8035 PHY can be autodetected but can't use interrupt
support provided on this board. Define MDIO bus and the PHY node to make
it work properly.
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
arch/arm/boot/dts/imx6dl-riotboard.dts | 16 +++++++++++++++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx6dl-riotboard.dts b/arch/arm/boot/dts/imx6dl-riotboard.dts
index 829654e1835a..065d3ab0f50a 100644
--- a/arch/arm/boot/dts/imx6dl-riotboard.dts
+++ b/arch/arm/boot/dts/imx6dl-riotboard.dts
@@ -89,11 +89,25 @@ &fec {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_enet>;
phy-mode = "rgmii-id";
- phy-reset-gpios = <&gpio3 31 GPIO_ACTIVE_LOW>;
+ phy-handle = <&rgmii_phy>;
interrupts-extended = <&gpio1 6 IRQ_TYPE_LEVEL_HIGH>,
<&intc 0 119 IRQ_TYPE_LEVEL_HIGH>;
fsl,err006687-workaround-present;
status = "okay";
+
+ mdio {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ /* Atheros AR8035 PHY */
+ rgmii_phy: ethernet-phy@4 {
+ reg = <4>;
+ interrupts-extended = <&gpio1 28 IRQ_TYPE_LEVEL_LOW>;
+ reset-gpios = <&gpio3 31 GPIO_ACTIVE_LOW>;
+ reset-assert-us = <10000>;
+ reset-deassert-us = <1000>;
+ };
+ };
};
&gpio1 {
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v2 2/2] ARM: dts: imx6q-marsboard: properly define rgmii PHY
2020-03-13 5:32 [PATCH v2 0/2] properly define some of PHYs Oleksij Rempel
2020-03-13 5:32 ` [PATCH v2 1/2] ARM: dts: imx6dl-riotboard: properly define rgmii PHY Oleksij Rempel
@ 2020-03-13 5:32 ` Oleksij Rempel
2020-03-13 9:55 ` Andrew Lunn
1 sibling, 1 reply; 6+ messages in thread
From: Oleksij Rempel @ 2020-03-13 5:32 UTC (permalink / raw)
To: Andrew Lunn, Florian Fainelli, Heiner Kallweit, Mark Rutland,
Rob Herring, Sascha Hauer, Shawn Guo
Cc: devicetree, netdev, Liam Girdwood, linux-kernel, Oleksij Rempel,
Mark Brown, NXP Linux Team, Pengutronix Kernel Team, Russell King,
Fabio Estevam, David S. Miller, linux-arm-kernel
The Atheros AR8035 PHY can be autodetected but can't use interrupt
support provided on this board. Define MDIO bus and the PHY node to make
it work properly.
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
arch/arm/boot/dts/imx6q-marsboard.dts | 15 ++++++++++++++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx6q-marsboard.dts b/arch/arm/boot/dts/imx6q-marsboard.dts
index 84b30bd6908f..1f31d86a217b 100644
--- a/arch/arm/boot/dts/imx6q-marsboard.dts
+++ b/arch/arm/boot/dts/imx6q-marsboard.dts
@@ -111,8 +111,21 @@ &fec {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_enet>;
phy-mode = "rgmii-id";
- phy-reset-gpios = <&gpio3 31 GPIO_ACTIVE_LOW>;
status = "okay";
+
+ mdio {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ /* Atheros AR8035 PHY */
+ rgmii_phy: ethernet-phy@4 {
+ reg = <4>;
+ interrupts-extended = <&gpio1 28 IRQ_TYPE_LEVEL_LOW>;
+ reset-gpios = <&gpio3 31 GPIO_ACTIVE_LOW>;
+ reset-assert-us = <10000>;
+ reset-deassert-us = <1000>;
+ };
+ };
};
&hdmi {
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2 2/2] ARM: dts: imx6q-marsboard: properly define rgmii PHY
2020-03-13 5:32 ` [PATCH v2 2/2] ARM: dts: imx6q-marsboard: " Oleksij Rempel
@ 2020-03-13 9:55 ` Andrew Lunn
2020-03-13 10:12 ` Oleksij Rempel
0 siblings, 1 reply; 6+ messages in thread
From: Andrew Lunn @ 2020-03-13 9:55 UTC (permalink / raw)
To: Oleksij Rempel
Cc: Mark Rutland, devicetree, Florian Fainelli, Russell King,
Fabio Estevam, Sascha Hauer, Liam Girdwood, linux-kernel,
Rob Herring, Mark Brown, Pengutronix Kernel Team, netdev,
NXP Linux Team, Shawn Guo, David S. Miller, linux-arm-kernel,
Heiner Kallweit
On Fri, Mar 13, 2020 at 06:32:24AM +0100, Oleksij Rempel wrote:
> The Atheros AR8035 PHY can be autodetected but can't use interrupt
> support provided on this board. Define MDIO bus and the PHY node to make
> it work properly.
>
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
> arch/arm/boot/dts/imx6q-marsboard.dts | 15 ++++++++++++++-
> 1 file changed, 14 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/imx6q-marsboard.dts b/arch/arm/boot/dts/imx6q-marsboard.dts
> index 84b30bd6908f..1f31d86a217b 100644
> --- a/arch/arm/boot/dts/imx6q-marsboard.dts
> +++ b/arch/arm/boot/dts/imx6q-marsboard.dts
> @@ -111,8 +111,21 @@ &fec {
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_enet>;
> phy-mode = "rgmii-id";
> - phy-reset-gpios = <&gpio3 31 GPIO_ACTIVE_LOW>;
> status = "okay";
Hi Oleksij
I don't see a phy-handle here. So is it still using phy_find_first()?
Andrew
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/2] ARM: dts: imx6dl-riotboard: properly define rgmii PHY
2020-03-13 5:32 ` [PATCH v2 1/2] ARM: dts: imx6dl-riotboard: properly define rgmii PHY Oleksij Rempel
@ 2020-03-13 9:56 ` Andrew Lunn
0 siblings, 0 replies; 6+ messages in thread
From: Andrew Lunn @ 2020-03-13 9:56 UTC (permalink / raw)
To: Oleksij Rempel
Cc: Mark Rutland, devicetree, Florian Fainelli, Russell King,
Fabio Estevam, Sascha Hauer, Liam Girdwood, linux-kernel,
Rob Herring, Mark Brown, Pengutronix Kernel Team, netdev,
NXP Linux Team, Shawn Guo, David S. Miller, linux-arm-kernel,
Heiner Kallweit
On Fri, Mar 13, 2020 at 06:32:23AM +0100, Oleksij Rempel wrote:
> The Atheros AR8035 PHY can be autodetected but can't use interrupt
> support provided on this board. Define MDIO bus and the PHY node to make
> it work properly.
>
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 2/2] ARM: dts: imx6q-marsboard: properly define rgmii PHY
2020-03-13 9:55 ` Andrew Lunn
@ 2020-03-13 10:12 ` Oleksij Rempel
0 siblings, 0 replies; 6+ messages in thread
From: Oleksij Rempel @ 2020-03-13 10:12 UTC (permalink / raw)
To: Andrew Lunn
Cc: Mark Rutland, devicetree, Florian Fainelli, Russell King,
Fabio Estevam, Sascha Hauer, Liam Girdwood, linux-kernel,
Rob Herring, Mark Brown, Pengutronix Kernel Team, netdev,
NXP Linux Team, Shawn Guo, David S. Miller, linux-arm-kernel,
Heiner Kallweit
[-- Attachment #1.1: Type: text/plain, Size: 1417 bytes --]
On Fri, Mar 13, 2020 at 10:55:45AM +0100, Andrew Lunn wrote:
> On Fri, Mar 13, 2020 at 06:32:24AM +0100, Oleksij Rempel wrote:
> > The Atheros AR8035 PHY can be autodetected but can't use interrupt
> > support provided on this board. Define MDIO bus and the PHY node to make
> > it work properly.
> >
> > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> > ---
> > arch/arm/boot/dts/imx6q-marsboard.dts | 15 ++++++++++++++-
> > 1 file changed, 14 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/boot/dts/imx6q-marsboard.dts b/arch/arm/boot/dts/imx6q-marsboard.dts
> > index 84b30bd6908f..1f31d86a217b 100644
> > --- a/arch/arm/boot/dts/imx6q-marsboard.dts
> > +++ b/arch/arm/boot/dts/imx6q-marsboard.dts
> > @@ -111,8 +111,21 @@ &fec {
> > pinctrl-names = "default";
> > pinctrl-0 = <&pinctrl_enet>;
> > phy-mode = "rgmii-id";
> > - phy-reset-gpios = <&gpio3 31 GPIO_ACTIVE_LOW>;
> > status = "okay";
>
> Hi Oleksij
>
> I don't see a phy-handle here. So is it still using phy_find_first()?
Uff... right. Thx for pointing it.
Regards,
Oleksij
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-03-13 10:12 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-13 5:32 [PATCH v2 0/2] properly define some of PHYs Oleksij Rempel
2020-03-13 5:32 ` [PATCH v2 1/2] ARM: dts: imx6dl-riotboard: properly define rgmii PHY Oleksij Rempel
2020-03-13 9:56 ` Andrew Lunn
2020-03-13 5:32 ` [PATCH v2 2/2] ARM: dts: imx6q-marsboard: " Oleksij Rempel
2020-03-13 9:55 ` Andrew Lunn
2020-03-13 10:12 ` Oleksij Rempel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).