From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FSL_HELO_FAKE, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE808C10DCE for ; Fri, 13 Mar 2020 17:15:33 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 90570206B7 for ; Fri, 13 Mar 2020 17:15:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="gLF8a6ah"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="Y6MMbku0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 90570206B7 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tW41KYnCLmBzr5TqcXVEiBxGhsxuR+vQoF65QguBETo=; b=gLF8a6ah5tIbrQ ZfMzMooX569/Pht4T3YIf28TtfTc/7OfWShBUbeUErOpqR01fFJ9OlsxMFf121S2AEoy7i/1FdG34 WFvDi/lM7Qru9PWXtKqwFUgCgfK3tWxDK6QSN4vu2nqGkaxjeAaPKaEjHQqvj77DF30S5J25YLz52 eCS5J56yMMCfV86IsTRHjQpA7ZNOUUF/HNHs2a+IXeKSEEmOLE4obCtY97uoxUrBd3aXlFuUhWe/Q rknMfmC+N/M6zFJ3AR9qifZHn98FvyzXenYNK5EDmRyYkffCoTopOoEf0ddmq/u3sNG0WSw3IydF3 aQq2knl1gjXZXMREYhWw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jCnuG-0000vC-JC; Fri, 13 Mar 2020 17:15:33 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jCnuB-0000mh-HL for linux-arm-kernel@lists.infradead.org; Fri, 13 Mar 2020 17:15:29 +0000 Received: by mail-wm1-x342.google.com with SMTP id a141so11136725wme.2 for ; Fri, 13 Mar 2020 10:15:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=EiAZ8r1RK4eYPjDEt/gPiQ4hc4RczwbEBzIiaGohL7A=; b=Y6MMbku01pHaOoSgGbj4gF3V6x7FB1fkNAjJ6ru6WyqJeOLaM9BYbK0Ix5GiRzvNyK JIioY1ozgF3HVo4Auv/aymm6AZFpDclDUVmdfoDPF+KPKip5Yk4kG7Hly9cTf+rNIbjt 7MLho2yP/uxhsxbFwElwAMRIDoxKMELy3GerALcpDAGTG2KnGEZ+GqcbM0IjWFUDhr7q rowpPLYZoUSujhlAEl+M2aZSrzgSsZCi5RH5aISnBCWJvXcUUYCU1KjnPZLcSm+y37Rq sstjUD42VHXtFuUYk1V6LrY/wCYZhaFm3tgsnEUbTCcAXDxIK+sON7MnL+fUwV5dhLoH PtxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=EiAZ8r1RK4eYPjDEt/gPiQ4hc4RczwbEBzIiaGohL7A=; b=VbYZZa2AyrfSoi7X5r1gg4dpG6/4Xz6j+AGxBHnGT+wQFUaLB2l98N1RLv0URtUpkz LmbnI6ekphsm6NvImI7ynH8diBFcRWYA2kqzoOaMJ+qiWDzoRmcXfnzE6I/QYr5hJPYH WAH2scS8TNYx18cKNOaCyEwQqvv2Ml/GT5ls/A/kZFXOj5HZMvykBOfJb4UcuiUFPb7m JgHbcyY0IVwwjOl+hsXTI8GNcvTiRr9/NWe40V1nn70ZuBA8auz6yYqOn8rPcHlwtEfL 855qaUSRb78tTbSwh7fV7JQXi8z+YfQjRNTG6/uKokmwhmgGE5WMOkkGwGKRkW1HyrMa LCxg== X-Gm-Message-State: ANhLgQ35tE8UrcE/5FZrUKfMaoR64UvLQNu26AJjS8/kzPXd2X2inZeX 8w+cN5WRL4JxAbODdQtN+DXFUA== X-Google-Smtp-Source: ADFU+vuhetFMtP2EoDOpiocI9rZpw5aJIjO8D6ESXO0czFCY0ade8WAwSU18BkQ9bFFVg+JYF0INNg== X-Received: by 2002:a7b:c414:: with SMTP id k20mr11747450wmi.119.1584119725823; Fri, 13 Mar 2020 10:15:25 -0700 (PDT) Received: from google.com ([2a00:79e0:d:110:d6cc:2030:37c1:9964]) by smtp.gmail.com with ESMTPSA id s22sm16474638wmc.16.2020.03.13.10.15.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Mar 2020 10:15:25 -0700 (PDT) Date: Fri, 13 Mar 2020 17:15:21 +0000 From: Quentin Perret To: Lukasz Luba Subject: Re: [PATCH v4 1/4] PM / EM: add devices to Energy Model Message-ID: <20200313171521.GA236432@google.com> References: <20200309134117.2331-1-lukasz.luba@arm.com> <20200309134117.2331-2-lukasz.luba@arm.com> <20200313100407.GA144499@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.2 (2019-09-21) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200313_101527_618069_3CF1C84C X-CRM114-Status: GOOD ( 13.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nm@ti.com, juri.lelli@redhat.com, peterz@infradead.org, viresh.kumar@linaro.org, liviu.dudau@arm.com, dri-devel@lists.freedesktop.org, bjorn.andersson@linaro.org, bsegall@google.com, alyssa.rosenzweig@collabora.com, festevam@gmail.com, Morten.Rasmussen@arm.com, robh@kernel.org, amit.kucheria@verdurent.com, lorenzo.pieralisi@arm.com, khilman@kernel.org, agross@kernel.org, daniel.lezcano@linaro.org, steven.price@arm.com, cw00.choi@samsung.com, mingo@redhat.com, linux-imx@nxp.com, rui.zhang@intel.com, mgorman@suse.de, orjan.eide@arm.com, daniel@ffwll.ch, linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, s.hauer@pengutronix.de, rostedt@goodmis.org, linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com, linux-omap@vger.kernel.org, Dietmar.Eggemann@arm.com, linux-arm-kernel@lists.infradead.org, airlied@linux.ie, javi.merino@arm.com, tomeu.vizoso@collabora.com, sboyd@kernel.org, rdunlap@infradead.org, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, b.zolnierkie@samsung.com, kernel@pengutronix.de, sudeep.holla@arm.com, patrick.bellasi@matbug.net, shawnguo@kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Friday 13 Mar 2020 at 16:49:24 (+0000), Lukasz Luba wrote: > Well if someone would add EM to its platform and call this in > hotplug, which is used as cooling method, will see a lot of warnings. Right, but I guess I was arguing that calling this for CPUs, even on hotplug, is kinda wrong. > I would rather avoid stressing people with this kind of warnings. > This is under control and nothing really happens even when they > do hotplug very often, like LTP stress tests. > > I agree to add a print there but warning for me is when something > is not OK and should be investigated. > I would prefer dev_dbg_once() to print thet the EM is not going to be > removed. This will also not pollute dmesg in many logs. Fair enough, a WARN is maybe a bit over the top. A debug message should work. > So these small changes will be present in v5. I have to wait a few > days because there is one change to devfreq_cooling.c queuing and I will > send v5 with updated patch 3/4 rebased on top. Sounds good, thanks. Quentin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel