From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAB45C0044D for ; Sat, 14 Mar 2020 18:20:22 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 95C7620789 for ; Sat, 14 Mar 2020 18:20:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="UsohXnTx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 95C7620789 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nJ7JEJDRA45DrU+O4F9kvBy29G2cHn57zp7RRunsfB4=; b=UsohXnTxriM8R6 ebdF7dstW8Jy5JKqYDzF3XfSwsoYLLhnRbqkkjQyG9rdCFqm2XK3xKsgiybjk0L8fgM25//ZG/FCg Pj8eDiWlsSCSMcFjlLR317prHjSqQkR0Snv7UVova9x1/e199jCQWjz5O1Y2wz+eZvyD4I4U6WlNA ImSFPBuuc9k70BcdvAPSeHxDLPbew+xSa6HsBEkP0cqXYtEGoN0flPTBmhMWpCvQOoHz9mTDxqH8B HnyoY7O4v/m0/zh9w31jnZpIiDKlUwIYAn/4UPe2skG8b57X0Og0V9x8vnuRmD0glyO9KxK5wnmms 4DKb7QsmS6llBkKGQx+A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jDBOW-0001LY-NM; Sat, 14 Mar 2020 18:20:20 +0000 Received: from mail-ed1-f65.google.com ([209.85.208.65]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jDBOR-0001L5-LP for linux-arm-kernel@lists.infradead.org; Sat, 14 Mar 2020 18:20:18 +0000 Received: by mail-ed1-f65.google.com with SMTP id dc19so16438121edb.10 for ; Sat, 14 Mar 2020 11:20:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=IGvteHNkCAAe9RzBu1B2j4q+4lEY8L8k3NmOvCcX8OE=; b=OlEJtfJWq3daAGQ7EOm2oboEonjvwF6eCBxqytI9uzMPp8StclgviGOj09F6VxKu5x FTaseuRtnEnmTTtD7uJeDgqLGQrdlKerEaLkNFnQT76gBbEowBP19MvEIgNXhl+1DA92 Pf2SeZQQFEMaAPblY5EciQ+hr+K8p7qK3Vnuo0OFl2ZR+/+p1LtqPBL8lbw11XFRxuFN k95/ua8tLbdHmKTuWTUXjMz2Is/8emZAk/4Wl8k04SU2NS0g2VjGChZm0xSmWIKMHsoh tu2zEf8e0Xs8wBcgCorAkt8CqnLfKZoiBpPhfaC1GE/ec/OqPen7N+ZOJjcqQz2Emg2x MLOQ== X-Gm-Message-State: ANhLgQ2IZKc7mC0S9v3C0Osn7CEnZyfz74cCJs2UAZ7n/QlLoqLLbj3T hBKAjiHiU9pWN2/JREpoHuE= X-Google-Smtp-Source: ADFU+vvqta4B+r9p/W0zTELooOA9Cc7fWz4UD77LqxM6UYcl+Sd+u1u4HEDyOkSEfBTCw7OTPTESnQ== X-Received: by 2002:a50:d657:: with SMTP id c23mr19074934edj.18.1584210014117; Sat, 14 Mar 2020 11:20:14 -0700 (PDT) Received: from kozik-lap ([194.230.155.125]) by smtp.googlemail.com with ESMTPSA id n6sm2172656ejy.23.2020.03.14.11.20.12 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 14 Mar 2020 11:20:13 -0700 (PDT) Date: Sat, 14 Mar 2020 19:20:10 +0100 From: Krzysztof Kozlowski To: Anand Moon Subject: Re: [PATCHv3 2/5] ARM: dts: exynos: Add missing usbdrd3 suspend clk Message-ID: <20200314182010.GB17580@kozik-lap> References: <20200310194854.831-1-linux.amoon@gmail.com> <20200310194854.831-3-linux.amoon@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200314_112015_704211_6CDEE5C9 X-CRM114-Status: GOOD ( 18.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree , linux-samsung-soc@vger.kernel.org, Bartlomiej Zolnierkiewicz , Stephen Boyd , Michael Turquette , Linux USB Mailing List , Linux Kernel , Tomasz Figa , Chanwoo Choi , Rob Herring , Kukjin Kim , Sylwester Nawrocki , Felipe Balbi , "open list:COMMON CLK FRAMEWORK" , linux-arm-kernel , Marek Szyprowski Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Mar 14, 2020 at 07:02:33PM +0530, Anand Moon wrote: > Hi Krzysztof, > > On Wed, 11 Mar 2020 at 01:19, Anand Moon wrote: > > > > Add new compatible strings for USBDRD3 for adding missing > > suspend clk, exynos5422 usbdrd3 support two clk USBD300 and > > SCLK_USBD300, so add missing suspemd_clk for Exynos542x DWC3 nodes. > > > > Signed-off-by: Anand Moon > > My assumption based on the FSYS clock source diagram below was bit wrong. > [0] https://imgur.com/gallery/zAiBoyh > > And again re-looking into the driver source code, it turn out their > are *6 clock* > Here is the correct mapping as per the Exynos5420 clock driver. > > USB-(phy@12100000) > |___________________CLK_SCLK_USBD300 > |___________________CLK_SCLK_USBPHY300 > > USB-(phy@12500000) > |___________________CLK_SCLK_USBD301 > |___________________CLK_SCLK_USBPHY301 > > USB-(dwc3@12000000) > |___________________CLK_USBD300 > USB-(dwc3@12400000) > |___________________CLK_USBD301 > > Note: As per Exynos 5422 user manual, There are some more USB CLK > configuration missing in GATE_IP_FSYS. So we could enable another dwc3 clk, > If needed I would like too add this missing clk code and enable this > clk for dwc3 driver. > > For some reason we already use CLK_USBD300 and CLK_USBD301 > for PHY nodes, which lead to this confusion. So we need to update PHY clock > CLK_USBD300 with CLK_SCLK_USBD300 and clock CLK_USBD301 with CLK_SCLK_USBD301. > > Please share your thought on linking PHY nodes above and add new DWC3 clock > and enable this clock. The real clock topology of Exynos5422 is not properly reflected in the kernel. However cleaning this up is quite big task. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel