From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E87A4C10F29 for ; Sun, 15 Mar 2020 18:25:23 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B5CE2206B1 for ; Sun, 15 Mar 2020 18:25:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="QmmzpXgR"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="dAcfOEZL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B5CE2206B1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qBD7ES0AmKYv7BiGd3LtqLMfv9HLEtlqOeCaKyFTBxs=; b=QmmzpXgRJ3QmPo 8F3VTD6Jcnc4JJ4RH+vXUQuLlHDF8NT9ssS1BBOuzhlREblcm+0XqHPsJPnWaweSUPSioJSUsP19Q m1My1ExCU8aIJblBBIJVFGjb1V5LdgxARYSj4aAhCW6Tn0ySGo6CyAToXjYtrtkNw/BH0OssLaa1m +Lzg2G220uk8ivQ7SHhy0HRg403DC89QbB7BuEx4OcR1gHfKA1enUgHWr83sT2DaXTy9y/9rSF/LX yiWvZ1EVw4AljDtI31S0hkfNSags3gWaCRAMihub1zzZGKwXcpa4+8umdJz7yMLitpw4/veLE5Lhy 6G+yH+n9ttdfc24d+D2A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jDXwx-0001oo-3f; Sun, 15 Mar 2020 18:25:23 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jDXwu-0001nz-2q for linux-arm-kernel@lists.infradead.org; Sun, 15 Mar 2020 18:25:21 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=powrQRe80aGxECCk+dtKXN3HLIybmgxMPcgaJHiSaLo=; b=dAcfOEZLeXaGsh5vQBzTzYpWwQ QoBvIvwFJzEm7lg/gI+jxgbSj+tKI67zGiWkn2sB/cov0fXbMtF1TkZOn2UjLqKuMsIVoUZAgeqwq l/ChR1erxzLionAxTCXDjevryHRoejIn+qRqTo7H8NmWNNkTO2OIFi0ilnDo6ULD+noQ=; Received: from andrew by vps0.lunn.ch with local (Exim 4.93) (envelope-from ) id 1jDXwe-0002FB-B9; Sun, 15 Mar 2020 19:25:04 +0100 Date: Sun, 15 Mar 2020 19:25:04 +0100 From: Andrew Lunn To: Dejin Zheng Subject: Re: [PATCH net-next v2 1/2] net: stmmac: use readl_poll_timeout() function in init_systime() Message-ID: <20200315182504.GA8524@lunn.ch> References: <20200315150301.32129-1-zhengdejin5@gmail.com> <20200315150301.32129-2-zhengdejin5@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200315150301.32129-2-zhengdejin5@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200315_112520_128672_0C9B35CA X-CRM114-Status: GOOD ( 14.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alexandre.torgue@st.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, joabreu@synopsys.com, mcoquelin.stm32@gmail.com, peppe.cavallaro@st.com, davem@davemloft.net, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Mar 15, 2020 at 11:03:00PM +0800, Dejin Zheng wrote: > The init_systime() function use an open coded of readl_poll_timeout(). > Replace the open coded handling with the proper function. > > Signed-off-by: Dejin Zheng > --- > v1 -> v2: > - no changed. > > .../net/ethernet/stmicro/stmmac/stmmac_hwtstamp.c | 14 ++++++-------- > 1 file changed, 6 insertions(+), 8 deletions(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_hwtstamp.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_hwtstamp.c > index 020159622559..2a24e2a7db3b 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_hwtstamp.c > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_hwtstamp.c > @@ -10,6 +10,7 @@ > *******************************************************************************/ > > #include > +#include > #include > #include "common.h" > #include "stmmac_ptp.h" > @@ -53,8 +54,8 @@ static void config_sub_second_increment(void __iomem *ioaddr, > > static int init_systime(void __iomem *ioaddr, u32 sec, u32 nsec) > { > - int limit; > u32 value; > + int err; > > writel(sec, ioaddr + PTP_STSUR); > writel(nsec, ioaddr + PTP_STNSUR); > @@ -64,13 +65,10 @@ static int init_systime(void __iomem *ioaddr, u32 sec, u32 nsec) > writel(value, ioaddr + PTP_TCR); > > /* wait for present system time initialize to complete */ > - limit = 10; > - while (limit--) { > - if (!(readl(ioaddr + PTP_TCR) & PTP_TCR_TSINIT)) > - break; > - mdelay(10); > - } > - if (limit < 0) > + err = readl_poll_timeout(ioaddr + PTP_TCR, value, > + !(value & PTP_TCR_TSINIT), > + 10000, 100000); > + if (err) > return -EBUSY; Hi Dejin It is normal to just return whatever error code readl_poll_timeout() returned. Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel