* [PATCH] ARM: dts: imx6q-dhcom: Add DH 560-200 display unit support
@ 2020-03-09 20:08 Marek Vasut
2020-03-10 9:08 ` Christoph Niedermaier
0 siblings, 1 reply; 4+ messages in thread
From: Marek Vasut @ 2020-03-09 20:08 UTC (permalink / raw)
To: linux-arm-kernel; +Cc: Marek Vasut, Shawn Guo, Fabio Estevam, NXP Linux Team
Add DT bits to support the DH 560-200 display unit, which can be plugged
into the side of the PDK2 board. The display unit contains a display, EDT
ETM0700G0EDH6 and an EDT FT5x06 touchscreen controller.
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: NXP Linux Team <linux-imx@nxp.com>
Cc: Shawn Guo <shawnguo@kernel.org>
To: linux-arm-kernel@lists.infradead.org
---
arch/arm/boot/dts/imx6q-dhcom-pdk2.dts | 115 ++++++++++++++++++++++++-
1 file changed, 113 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/imx6q-dhcom-pdk2.dts b/arch/arm/boot/dts/imx6q-dhcom-pdk2.dts
index bb74fc62d913..82b18f9345ad 100644
--- a/arch/arm/boot/dts/imx6q-dhcom-pdk2.dts
+++ b/arch/arm/boot/dts/imx6q-dhcom-pdk2.dts
@@ -22,6 +22,53 @@ clk_ext_audio_codec: clock-codec {
clock-frequency = <24000000>;
};
+ display_bl: display-bl {
+ compatible = "pwm-backlight";
+ pwms = <&pwm1 0 50000 PWM_POLARITY_INVERTED>;
+ brightness-levels = <0 16 22 30 40 55 75 102 138 188 255>;
+ default-brightness-level = <8>;
+ enable-gpios = <&gpio3 27 GPIO_ACTIVE_HIGH>;
+ status = "okay";
+ };
+
+ lcd_display: disp0 {
+ compatible = "fsl,imx-parallel-display";
+ #address-cells = <1>;
+ #size-cells = <0>;
+ interface-pix-fmt = "rgb24";
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_ipu1_lcdif>;
+ status = "okay";
+
+ port@0 {
+ reg = <0>;
+
+ lcd_display_in: endpoint {
+ remote-endpoint = <&ipu1_di0_disp0>;
+ };
+ };
+
+ port@1 {
+ reg = <1>;
+
+ lcd_display_out: endpoint {
+ remote-endpoint = <&lcd_panel_in>;
+ };
+ };
+ };
+
+ panel {
+ compatible = "edt,etm0700g0edh6";
+ ddc-i2c-bus = <&i2c2>;
+ backlight = <&display_bl>;
+
+ port {
+ lcd_panel_in: endpoint {
+ remote-endpoint = <&lcd_display_out>;
+ };
+ };
+ };
+
sound {
compatible = "fsl,imx-audio-sgtl5000";
model = "imx-sgtl5000";
@@ -65,6 +112,16 @@ sgtl5000: codec@a {
VDDA-supply = <®_3p3v>;
VDDIO-supply = <&sw2_reg>;
};
+
+ polytouch@38 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_touchscreen>;
+ compatible = "edt,edt-ft5x06";
+ reg = <0x38>;
+ interrupt-parent = <&gpio4>;
+ interrupts = <5 IRQ_TYPE_EDGE_FALLING>; /* GPIO E */
+ linux,wakeup;
+ };
};
&iomuxc {
@@ -77,9 +134,7 @@ MX6QDL_PAD_GPIO_2__GPIO1_IO02 0x400120b0
MX6QDL_PAD_GPIO_4__GPIO1_IO04 0x400120b0
MX6QDL_PAD_GPIO_5__GPIO1_IO05 0x400120b0
MX6QDL_PAD_CSI0_DAT17__GPIO6_IO03 0x400120b0
- MX6QDL_PAD_GPIO_19__GPIO4_IO05 0x120b0
MX6QDL_PAD_DI0_PIN4__GPIO4_IO20 0x400120b0
- MX6QDL_PAD_EIM_D27__GPIO3_IO27 0x120b0
MX6QDL_PAD_KEY_ROW0__GPIO4_IO07 0x120b0
MX6QDL_PAD_KEY_COL1__GPIO4_IO08 0x400120b0
MX6QDL_PAD_NANDF_CS1__GPIO6_IO14 0x400120b0
@@ -132,6 +187,52 @@ MX6QDL_PAD_EIM_D26__GPIO3_IO26 0x000b1
>;
};
+ pinctrl_ipu1_lcdif: ipu1-lcdif-grp {
+ fsl,pins = <
+ MX6QDL_PAD_DI0_DISP_CLK__IPU1_DI0_DISP_CLK 0x38
+ MX6QDL_PAD_DI0_PIN15__IPU1_DI0_PIN15 0x38
+ MX6QDL_PAD_DI0_PIN2__IPU1_DI0_PIN02 0x38
+ MX6QDL_PAD_DI0_PIN3__IPU1_DI0_PIN03 0x38
+ MX6QDL_PAD_DISP0_DAT0__IPU1_DISP0_DATA00 0x38
+ MX6QDL_PAD_DISP0_DAT1__IPU1_DISP0_DATA01 0x38
+ MX6QDL_PAD_DISP0_DAT2__IPU1_DISP0_DATA02 0x38
+ MX6QDL_PAD_DISP0_DAT3__IPU1_DISP0_DATA03 0x38
+ MX6QDL_PAD_DISP0_DAT4__IPU1_DISP0_DATA04 0x38
+ MX6QDL_PAD_DISP0_DAT5__IPU1_DISP0_DATA05 0x38
+ MX6QDL_PAD_DISP0_DAT6__IPU1_DISP0_DATA06 0x38
+ MX6QDL_PAD_DISP0_DAT7__IPU1_DISP0_DATA07 0x38
+ MX6QDL_PAD_DISP0_DAT8__IPU1_DISP0_DATA08 0x38
+ MX6QDL_PAD_DISP0_DAT9__IPU1_DISP0_DATA09 0x38
+ MX6QDL_PAD_DISP0_DAT10__IPU1_DISP0_DATA10 0x38
+ MX6QDL_PAD_DISP0_DAT11__IPU1_DISP0_DATA11 0x38
+ MX6QDL_PAD_DISP0_DAT12__IPU1_DISP0_DATA12 0x38
+ MX6QDL_PAD_DISP0_DAT13__IPU1_DISP0_DATA13 0x38
+ MX6QDL_PAD_DISP0_DAT14__IPU1_DISP0_DATA14 0x38
+ MX6QDL_PAD_DISP0_DAT15__IPU1_DISP0_DATA15 0x38
+ MX6QDL_PAD_DISP0_DAT16__IPU1_DISP0_DATA16 0x38
+ MX6QDL_PAD_DISP0_DAT17__IPU1_DISP0_DATA17 0x38
+ MX6QDL_PAD_DISP0_DAT18__IPU1_DISP0_DATA18 0x38
+ MX6QDL_PAD_DISP0_DAT19__IPU1_DISP0_DATA19 0x38
+ MX6QDL_PAD_DISP0_DAT20__IPU1_DISP0_DATA20 0x38
+ MX6QDL_PAD_DISP0_DAT21__IPU1_DISP0_DATA21 0x38
+ MX6QDL_PAD_DISP0_DAT22__IPU1_DISP0_DATA22 0x38
+ MX6QDL_PAD_DISP0_DAT23__IPU1_DISP0_DATA23 0x38
+ MX6QDL_PAD_EIM_D27__GPIO3_IO27 0x120b0
+ >;
+ };
+
+ pinctrl_pwm1: pwm1-grp {
+ fsl,pins = <
+ MX6QDL_PAD_SD1_DAT3__PWM1_OUT 0x1b0b1
+ >;
+ };
+
+ pinctrl_touchscreen: touchscreen-grp {
+ fsl,pins = <
+ MX6QDL_PAD_GPIO_19__GPIO4_IO05 0x1b0b1
+ >;
+ };
+
pinctrl_pcie: pcie-grp {
fsl,pins = <
MX6QDL_PAD_CSI0_DATA_EN__GPIO5_IO20 0x1b0b1
@@ -139,6 +240,10 @@ MX6QDL_PAD_CSI0_DATA_EN__GPIO5_IO20 0x1b0b1
};
};
+&ipu1_di0_disp0 {
+ remote-endpoint = <&lcd_display_in>;
+};
+
&pcie {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_pcie>;
@@ -146,6 +251,12 @@ &pcie {
status = "okay";
};
+&pwm1 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_pwm1>;
+ status = "okay";
+};
+
&ssi1 {
status = "okay";
};
--
2.25.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: imx6q-dhcom: Add DH 560-200 display unit support
2020-03-09 20:08 [PATCH] ARM: dts: imx6q-dhcom: Add DH 560-200 display unit support Marek Vasut
@ 2020-03-10 9:08 ` Christoph Niedermaier
2020-03-10 21:10 ` Marek Vasut
0 siblings, 1 reply; 4+ messages in thread
From: Christoph Niedermaier @ 2020-03-10 9:08 UTC (permalink / raw)
To: Marek Vasut, linux-arm-kernel@lists.infradead.org
Cc: Fabio Estevam, Shawn Guo, NXP Linux Team
Hi Marek,
From: linux-arm-kernel [mailto:linux-arm-kernel-bounces@lists.infradead.org] On Behalf Of Marek Vasut
Sent: Monday, March 9, 2020 9:08 PM
> + display_bl: display-bl {
> + compatible = "pwm-backlight";
> + pwms = <&pwm1 0 50000 PWM_POLARITY_INVERTED>;
> + brightness-levels = <0 16 22 30 40 55 75 102 138 188 255>;
> + default-brightness-level = <8>;
> + enable-gpios = <&gpio3 27 GPIO_ACTIVE_HIGH>;
> + status = "okay";
> + };
...
> +&pwm1 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_pwm1>;
> + status = "okay";
> +};
To get PWM_POLARITY_INVERTED, shouldn't we add the following line to pwm1:
#pwm-cells = <3>;
Regards,
Christoph
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: imx6q-dhcom: Add DH 560-200 display unit support
2020-03-10 9:08 ` Christoph Niedermaier
@ 2020-03-10 21:10 ` Marek Vasut
2020-03-16 1:00 ` Shawn Guo
0 siblings, 1 reply; 4+ messages in thread
From: Marek Vasut @ 2020-03-10 21:10 UTC (permalink / raw)
To: Christoph Niedermaier, linux-arm-kernel@lists.infradead.org
Cc: Fabio Estevam, Shawn Guo, NXP Linux Team
On 3/10/20 10:08 AM, Christoph Niedermaier wrote:
> Hi Marek,
Hi,
> From: linux-arm-kernel [mailto:linux-arm-kernel-bounces@lists.infradead.org] On Behalf Of Marek Vasut
> Sent: Monday, March 9, 2020 9:08 PM
>
>> + display_bl: display-bl {
>> + compatible = "pwm-backlight";
>> + pwms = <&pwm1 0 50000 PWM_POLARITY_INVERTED>;
>> + brightness-levels = <0 16 22 30 40 55 75 102 138 188 255>;
>> + default-brightness-level = <8>;
>> + enable-gpios = <&gpio3 27 GPIO_ACTIVE_HIGH>;
>> + status = "okay";
>> + };
> ...
>> +&pwm1 {
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&pinctrl_pwm1>;
>> + status = "okay";
>> +};
>
> To get PWM_POLARITY_INVERTED, shouldn't we add the following line to pwm1:
> #pwm-cells = <3>;
It seems some boards do set it, some do not, although that might also be
a bug in the DT of those other board files or I'm reading it wrong.
Let's see what the maintainers have to say.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: imx6q-dhcom: Add DH 560-200 display unit support
2020-03-10 21:10 ` Marek Vasut
@ 2020-03-16 1:00 ` Shawn Guo
0 siblings, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2020-03-16 1:00 UTC (permalink / raw)
To: Marek Vasut
Cc: Christoph Niedermaier, Fabio Estevam, NXP Linux Team,
linux-arm-kernel@lists.infradead.org
On Tue, Mar 10, 2020 at 10:10:36PM +0100, Marek Vasut wrote:
> On 3/10/20 10:08 AM, Christoph Niedermaier wrote:
> > Hi Marek,
>
> Hi,
>
> > From: linux-arm-kernel [mailto:linux-arm-kernel-bounces@lists.infradead.org] On Behalf Of Marek Vasut
> > Sent: Monday, March 9, 2020 9:08 PM
> >
> >> + display_bl: display-bl {
> >> + compatible = "pwm-backlight";
> >> + pwms = <&pwm1 0 50000 PWM_POLARITY_INVERTED>;
> >> + brightness-levels = <0 16 22 30 40 55 75 102 138 188 255>;
> >> + default-brightness-level = <8>;
> >> + enable-gpios = <&gpio3 27 GPIO_ACTIVE_HIGH>;
> >> + status = "okay";
> >> + };
> > ...
> >> +&pwm1 {
> >> + pinctrl-names = "default";
> >> + pinctrl-0 = <&pinctrl_pwm1>;
> >> + status = "okay";
> >> +};
> >
> > To get PWM_POLARITY_INVERTED, shouldn't we add the following line to pwm1:
> > #pwm-cells = <3>;
>
> It seems some boards do set it, some do not, although that might also be
> a bug in the DT of those other board files or I'm reading it wrong.
> Let's see what the maintainers have to say.
The binding doc says we should have it.
Shawn
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-03-16 1:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-09 20:08 [PATCH] ARM: dts: imx6q-dhcom: Add DH 560-200 display unit support Marek Vasut
2020-03-10 9:08 ` Christoph Niedermaier
2020-03-10 21:10 ` Marek Vasut
2020-03-16 1:00 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).