From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 280B9C18E5B for ; Mon, 16 Mar 2020 03:08:08 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 912F3206BE for ; Mon, 16 Mar 2020 03:08:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="uQ8ZYiGU"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="YuPz9BDe" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 912F3206BE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CZrZWjJTXlM7DMVnkGmX0DLGaAGzTGTeSsc3ndYk+uw=; b=uQ8ZYiGUPXI1pQ U8U8Tn/U/qA454YU/La9m97RkGuJeAzMbaIZNw9wcNlHof3QOv1HGsD/8YiQefi+0DkAxfcKqei4p AMsHr4xOdLILJ+nq6972ei/kjNIZ4075VVn9NqV53hgmQn0zS5DnL6wPs2iDy/P4f7JdSy5IFL8Ia koP6ZH7rPb03D/PVfcUB8SSOk+veLM5NDOTilvhR7j56IqlYu+vCo3m1iS3b5Q1qaMh5rjmL3OUBN kxnY2itpbcrUgDih30c+pXWxenHY0RJVVCOK9PBKXXMe6YfCNw17te3ailyuXQZhRqKQRZc4oyGSX CYqZEyH/WfU+bEBcAdkg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jDg6n-0003Ck-0G; Mon, 16 Mar 2020 03:08:05 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jDg6j-0003Bi-0R for linux-arm-kernel@lists.infradead.org; Mon, 16 Mar 2020 03:08:02 +0000 Received: from dragon (80.251.214.228.16clouds.com [80.251.214.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B83B420409; Mon, 16 Mar 2020 03:07:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584328079; bh=Ta/7YQGMbWyIGTwkBfx9j6N2DjoHmcD3pjam5ZHomYo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YuPz9BDeEmfsDued5suhi+F0CzjEaeD6rv51BFRYQ1JaiZD34V1qqxHrXeYsPG8zj XJXVKJ1sBrjUt3Ir53ZsoMrcqk/HSbkX4EXZp3wKxeD2iUNhqlSKLac+Dt3aXcpzLA Kjjwq/qCLJvbt4xwZRgKKwRuuvh3evpEwRSh3zWY= Date: Mon, 16 Mar 2020 11:07:45 +0800 From: Shawn Guo To: Peng Fan Subject: Re: [PATCH V3 1/7] firmware: imx: Add stubs for !CONFIG_IMX_SCU case Message-ID: <20200316030744.GC17221@dragon> References: <1583714300-19085-1-git-send-email-Anson.Huang@nxp.com> <20200316005219.GD17221@dragon> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200315_200801_094523_43BA3C1C X-CRM114-Status: GOOD ( 14.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "alexandre.belloni@bootlin.com" , "m.felsch@pengutronix.de" , Leonard Crestez , "festevam@gmail.com" , "linux-rtc@vger.kernel.org" , "robh@kernel.org" , "amit.kucheria@verdurent.com" , "wim@linux-watchdog.org" , Anson Huang , "daniel.lezcano@linaro.org" , "krzk@kernel.org" , dl-linux-imx , "linux-input@vger.kernel.org" , "rui.zhang@intel.com" , "ronald@innovation.ch" , "linux@roeck-us.net" , "linux-watchdog@vger.kernel.org" , "arnd@arndb.de" , "linux-pm@vger.kernel.org" , "s.hauer@pengutronix.de" , "tglx@linutronix.de" , "andriy.shevchenko@linux.intel.com" , Daniel Baluta , "linux-arm-kernel@lists.infradead.org" , Aisheng Dong , "a.zummo@towertech.it" , "gregkh@linuxfoundation.org" , "dmitry.torokhov@gmail.com" , "linux-kernel@vger.kernel.org" , "linux@rempel-privat.de" , "kernel@pengutronix.de" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Mar 16, 2020 at 02:51:47AM +0000, Peng Fan wrote: > Hi Shawn, > > > Subject: Re: [PATCH V3 1/7] firmware: imx: Add stubs for !CONFIG_IMX_SCU > > case > > > > On Mon, Mar 09, 2020 at 01:40:18PM +0000, Peng Fan wrote: > > > > Subject: [PATCH V3 1/7] firmware: imx: Add stubs for !CONFIG_IMX_SCU > > > > case > > > > > > I have one patch pending reviewing. > > > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatc > > > > > hwork.kernel.org%2Fpatch%2F11395247%2F&data=02%7C01%7Cpeng.f > > an%40n > > > > > xp.com%7C995815002e2b490791e008d7c9445133%7C686ea1d3bc2b4c6fa9 > > 2cd99c5c > > > > > 301635%7C0%7C0%7C637199167574579419&sdata=RM4Mtwl8LZ3ft9 > > 3uL3FQPcHT > > > 9lPHSqBOgugozkcLvag%3D&reserved=0 > > > > I dropped that patch from my queue and picked patch #2 from this series as > > the favor. > > I think dropping that patch might cause Linux-next build fail as previously showed, > because IMX_SCU_SOC depends on COMPILE_TEST. If you drop that patch, > also need to drop COMPILE_TEST from IMX_SCU_SOC. > > ld: drivers/soc/imx/soc-imx-scu.o: in function `.imx_scu_soc_probe': > soc-imx-scu.c:(.text.imx_scu_soc_probe+0x44): undefined reference to > `.imx_scu_get_handle' > ld: soc-imx-scu.c:(.text.imx_scu_soc_probe+0x134): undefined reference > to `.imx_scu_call_rpc' > ld: soc-imx-scu.c:(.text.imx_scu_soc_probe+0x20c): undefined reference > to `.imx_scu_call_rpc' > > Caused by commit > > 68c189e3a93c ("soc: imx: increase build coverage for imx8m soc > driver") > > What do you prefer? I personally think dummy functions would be good. I would rather drop COMPILE_TEST from IMX_SCU_SOC. Could you send a patch for that shortly? Shawn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel