From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D76CAC0044D for ; Mon, 16 Mar 2020 09:01:04 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A075E20658 for ; Mon, 16 Mar 2020 09:01:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="nwbsGy2B" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A075E20658 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0VxNngHjGHDmiCIkjHa2FgDKENrCv86y8hr0v85hRjk=; b=nwbsGy2BA8yX0D 50pysBkw9tI0lUgueyCnmJt4vr9GTDTdLY0akUcoHaeyK/TeVtaaEbb/lQyOixYIuajrlJZBV8y8p e8VJvsnTdgqGklvrgo3GYVriAwF3Fpf8J86TDGnPa0WIL/y9CJrT1uv9otxvZolZzu9WQA1pOrU+o DtfDtmAZT4BQBHzppaVVKXCLPmepGDmV14VeJTyCq4RoRikM006X/tPWQu2bNDKEXu5TQ042m6ySF QAZAI1kWyma/vJ65L/lSMYhJ3OXa4PLzngNsFxvmQhgBpsgSeQ/d7ycLmcCyGgOURfB9CwYsBVjXy BAj1ti9rK9nOcZYy8Lnw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jDlcN-0007Ur-NW; Mon, 16 Mar 2020 09:01:03 +0000 Received: from relay1-d.mail.gandi.net ([217.70.183.193]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jDlcK-0007Th-13 for linux-arm-kernel@lists.infradead.org; Mon, 16 Mar 2020 09:01:02 +0000 X-Originating-IP: 86.202.105.35 Received: from localhost (lfbn-lyo-1-9-35.w86-202.abo.wanadoo.fr [86.202.105.35]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id B1587240004; Mon, 16 Mar 2020 09:00:53 +0000 (UTC) Date: Mon, 16 Mar 2020 10:00:53 +0100 From: Alexandre Belloni To: Anson Huang Subject: Re: [PATCH V3 1/7] firmware: imx: Add stubs for !CONFIG_IMX_SCU case Message-ID: <20200316090053.GH4518@piout.net> References: <1583714300-19085-1-git-send-email-Anson.Huang@nxp.com> <20200316005219.GD17221@dragon> <20200316030744.GC17221@dragon> <20200316033447.GE17221@dragon> <20200316084056.GG4518@piout.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200316_020100_342139_A4A59DBA X-CRM114-Status: GOOD ( 16.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peng Fan , "m.felsch@pengutronix.de" , Leonard Crestez , "festevam@gmail.com" , "linux-rtc@vger.kernel.org" , "robh@kernel.org" , "amit.kucheria@verdurent.com" , "wim@linux-watchdog.org" , "daniel.lezcano@linaro.org" , "krzk@kernel.org" , dl-linux-imx , "linux-input@vger.kernel.org" , "rui.zhang@intel.com" , "ronald@innovation.ch" , "linux@roeck-us.net" , "linux-watchdog@vger.kernel.org" , "arnd@arndb.de" , "linux-pm@vger.kernel.org" , "s.hauer@pengutronix.de" , "tglx@linutronix.de" , "andriy.shevchenko@linux.intel.com" , Daniel Baluta , "linux-arm-kernel@lists.infradead.org" , Aisheng Dong , "a.zummo@towertech.it" , "gregkh@linuxfoundation.org" , "dmitry.torokhov@gmail.com" , "linux-kernel@vger.kernel.org" , "linux@rempel-privat.de" , "kernel@pengutronix.de" , Shawn Guo Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 16/03/2020 08:44:10+0000, Anson Huang wrote: > > > > Subject: Re: [PATCH V3 1/7] firmware: imx: Add stubs for !CONFIG_IMX_SCU > > case > > > > On 16/03/2020 08:04:17+0000, Anson Huang wrote: > > > Hi, Shawn > > > > > > > Subject: Re: [PATCH V3 1/7] firmware: imx: Add stubs for > > > > !CONFIG_IMX_SCU case > > > > > > > > On Mon, Mar 16, 2020 at 03:18:43AM +0000, Peng Fan wrote: > > > > > Just sent out. One more thing, I think all drivers depends on > > > > > IMX_SCU should not have COMPILE_TEST if we plan not to add dummy > > > > > functions. I see you picked up Anson's patch in imx/drivers branch, > > please check more. > > > > > > > > Ha, yes. COMPILE_TEST should be dropped for IMX_SCU_PD in Anson's > > patch. > > > > Thanks for reminding. > > > > > > I still NOT quite understand why we won't support COMPILE_TEST for SCU > > > drivers, with whose stubs, the build should be OK, if there is any > > > build error, we should try to fix it, NOT just remove the COMPILE_TEST > > support, any special reason? > > > > > > > COMPILE_TEST is supported as long as IMX_SCU is selected like is it for any > > driver depending on any bus. > > But without having " || COMPILE_TEST " in kconfig, COMPILE_TEST will NOT be supported, > I think as long as we have stubs for those SCU APIs, all drivers depending on IMX_SCU can > support COMPILE_TEST independently. > Why do you absolutely need to compile them independently? From a code coverage point of view, having: COMPILE_TEST=y CONFIG_IMX_SCU=y is enough to select and compile the remaining drivers. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel