From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BE62C0044D for ; Mon, 16 Mar 2020 10:30:10 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 08B9720658 for ; Mon, 16 Mar 2020 10:30:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="VZ4S+AJn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 08B9720658 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tLK2v2PTkV6/Z+vT/lyJzkEpNGRruo/Dw0Q/Hr32kqI=; b=VZ4S+AJn1H3H2/ 1LVt416UO0BKQKyzedUwLudkVQh3p3o9hkvW65Ttv26F5Cq0ks7AT6oS3Gnt51KkhLvlv6V/kvfei dHzVQdMbdW/xkuLG9yynnuD9esjLwf/O/QWSNbzzThACdfcs34eNy1t3ruASj/jUdyAzk55vN4K71 RStD+4L0x2CLSm8wYk40oMBOdmecgi70QxwQ+TCEckyfz1ECQdiS9OG9vQ5OCiUQNFVxKGewIkJpz WwL/Nc9D/wyCEj6MhM48xercFuMyz5t83gAfgYhmkat4Rj4aXfWqB8aPd9BXvqzAvLIQFUlDqvKqa H6kiVU8+lOTe1QQQq1hA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jDn0a-0007js-PP; Mon, 16 Mar 2020 10:30:08 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jDn0W-0007Iw-Ax for linux-arm-kernel@lists.infradead.org; Mon, 16 Mar 2020 10:30:05 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 671991FB; Mon, 16 Mar 2020 03:30:03 -0700 (PDT) Received: from lakrids.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6C3FA3F534; Mon, 16 Mar 2020 03:30:00 -0700 (PDT) Date: Mon, 16 Mar 2020 10:29:58 +0000 From: Mark Rutland To: Catalin Marinas Subject: Re: [PATCH v3 18/26] arm64: Introduce asm/vdso/processor.h Message-ID: <20200316102958.GC5746@lakrids.cambridge.arm.com> References: <20200313154345.56760-1-vincenzo.frascino@arm.com> <20200313154345.56760-19-vincenzo.frascino@arm.com> <20200315182950.GB32205@mbp> <20200316102214.GA5746@lakrids.cambridge.arm.com> <20200316102621.GC3005@mbp> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200316102621.GC3005@mbp> User-Agent: Mutt/1.11.1+11 (2f07cb52) (2018-12-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200316_033004_458037_8E21C543 X-CRM114-Status: GOOD ( 18.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dmitry Safonov <0x7f454c46@gmail.com>, linux-mips@vger.kernel.org, Vincenzo Frascino , Will Deacon , linux-arch@vger.kernel.org, Marc Zyngier , x86@kernel.org, Russell King , clang-built-linux@googlegroups.com, Ingo Molnar , Kees Cook , Arnd Bergmann , Will Deacon , Borislav Petkov , Andy Lutomirski , Thomas Gleixner , Peter Collingbourne , linux-arm-kernel@lists.infradead.org, Andrei Vagin , Stephen Boyd , Nick Desaulniers , linux-kernel@vger.kernel.org, Mark Salyzyn , Paul Burton Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Mar 16, 2020 at 10:26:22AM +0000, Catalin Marinas wrote: > On Mon, Mar 16, 2020 at 10:22:15AM +0000, Mark Rutland wrote: > > On Mon, Mar 16, 2020 at 09:42:32AM +0000, Vincenzo Frascino wrote: > > > On 3/15/20 6:30 PM, Catalin Marinas wrote: > > > > On Fri, Mar 13, 2020 at 03:43:37PM +0000, Vincenzo Frascino wrote: > > > >> +#ifdef CONFIG_COMPAT > > > >> +#if defined(CONFIG_ARM64_64K_PAGES) && defined(CONFIG_KUSER_HELPERS) > > > >> +/* > > > >> + * With CONFIG_ARM64_64K_PAGES enabled, the last page is occupied > > > >> + * by the compat vectors page. > > > >> + */ > > > >> +#define TASK_SIZE_32 UL(0x100000000) > > > >> +#else > > > >> +#define TASK_SIZE_32 (UL(0x100000000) - PAGE_SIZE) > > > >> +#endif /* CONFIG_ARM64_64K_PAGES */ > > > >> +#endif /* CONFIG_COMPAT */ > > > > > > > > Just curious, what's TASK_SIZE_32 used for in the vDSO code? You don't > > > > seem to move TASK_SIZE. > > > > > > I tried to fine grain the headers as much as I could in order to avoid > > > unneeded/unwanted inclusions: > > > * TASK_SIZE_32 is used to verify ABI consistency on vdso32 (please refer to > > > arch/arm64/kernel/vdso32/vgettimeofday.c). > > > * TASK_SIZE is not required by the vdso library hence it is not present in > > > these headers. > > > > It would be worth noting the former point in the commit message, since > > it can be surprising. > > > > I also think it's worth keeping the definitions together if that's easy, > > as it makes it easier to navigate the codebase, even if TASK_SIZE isn't > > necessary for the VDSO itself. > > It won't work as TASK_SIZE requires (on arm64) test_thread_flag() which > can't be made available to the vDSO. Ah; fair enough. Thanks, Mark. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel