Re: [PATCH net-next v4 00/11] net: ethernet: ti: add networking support for k3 am65x/j721e soc

Murali Karicheri
2020-03-19T13:12:26Z

On 03/17/2020 03:27 AM, Grygorii Strashko wrote:
> Hi
>
> This v4 series adds basic networking support support TI K3 AM654x/J721E SoC which
> have integrated Gigabit Ethernet MAC (Media Access Controller) into device MCU
> domain and named MCU_CPSW0 (CPSW2G NUSS).
>
> Formally TRMs refer CPSW2G NUSS as two-port Gigabit Ethernet Switch subsystem
> with port 0 being the CPPI DMA host port and port 1 being the external Ethernet
> port, but for 1 external port device it's just Port 0 <-> ALE <-> Port 1 and it's
> rather device with HW filtering capabilities then actually switching device.
> It's expected to have similar devices, but with more external ports.
>
> The new Host port 0 Communications Port Programming Interface (CPPI5) is
> operating by TI AM654x/J721E NAVSS Unified DMA Peripheral Root Complex (UDMA-P)
> controller [1].
>
> The CPSW2G contains below modules for which existing code is re-used:
> - MAC SL: cpsw_sl.c
> - Address Lookup Engine (ALE): cpsw_ale.c, basically compatible with K2 66AK2E/G
> - Management Data Input/Output interface (MDIO): davinci_mdio.c, fully
> compatible with TI AM3/4/5 devices
>
> Basic features supported by CPSW2G NUSS driver:
> - VLAN support, 802.1Q compliant, Auto add port VLAN for untagged frames on
> ingress, Auto VLAN removal on egress and auto pad to minimum frame size.
> - multicast filtering
> - promisc mode
> - TX multiq support in Round Robin or Fixed priority modes
> - RX checksum offload for non-fragmented IPv4/IPv6 TCP/UDP packets
> - TX checksum offload support for IPv4/IPv6 TCP/UDP packets (J721E only).
>
> Features under development:
> - Support for IEEE 1588 Clock Synchronization. The CPSW2G NUSS includes new
> version of Common Platform Time Sync (CPTS)
> - tc-mqprio: priority level Quality Of Service (QOS) support (802.1p)
> - tc-cbs: Support for Audio/Video Bridging (P802.1Qav/D6.0) HW shapers
> - tc-taprio: IEEE 802.1Qbv/D2.2 Enhancements for Scheduled Traffic
> - frame preemption: IEEE P902.3br/D2.0 Interspersing Express Traffic, 802.1Qbu
> - extended ALE features: classifier/policers, auto-aging
>
> Patches 1-6 are intended for netdev, Patches 7-11 are intended for K3 Platform
> tree and provided here for testing purposes.
>
> Changes in v4:
> - fixed minor comments from Jakub Kicinski <kuba@kernel.org>
> - dependencies resolved: required phy-rmii-sel changes [2] queued for merge
> except one [3] which is included in this series with Kishon's ask.
>

Tested-by: Murali Karicheri <m-karicheri2@ti.com>

Logs at https://pastebin.ubuntu.com/p/rP6pcMqcw5/

> Changes in v3:
> - add ARM64 defconfig changes for testing purposes
> - fixed DT yaml definition
> - fixed comments from Jakub Kicinski <kuba@kernel.org>
>
> Changes in v2:
> - fixed DT yaml definition
> - fixed comments from David Miller
>
> v3: https://patchwork.ozlabs.org/cover/1254568/
> v2: https://patchwork.ozlabs.org/cover/1250674/
> v1: https://lwn.net/Articles/813087/
>
> TRMs:
> AM654: http://www.ti.com/lit/ug/spruid7e/spruid7e.pdf
> J721E: http://www.ti.com/lit/ug/spruil1a/spruil1a.pdf
>
> Preliminary documentation can be found at:
> http://software-dl.ti.com/processor-sdk-linux/esd/docs/latest/linux/Foundational_Components/Kernel/Kernel_Drivers/Network/K3_CPSW2g.html
>
> [1] https://lwn.net/Articles/808030/
> [2] https://lkml.org/lkml/2020/2/22/100
> [3] https://lkml.org/lkml/2020/3/3/724
>
> Grygorii Strashko (11):
> phy: ti: gmii-sel: simplify config dependencies between net drivers
> and gmii phy
> net: ethernet: ti: ale: fix seeing unreg mcast packets with promisc
> and allmulti disabled
> net: ethernet: ti: ale: add support for mac-only mode
> net: ethernet: ti: ale: am65: add support for default thread cfg
> dt-binding: ti: am65x: document mcu cpsw nuss
> net: ethernet: ti: introduce am65x/j721e gigabit eth subsystem driver
> arm64: dts: ti: k3-am65-mcu: add cpsw nuss node
> arm64: dts: k3-am654-base-board: add mcu cpsw nuss pinmux and phy defs
> arm64: dts: ti: k3-j721e-mcu: add mcu cpsw nuss node
> arm64: dts: ti: k3-j721e-common-proc-board: add mcu cpsw nuss pinmux
> and phy defs
> arm64: defconfig: ti: k3: enable dma and networking
>
> .../bindings/net/ti,k3-am654-cpsw-nuss.yaml | 226 ++
> arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi | 49 +
> arch/arm64/boot/dts/ti/k3-am65.dtsi | 1 +
> .../arm64/boot/dts/ti/k3-am654-base-board.dts | 42 +
> .../dts/ti/k3-j721e-common-proc-board.dts | 43 +
> .../boot/dts/ti/k3-j721e-mcu-wakeup.dtsi | 49 +
> arch/arm64/boot/dts/ti/k3-j721e.dtsi | 1 +
> arch/arm64/configs/defconfig | 3 +
> drivers/net/ethernet/ti/Kconfig | 20 +-
> drivers/net/ethernet/ti/Makefile | 3 +
> drivers/net/ethernet/ti/am65-cpsw-ethtool.c | 747 +++++++
> drivers/net/ethernet/ti/am65-cpsw-nuss.c | 1965 +++++++++++++++++
> drivers/net/ethernet/ti/am65-cpsw-nuss.h | 143 ++
> drivers/net/ethernet/ti/cpsw_ale.c | 38 +
> drivers/net/ethernet/ti/cpsw_ale.h | 4 +
> drivers/net/ethernet/ti/k3-udma-desc-pool.c | 126 ++
> drivers/net/ethernet/ti/k3-udma-desc-pool.h | 30 +
> drivers/phy/ti/Kconfig | 3 -
> 18 files changed, 3488 insertions(+), 5 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/net/ti,k3-am654-cpsw-nuss.yaml
> create mode 100644 drivers/net/ethernet/ti/am65-cpsw-ethtool.c
> create mode 100644 drivers/net/ethernet/ti/am65-cpsw-nuss.c
> create mode 100644 drivers/net/ethernet/ti/am65-cpsw-nuss.h
> create mode 100644 drivers/net/ethernet/ti/k3-udma-desc-pool.c
> create mode 100644 drivers/net/ethernet/ti/k3-udma-desc-pool.h
>

--
Murali Karicheri
Texas Instruments