From: Pascal Roeleven <dev@pascalroeleven.nl>
To: "Thierry Reding" <thierry.reding@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Maxime Ripard" <mripard@kernel.org>,
"Chen-Yu Tsai" <wens@csie.org>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
linux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Cc: linux-sunxi@googlegroups.com, Pascal Roeleven <dev@pascalroeleven.nl>
Subject: [RFC PATCH 2/4] pwm: sun4i: Disable pwm before turning off clock gate
Date: Tue, 17 Mar 2020 16:59:04 +0100 [thread overview]
Message-ID: <20200317155906.31288-3-dev@pascalroeleven.nl> (raw)
In-Reply-To: <20200317155906.31288-1-dev@pascalroeleven.nl>
The clock gate must stay on when disabling to ensure proper turning off.
After one period it will still be disabled anyway.
Signed-off-by: Pascal Roeleven <dev@pascalroeleven.nl>
---
drivers/pwm/pwm-sun4i.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/pwm/pwm-sun4i.c b/drivers/pwm/pwm-sun4i.c
index 5c677c563..56942036b 100644
--- a/drivers/pwm/pwm-sun4i.c
+++ b/drivers/pwm/pwm-sun4i.c
@@ -292,13 +292,12 @@ static int sun4i_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm,
else
ctrl |= BIT_CH(PWM_ACT_STATE, pwm->hwpwm);
- ctrl |= BIT_CH(PWM_CLK_GATING, pwm->hwpwm);
-
if (state->enabled) {
ctrl |= BIT_CH(PWM_EN, pwm->hwpwm);
+ ctrl |= BIT_CH(PWM_CLK_GATING, pwm->hwpwm);
} else {
+ /* Turn gate off after delay to ensure proper turning off */
ctrl &= ~BIT_CH(PWM_EN, pwm->hwpwm);
- ctrl &= ~BIT_CH(PWM_CLK_GATING, pwm->hwpwm);
}
sun4i_pwm_writel(sun4i_pwm, ctrl, PWM_CTRL_REG);
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-03-17 16:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-17 15:59 [RFC PATCH 0/4] pwm: sun4i: Properly turn pwm off and fix stuck output state Pascal Roeleven
2020-03-17 15:59 ` [RFC PATCH 1/4] pwm: sun4i: Remove redundant needs_delay Pascal Roeleven
2020-03-30 14:16 ` Thierry Reding
2020-03-17 15:59 ` Pascal Roeleven [this message]
2020-04-09 15:19 ` [RFC PATCH 2/4] pwm: sun4i: Disable pwm before turning off clock gate Chen-Yu Tsai
2020-03-17 15:59 ` [RFC PATCH 3/4] pwm: sun4i: Move delay to function Pascal Roeleven
2020-04-09 15:20 ` [linux-sunxi] " Chen-Yu Tsai
2020-03-17 15:59 ` [RFC PATCH 4/4] pwm: sun4i: Delay after writing the period Pascal Roeleven
2020-04-09 15:20 ` Chen-Yu Tsai
2020-04-22 3:43 ` [linux-sunxi] " Samuel Holland
2020-04-22 8:40 ` Pascal Roeleven
2020-03-17 16:45 ` [RFC PATCH 0/4] pwm: sun4i: Properly turn pwm off and fix stuck output state Emil Lenngren
2020-03-17 18:15 ` Pascal Roeleven
2020-03-17 19:35 ` Emil Lenngren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200317155906.31288-3-dev@pascalroeleven.nl \
--to=dev@pascalroeleven.nl \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=mripard@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).