From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7869CC2BB1D for ; Tue, 17 Mar 2020 18:32:16 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4CF2B20714 for ; Tue, 17 Mar 2020 18:32:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="K13ppgvT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4CF2B20714 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ePHOWgje/p0RZYVpNad9deF0D89H5RtYvjBy6d+AQjE=; b=K13ppgvTj/QoHG DQpKMnYet5AmsuS4f1aVGXtLFGWf8CHLB2WkQbyg+io2v7xi2GBEsUvF+L5ff2NFobuzUOAwRzibN +qyPGFp1r/vvf2X56RbHJNjqbBX++nxPMC33QZSq7D5/uqbXxW85H5dpZwIIt5lPdE7oSThtVWWGm sr+wALC00LRjm1ObW+Wpv2F9Khm6ua31C1sAosNvxZk0dYpxlt/F0RLNJz/0QaQddPpSapUnxslYV 3mBVzPpADZGrSYeqx5rpCL1OqF+3oK5pjmxIV+mio6YEKIeJmWJa/hspXu878T6px6UUtlf4cioqc z1KGxJz50H7IHefoGrqw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jEH0h-0007aO-LX; Tue, 17 Mar 2020 18:32:15 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jEH0f-0007a6-06 for linux-arm-kernel@lists.infradead.org; Tue, 17 Mar 2020 18:32:14 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 57C2231B; Tue, 17 Mar 2020 11:32:12 -0700 (PDT) Received: from arrakis.emea.arm.com (arrakis.cambridge.arm.com [10.1.196.71]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5459E3F67D; Tue, 17 Mar 2020 11:32:11 -0700 (PDT) Date: Tue, 17 Mar 2020 18:32:09 +0000 From: Catalin Marinas To: Gavin Shan Subject: Re: [PATCH] arm64/kernel: Simplify __cpu_up() by bailing out early Message-ID: <20200317183209.GG632169@arrakis.emea.arm.com> References: <20200302020340.119588-1-gshan@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200302020340.119588-1-gshan@redhat.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200317_113213_082577_03357254 X-CRM114-Status: UNSURE ( 9.00 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, maz@kernel.org, linux-kernel@vger.kernel.org, shan.gavin@gmail.com, will@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Mar 02, 2020 at 01:03:40PM +1100, Gavin Shan wrote: > The function __cpu_up() is invoked to bring up the target CPU through > the backend, PSCI for example. The nested if statements won't be needed > if we bail out early on the following two conditions where the status > won't be checked. The code looks simplified in that case. > > * Error returned from the backend (e.g. PSCI) > * The target CPU has been marked as onlined > > Signed-off-by: Gavin Shan Queued for 5.7. Thanks. -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel