From: Will Deacon <will@kernel.org>
To: "Rémi Denis-Courmont" <remi@remlab.net>
Cc: suzuki.poulose@arm.com, maz@kernel.org,
linux-kernel@vger.kernel.org, james.morse@arm.com,
linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com,
kvmarm@lists.cs.columbia.edu, julien.thierry.kdev@gmail.com
Subject: Re: [PATCH] arm64: move kimage_vaddr to .rodata
Date: Tue, 17 Mar 2020 22:26:56 +0000 [thread overview]
Message-ID: <20200317222656.GE20788@willie-the-truck> (raw)
In-Reply-To: <20200312094002.153302-1-remi@remlab.net>
On Thu, Mar 12, 2020 at 11:40:02AM +0200, Rémi Denis-Courmont wrote:
> From: Remi Denis-Courmont <remi.denis.courmont@huawei.com>
>
> This datum is not referenced from .idmap.text: it does not need to be
> mapped in idmap. Lets move it to .rodata as it is never written to after
> early boot of the primary CPU.
> (Maybe .data.ro_after_init would be cleaner though?)
>
> Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>
> ---
> arch/arm64/kernel/head.S | 12 +++++++-----
> 1 file changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm64/kernel/head.S b/arch/arm64/kernel/head.S
> index 6e08ee2b4d55..8e5c0e0040e4 100644
> --- a/arch/arm64/kernel/head.S
> +++ b/arch/arm64/kernel/head.S
> @@ -457,17 +457,19 @@ SYM_FUNC_START_LOCAL(__primary_switched)
> b start_kernel
> SYM_FUNC_END(__primary_switched)
>
> + .pushsection ".rodata", "a"
> +SYM_DATA_START(kimage_vaddr)
> + .quad _text - TEXT_OFFSET
> +SYM_DATA_END(kimage_vaddr)
> +EXPORT_SYMBOL(kimage_vaddr)
> + .popsection
> +
> /*
> * end early head section, begin head code that is also used for
> * hotplug and needs to have the same protections as the text region
> */
> .section ".idmap.text","awx"
>
> -SYM_DATA_START(kimage_vaddr)
> - .quad _text - TEXT_OFFSET
> -SYM_DATA_END(kimage_vaddr)
> -EXPORT_SYMBOL(kimage_vaddr)
Acked-by: Will Deacon <will@kernel.org>
Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-03-17 22:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-12 9:40 [PATCH] arm64: move kimage_vaddr to .rodata Rémi Denis-Courmont
2020-03-12 16:40 ` Mark Rutland
2020-03-12 16:42 ` Remi Denis-Courmont
2020-03-16 10:32 ` Rémi Denis-Courmont
2020-03-17 22:26 ` Will Deacon [this message]
2020-03-20 18:24 ` Catalin Marinas
-- strict thread matches above, loose matches on Subject: below --
2020-03-12 9:38 Rémi Denis-Courmont
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200317222656.GE20788@willie-the-truck \
--to=will@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=james.morse@arm.com \
--cc=julien.thierry.kdev@gmail.com \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=remi@remlab.net \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox