From: Will Deacon <will@kernel.org>
To: Tuan Phan <tuanphan@os.amperecomputing.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
patches@amperecomputing.com, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, suzuki.poulose@arm.com
Subject: Re: [PATCH 1/2] perf: dsu: Allow multiple devices share same IRQ.
Date: Wed, 18 Mar 2020 20:57:05 +0000 [thread overview]
Message-ID: <20200318205704.GC8094@willie-the-truck> (raw)
In-Reply-To: <1584491176-31358-1-git-send-email-tuanphan@os.amperecomputing.com>
[+Suzuki, since he wrote the driver]
On Tue, Mar 17, 2020 at 05:26:15PM -0700, Tuan Phan wrote:
> Add IRQF_SHARED flag when register IRQ such that multiple dsu
> devices can share same IRQ.
>
> Signed-off-by: Tuan Phan <tuanphan@os.amperecomputing.com>
> ---
> drivers/perf/arm_dsu_pmu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/perf/arm_dsu_pmu.c b/drivers/perf/arm_dsu_pmu.c
> index 70968c8..2622900 100644
> --- a/drivers/perf/arm_dsu_pmu.c
> +++ b/drivers/perf/arm_dsu_pmu.c
> @@ -700,7 +700,7 @@ static int dsu_pmu_device_probe(struct platform_device *pdev)
> if (!name)
> return -ENOMEM;
> rc = devm_request_irq(&pdev->dev, irq, dsu_pmu_handle_irq,
> - IRQF_NOBALANCING, name, dsu_pmu);
> + IRQF_NOBALANCING | IRQF_SHARED, name, dsu_pmu);
> if (rc) {
> dev_warn(&pdev->dev, "Failed to request IRQ %d\n", irq);
> return rc;
> --
> 2.7.4
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-03-18 20:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-18 0:26 [PATCH 1/2] perf: dsu: Allow multiple devices share same IRQ Tuan Phan
2020-03-18 20:57 ` Will Deacon [this message]
2020-03-19 14:32 ` Mark Rutland
2020-03-19 14:35 ` Mark Rutland
2020-03-19 16:12 ` Robin Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200318205704.GC8094@willie-the-truck \
--to=will@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=patches@amperecomputing.com \
--cc=suzuki.poulose@arm.com \
--cc=tuanphan@os.amperecomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox