From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69A81C4332B for ; Thu, 19 Mar 2020 08:15:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0FA7120663 for ; Thu, 19 Mar 2020 08:15:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="tMC+FW8u"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="nGHgshCI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0FA7120663 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JS+/ALyHLCfGoysTYh9071qoDxXCFIr1DSjzBEJapno=; b=tMC+FW8uLzo3hX tLRsmtWsbdZmRXayNmAaKmzQoA/SQFxIveyV4T0Y+4S8gqdDKnYXcSrdnOCB1nrIBgD9gfWeXeOVD QHciBjHXqsdLBCh2Tbair9Jib5aqeFF/bueCcEK7RejN7h9RM2TvKqR1XiM+nAo9xf5KbT2f9ySAG iMpT8d28NYUxcwOCFTBDRT+Eky0mkPadvxi9QYZtOYu5DNQma5toM2ppgGkdnrDYlHOvMKTwuL0PF Og2K/F0JFuVlyH12RUzkryMnpuoID63xn5ib/t+MZfx75hh+ylo8TRR28fRt3bj51yUFVAxsInVs2 Td2GTHE0JZP2KXncvY5w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jEqLC-00030d-Pp; Thu, 19 Mar 2020 08:15:46 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jEqL8-00030B-Oy for linux-arm-kernel@lists.infradead.org; Thu, 19 Mar 2020 08:15:45 +0000 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D66F420663; Thu, 19 Mar 2020 08:15:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584605742; bh=LdJipUFyZBF+HWb06ft7tA5xx8pfQFU78elBxzYZlTM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nGHgshCIeIYyjXviV1KXQzzgZIyEakQRG7TP5KXx+V4qOKEcRm3+dvc9WuVV0h+14 x36voC/EuAh3rl/mYHzUrxGeciPHqAiyi2/vt2Zx+wkp7/OoPosTm3hUWpYYe5tsz5 cdoU3/vyva6X37aZr3e2/j3RW8sI/VWfPKm4j/5c= Date: Thu, 19 Mar 2020 08:15:37 +0000 From: Will Deacon To: Ard Biesheuvel Subject: Re: [Patch][Fix] crypto: arm{,64} neon: memzero_explicit aes-cbc key Message-ID: <20200319081536.GA20670@willie-the-truck> References: <20200313110258.94A0668C4E@verein.lst.de> <20200317221743.GD20788@willie-the-truck> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200319_011542_838670_29801D9F X-CRM114-Status: GOOD ( 18.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Herbert Xu , Catalin Marinas , Russell King , Linux Kernel Mailing List , Torsten Duwe , "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" , "David S. Miller" , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Mar 18, 2020 at 04:13:33PM -0400, Ard Biesheuvel wrote: > On Tue, 17 Mar 2020 at 18:17, Will Deacon wrote: > > > > [+Ard] > > > > On Fri, Mar 13, 2020 at 12:02:58PM +0100, Torsten Duwe wrote: > > > From: Torsten Duwe > > > > > > At function exit, do not leave the expanded key in the rk struct > > > which got allocated on the stack. > > > > > > Signed-off-by: Torsten Duwe > > > --- > > > Another small fix from our FIPS evaluation. I hope you don't mind I merged > > > arm32 and arm64 into one patch -- this is really simple. > > > --- a/arch/arm/crypto/aes-neonbs-glue.c > > > +++ b/arch/arm/crypto/aes-neonbs-glue.c > > > @@ -138,6 +138,7 @@ static int aesbs_cbc_setkey(struct crypto_skcipher *tfm, const u8 *in_key, > > > kernel_neon_begin(); > > > aesbs_convert_key(ctx->key.rk, rk.key_enc, ctx->key.rounds); > > > kernel_neon_end(); > > > + memzero_explicit(&rk, sizeof(rk)); > > > > > > return crypto_cipher_setkey(ctx->enc_tfm, in_key, key_len); > > > } > > > diff --git a/arch/arm64/crypto/aes-neonbs-glue.c b/arch/arm64/crypto/aes-neonbs-glue.c > > > index e3e27349a9fe..c0b980503643 100644 > > > --- a/arch/arm64/crypto/aes-neonbs-glue.c > > > +++ b/arch/arm64/crypto/aes-neonbs-glue.c > > > @@ -151,6 +151,7 @@ static int aesbs_cbc_setkey(struct crypto_skcipher *tfm, const u8 *in_key, > > > kernel_neon_begin(); > > > aesbs_convert_key(ctx->key.rk, rk.key_enc, ctx->key.rounds); > > > kernel_neon_end(); > > > + memzero_explicit(&rk, sizeof(rk)); > > > > > > return 0; > > > } > > > > I'm certainly not a crypto person, but this looks sensible to me and I > > couldn't find any other similar stack variable usage under > > arch/arm64/crypto/ at a quick glance. > > > > Acked-by: Will Deacon > > > > Acked-by: Ard Biesheuvel Cheers, Ard. I'm assuming that Herbert will pick this up via the crypto tree. Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel