From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BC4CC54EEB for ; Mon, 23 Mar 2020 15:29:22 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0C3DE20409 for ; Mon, 23 Mar 2020 15:29:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rCy0sios" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0C3DE20409 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=M+vfhfgYM0ccsytCRBBX4r8Fvi1S5q7ZHCPeZqzqe4c=; b=rCy0siosZ9Qjaz /AJmAbijNvYTBTzDCMaxtRWKL7zeMGDCX9qcDEMlz/AtZ2P0EtuakmT/cHD+GcXmRGM2F0XcPnBj8 I2+LkR6c9ILq8baV6PwkR0D1gbiEZEV/534y4uSm9Dt1Fdjy03VYZ4qWBt4scxYyZ+qld9+KVWO/K NoCgN2yFTu0OosYHjzNhg9JJTc3seta3clVtZ0guBhByoPn4BLKoUVATYGC0OgjS2KfgROlC07IhP fBWwQob7evJqLLRVzCmAgI1t+HEcXgzbflG0/RoUSgi4FuFC2lGBWdLxPqeKv6gQwRKBkflhd4k0l 4Njq44ztazNfAx5QMZVA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jGP0v-000647-Sh; Mon, 23 Mar 2020 15:29:17 +0000 Received: from mga02.intel.com ([134.134.136.20]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jGP0s-000637-LO for linux-arm-kernel@lists.infradead.org; Mon, 23 Mar 2020 15:29:16 +0000 IronPort-SDR: xZeeNRjjtbnVVjh42PHHN2Xcbh4CfUKRT0oRwv09xa2Iw15U7f/pgwkEioa4oGQDuBe1gxZ2lF qno0dr2Lp0iw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Mar 2020 08:29:10 -0700 IronPort-SDR: yayqoarf0l9NveDHmC/sqla8uNPjr0N8shaxffNuAwPkByVFjT7hsOSfphorNwP7R2dv9kN0mF tMgMyB8VORFA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,296,1580803200"; d="scan'208";a="269910183" Received: from sjchrist-coffee.jf.intel.com (HELO linux.intel.com) ([10.54.74.202]) by fmsmga004.fm.intel.com with ESMTP; 23 Mar 2020 08:29:09 -0700 Date: Mon, 23 Mar 2020 08:29:09 -0700 From: Sean Christopherson To: Vitaly Kuznetsov Subject: Re: [PATCH v3 2/9] KVM: x86: Move init-only kvm_x86_ops to separate struct Message-ID: <20200323152909.GE28711@linux.intel.com> References: <20200321202603.19355-1-sean.j.christopherson@intel.com> <20200321202603.19355-3-sean.j.christopherson@intel.com> <87lfnr9sqn.fsf@vitty.brq.redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87lfnr9sqn.fsf@vitty.brq.redhat.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200323_082914_748127_7A345EB5 X-CRM114-Status: GOOD ( 15.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Wanpeng Li , Janosch Frank , kvm@vger.kernel.org, David Hildenbrand , Marc Zyngier , Joerg Roedel , Cornelia Huck , linux-mips@vger.kernel.org, kvm-ppc@vger.kernel.org, linux-kernel@vger.kernel.org, Paul Mackerras , Christian Borntraeger , James Morse , linux-arm-kernel@lists.infradead.org, Paolo Bonzini , Suzuki K Poulose , kvmarm@lists.cs.columbia.edu, Julien Thierry , Jim Mattson Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Mar 23, 2020 at 01:10:40PM +0100, Vitaly Kuznetsov wrote: > Sean Christopherson writes: > > > + > > + .runtime_ops = &svm_x86_ops, > > +}; > > Unrelated to your patch but I think we can make the naming of some of > these functions more consistend on SVM/VMX, in particular I'd suggest > > has_svm() -> cpu_has_svm_support() > is_disabled -> svm_disabled_by_bios() > ... > (see below for VMX) > > > + > > static int __init svm_init(void) > > { > > - return kvm_init(&svm_x86_ops, sizeof(struct vcpu_svm), > > + return kvm_init(&svm_init_ops, sizeof(struct vcpu_svm), > > __alignof__(struct vcpu_svm), THIS_MODULE); > > } > > > > diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c > > index 07299a957d4a..ffcdcc86f5b7 100644 > > --- a/arch/x86/kvm/vmx/vmx.c > > +++ b/arch/x86/kvm/vmx/vmx.c > > @@ -7842,11 +7842,8 @@ static bool vmx_check_apicv_inhibit_reasons(ulong bit) > > } > > > > static struct kvm_x86_ops vmx_x86_ops __ro_after_init = { > > - .cpu_has_kvm_support = cpu_has_kvm_support, > > - .disabled_by_bios = vmx_disabled_by_bios, > > - .hardware_setup = hardware_setup, > > .hardware_unsetup = hardware_unsetup, > > - .check_processor_compatibility = vmx_check_processor_compat, > > + > > .hardware_enable = hardware_enable, > > .hardware_disable = hardware_disable, > > .cpu_has_accelerated_tpr = report_flexpriority, > > @@ -7981,6 +7978,15 @@ static struct kvm_x86_ops vmx_x86_ops __ro_after_init = { > > .apic_init_signal_blocked = vmx_apic_init_signal_blocked, > > }; > > > > +static struct kvm_x86_init_ops vmx_init_ops __initdata = { > > + .cpu_has_kvm_support = cpu_has_kvm_support, > > + .disabled_by_bios = vmx_disabled_by_bios, > > + .check_processor_compatibility = vmx_check_processor_compat, > > + .hardware_setup = hardware_setup, > > cpu_has_kvm_support() -> cpu_has_vmx_support() > hardware_setup() -> vmx_hardware_setup() Preaching to the choir on this one. The VMX functions without prefixes in in particular annoy me to no end, e.g. hardware_setup(). Though the worst is probably ".vcpu_create = vmx_create_vcpu", if I had a nickel for every time I've tried to find vmx_vcpu_create()... What if we added a macro to auto-generate the common/required hooks? E.g.: static struct kvm_x86_ops vmx_x86_ops __ro_after_init = { MANDATORY_KVM_X86_OPS(vmx), .pmu_ops = &intel_pmu_ops, ... }; That'd enforce consistent naming, and would provide a bit of documentation as to which hooks are optional, e.g. many of the nested hooks, and which must be defined for KVM to function. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel