From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F5A2C54EEB for ; Mon, 23 Mar 2020 17:39:09 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0B27820722 for ; Mon, 23 Mar 2020 17:39:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Ffo+0s43"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="THxz32G+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0B27820722 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Date:Message-Id:To:References: In-Reply-To:From:Subject:MIME-Version:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mQRFQ64tGjeDPs5FOVL5iGBW5sE+i9DWy66+8aRxU4U=; b=Ffo+0s43yjSneV cBeI2woLhxuINVavywpzUT9ZyLOgVkCNYPCsb71CsMPLVdDuBDNxTHfziZFvDW8jyBLd99doN5z3G +cxHyzrt8boYgjZ8SQIEsY1xzFalOJR0pnV2JuWzVUz7cMDcptWzPbdxtVnVNg1Q1IUI3ZO/WfiVP bFAeLKrlAv1zMAWiHfcAx1PqsqV9c4IxIEDjLpwGMyzqGSXGuG5Mr5KVymXFxIK8bG7FWPJIeZpXT vmMJqewjSPaCdrd5tPLDW0PTGF/3M6BFzKQlh4j+8+0SNp8mfKzWRuNNNeduhdsOmxFKBQTPeAI8/ zOYaJMMz06kqRG3Fa6aA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jGR2a-0005RC-AT; Mon, 23 Mar 2020 17:39:08 +0000 Received: from mail26.static.mailgun.info ([104.130.122.26]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jGR2O-0005LU-Gt for linux-arm-kernel@lists.infradead.org; Mon, 23 Mar 2020 17:39:00 +0000 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1584985138; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=9lPNjkDMRM0Q3Ns6VRdg5nypoUormOtZGmZvJKo/sI8=; b=THxz32G+mj2Dil4EPnhTFTYJ/u1mGQT1nhjzWm/55gLoSt9ZdC23a29tAqGu6CC5tnE39DV5 IWKavfVwDck4IcfP/+o7Pu9N2NdTlfQDl4EVZObd0a6Iq0d8BdEVldyOXnRch6QHiBiQe79F P3q/25jqz8jUe80EpOl29B5MC6k= X-Mailgun-Sending-Ip: 104.130.122.26 X-Mailgun-Sid: WyJiYzAxZiIsICJsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e78f429.7f7fe05a8c70-smtp-out-n05; Mon, 23 Mar 2020 17:38:49 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 56CBFC432C2; Mon, 23 Mar 2020 17:38:48 +0000 (UTC) Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 0B64EC433CB; Mon, 23 Mar 2020 17:38:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 0B64EC433CB Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org MIME-Version: 1.0 Subject: Re: [PATCH][next] ath: Replace zero-length array with flexible-array member From: Kalle Valo In-Reply-To: <20200224165952.GA9377@embeddedor> References: <20200224165952.GA9377@embeddedor> To: "Gustavo A. R. Silva" User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20200323173848.56CBFC432C2@smtp.codeaurora.org> Date: Mon, 23 Mar 2020 17:38:48 +0000 (UTC) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200323_103858_903229_E3BF9112 X-CRM114-Status: GOOD ( 13.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Maya Erez , Alexandre Torgue , "Gustavo A. R. Silva" , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, ath10k@lists.infradead.org, ath11k@lists.infradead.org, wil6210@qti.qualcomm.com, Maxime Coquelin , Christian Lamparter , wcn36xx@lists.infradead.org, "David S. Miller" , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org "Gustavo A. R. Silva" wrote: > The current codebase makes use of the zero-length array language > extension to the C90 standard, but the preferred mechanism to declare > variable-length types such as these ones is a flexible array member[1][2], > introduced in C99: > > struct foo { > int stuff; > struct boo array[]; > }; > > By making use of the mechanism above, we will get a compiler warning > in case the flexible array does not occur last in the structure, which > will help us prevent some kind of undefined behavior bugs from being > inadvertently introduced[3] to the codebase from now on. > > Also, notice that, dynamic memory allocations won't be affected by > this change: > > "Flexible array members have incomplete type, and so the sizeof operator > may not be applied. As a quirk of the original implementation of > zero-length arrays, sizeof evaluates to zero."[1] > > This issue was detected with the help of Coccinelle. > > [1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html > [2] https://github.com/KSPP/linux/issues/21 > [3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour") > > Signed-off-by: Gustavo A. R. Silva Fails to apply, please rebase on top of my ath.git master branch. error: patch failed: drivers/net/wireless/ath/ath10k/core.h:1223 error: drivers/net/wireless/ath/ath10k/core.h: patch does not apply error: patch failed: drivers/net/wireless/ath/ath11k/debug.h:65 error: drivers/net/wireless/ath/ath11k/debug.h: patch does not apply error: patch failed: drivers/net/wireless/ath/ath11k/rx_desc.h:1206 error: drivers/net/wireless/ath/ath11k/rx_desc.h: patch does not apply stg import: Diff does not apply cleanly Patch set to Changes Requested. -- https://patchwork.kernel.org/patch/11401227/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel