From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A5D1C2BAEE for ; Tue, 24 Mar 2020 16:13:00 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 412912080C for ; Tue, 24 Mar 2020 16:13:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="s52Pymk4"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="jhEyVSol" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 412912080C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UVDDA7ER8Fw1dI6ylyKqlAq+izRfYY6YyZih9mmsDFU=; b=s52Pymk49beMjA 6sQoY0DFN3MmL6+d+hzGcX4wkF9Y7nxlvWe/EVTm3mhdHCtlT0a61CgAJLKNT+2n6D4T5lDvtvxCB C9WhqUyXhzLSD2pEQzglctlQJSqocfF5ssjQ20BmtpuNDBqrtqvUM7LsRw+lArJTRmNBmjP6xxBls tgLPmf2Etnb1y58o86LtnM6tKMblTeDRiROQLmpI1zTBmTpSu8hFn0X2WkbVzbmwGPRq9aVqHjNDl qPY7Q0m8qHCcAAIqLZaYSubiqIPmq52YFNtkHUFgFOcShPdUXMzT3rVLrjjeHOyZY2dtupSiLQObY AoSN142pkddA1CC1DZ6g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jGmAh-0000Za-NC; Tue, 24 Mar 2020 16:12:55 +0000 Received: from perceval.ideasonboard.com ([2001:4b98:dc2:55:216:3eff:fef7:d647]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jGmAd-0000RH-RR for linux-arm-kernel@lists.infradead.org; Tue, 24 Mar 2020 16:12:53 +0000 Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 0CB43308; Tue, 24 Mar 2020 17:12:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1585066344; bh=h9AU8lIpV7OHn82ip0Jw12bYSRW82NU8UY8yuWnDD/A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jhEyVSolpqtVGQVGQ7ZsK5akEab88MiGhWEvbC4a6HAJothOGvP7rBw4+LTm2kv0x y1e8bNcrGWMkklZyBCMKRgPkxOhFV4YXN0t5YMPn8WIZ9z+KUQsjYmK/kUnZKeJZNw oyuI3ypKkx8sJze7gPlnVR/a+roJIFn2QjyRGBCw= Date: Tue, 24 Mar 2020 18:12:21 +0200 From: Laurent Pinchart To: "Lad, Prabhakar" Subject: Re: [PATCH v3 1/4] media: dt-bindings: media: i2c: Switch to assigned-clock-rates Message-ID: <20200324161221.GA27805@pendragon.ideasonboard.com> References: <1584133954-6953-1-git-send-email-prabhakar.mahadev-lad.rj@bp.renesas.com> <1584133954-6953-2-git-send-email-prabhakar.mahadev-lad.rj@bp.renesas.com> <20200319124452.3yfcvq754vi4q2rv@gilmour.lan> <20200319130348.GC4872@pendragon.ideasonboard.com> <20200324154045.whiy6uvlg2mrjv5a@gilmour.lan> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200324_091252_041068_E85B915F X-CRM114-Status: GOOD ( 28.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Fabio Estevam , Sakari Ailus , Shawn Guo , Sascha Hauer , Magnus Damm , Lad Prabhakar , LKML , Linux-Renesas , Rob Herring , Geert Uytterhoeven , Maxime Ripard , Pengutronix Kernel Team , NXP Linux Team , Mauro Carvalho Chehab , Ezequiel Garcia , LAK , linux-media Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Prabhakar, On Tue, Mar 24, 2020 at 04:04:43PM +0000, Lad, Prabhakar wrote: > On Tue, Mar 24, 2020 at 3:40 PM Maxime Ripard wrote: > > On Thu, Mar 19, 2020 at 01:17:51PM +0000, Lad, Prabhakar wrote: > > > On Thu, Mar 19, 2020 at 1:04 PM Laurent Pinchart wrote: > > > > On Thu, Mar 19, 2020 at 01:44:52PM +0100, Maxime Ripard wrote: > > > > > On Fri, Mar 13, 2020 at 09:12:31PM +0000, Lad Prabhakar wrote: > > > > > > Use assigned-clock-rates to specify the clock rate. Also mark > > > > > > clock-frequency property as deprecated. > > > > > > > > > > > > Signed-off-by: Lad Prabhakar > > > > > > --- > > > > > > Documentation/devicetree/bindings/media/i2c/ov5645.txt | 5 +++-- > > > > > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > > > > > > > > > diff --git a/Documentation/devicetree/bindings/media/i2c/ov5645.txt b/Documentation/devicetree/bindings/media/i2c/ov5645.txt > > > > > > index 72ad992..e62fe82 100644 > > > > > > --- a/Documentation/devicetree/bindings/media/i2c/ov5645.txt > > > > > > +++ b/Documentation/devicetree/bindings/media/i2c/ov5645.txt > > > > > > @@ -8,7 +8,7 @@ Required Properties: > > > > > > - compatible: Value should be "ovti,ov5645". > > > > > > - clocks: Reference to the xclk clock. > > > > > > - clock-names: Should be "xclk". > > > > > > -- clock-frequency: Frequency of the xclk clock. > > > > > > +- clock-frequency (deprecated): Frequency of the xclk clock. > > > > > > - enable-gpios: Chip enable GPIO. Polarity is GPIO_ACTIVE_HIGH. This corresponds > > > > > > to the hardware pin PWDNB which is physically active low. > > > > > > - reset-gpios: Chip reset GPIO. Polarity is GPIO_ACTIVE_LOW. This corresponds to > > > > > > @@ -37,7 +37,8 @@ Example: > > > > > > > > > > > > clocks = <&clks 200>; > > > > > > clock-names = "xclk"; > > > > > > - clock-frequency = <24000000>; > > > > > > + assigned-clocks = <&clks 200>; > > > > > > + assigned-clock-rates = <24000000>; > > > > > > > > > > > > vdddo-supply = <&camera_dovdd_1v8>; > > > > > > vdda-supply = <&camera_avdd_2v8>; > > > > > > > > > > clock-frequency is quite different from assigned-clock-rates though, > > > > > semantically speaking. clock-frequency is only about what the clock > > > > > frequency is, while assigned-clock-rates will change the rate as well, > > > > > and you have no idea how long it will last. > > > > > > > > The driver currently reads the clock-frequency property and then calls > > > > clk_set_rate(). I agree tht assigned-clock-rates isn't a panacea, but I > > > > think it's less of a hack than what we currently have. > > > > > > > > As discussed on IRC, maybe the best option in this specific case is to > > > > drop clock-frequency and assigned-clok-rates, and call clk_set_rate() > > > > with a hardcoded frequency of 24MHz in the driver, as that's the only > > > > frequency the driver supports. > > > > > > > Does this mean any driver which has a fixed clock requirement shouldn't be a > > > DT property and should be just handled by the drivers internally ? > > > > It's hard to give a generic policy, but here, the hardware is pretty > > flexible since it can deal with anything between 6MHz to 50-something > > MHz, it's the driver that chooses to enforce a 24MHz and be pedantic > > about it, so it's up to the driver to enforce that policy, not to the > > DT since it's essentially a software limitation, not a hardware one. > > Thank you for the clarification, Ill drop patches 1-4 from this series. That's the whole series... :-) I think you should keep patch 1/4 but just remove the clock-frequency from the bindings, then remove it from the DT files, and patch the driver to set the clock rate to 24MHz unconditionally in patch 4/4. -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel