From: kbuild test robot <lkp@intel.com>
To: Russell King <rmk+kernel@armlinux.org.uk>
Cc: kbuild-all@lists.01.org, linux-arm-kernel@lists.infradead.org
Subject: [PATCH] net: fix irqf_oneshot.cocci warnings
Date: Wed, 25 Mar 2020 18:55:59 +0800 [thread overview]
Message-ID: <20200325105559.GA4092@6d5c83dcba44> (raw)
In-Reply-To: <202003251849.wLfJ5mOC%lkp@intel.com>
From: kbuild test robot <lkp@intel.com>
drivers/net/phy/qsfp.c:1750:8-33: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT
Since commit 1c6c69525b40 ("genirq: Reject bogus threaded irq requests")
threaded IRQs without a primary handler need to be requested with
IRQF_ONESHOT, otherwise the request will fail.
So pass the IRQF_ONESHOT flag in this case.
Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci
Fixes: e409cdeab751 ("net: add qsfp support [*experimental*]")
Signed-off-by: kbuild test robot <lkp@intel.com>
---
tree: git://git.armlinux.org.uk/~rmk/linux-arm.git cex7
head: 6edfcc6e759c8dd593c9079525e610919d680ae5
commit: e409cdeab75156478ac793528742274f6ad4be96 [142/143] net: add qsfp support [*experimental*]
Please take the patch only if it's a positive warning. Thanks!
qsfp.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--- a/drivers/net/phy/qsfp.c
+++ b/drivers/net/phy/qsfp.c
@@ -1748,7 +1748,8 @@ static int qsfp_probe(struct platform_de
}
err = devm_request_threaded_irq(qsfp->dev, qsfp->gpio_irq[i],
- NULL, irq_handler, irq_flags,
+ NULL, irq_handler,
+ irq_flags | IRQF_ONESHOT,
dev_name(qsfp->dev), qsfp);
if (err) {
qsfp->gpio_irq[i] = 0;
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2020-03-25 10:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-25 10:55 [arm:cex7 142/143] drivers/net/phy/qsfp.c:872:8-9: WARNING: return of 0/1 in function 'sfp_los_event_active' with return type bool kbuild test robot
2020-03-25 10:55 ` [PATCH] net: fix boolreturn.cocci warnings kbuild test robot
2020-03-25 10:55 ` kbuild test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200325105559.GA4092@6d5c83dcba44 \
--to=lkp@intel.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=rmk+kernel@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox