* [PATCH] arm64: head: Convert install_el2_stub to SYM_INNER_LABEL
@ 2020-03-23 12:33 Mark Brown
2020-03-24 16:57 ` Catalin Marinas
2020-03-24 18:19 ` Ard Biesheuvel
0 siblings, 2 replies; 5+ messages in thread
From: Mark Brown @ 2020-03-23 12:33 UTC (permalink / raw)
To: Catalin Marinas, Will Deacon; +Cc: Mark Brown, linux-arm-kernel
New assembly annotations have recently been introduced which aim to
make the way we describe symbols in assembly more consistent. Recently the
arm64 assembler was converted to use these but install_el2_stub was missed.
Signed-off-by: Mark Brown <broonie@kernel.org>
---
arch/arm64/kernel/head.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/kernel/head.S b/arch/arm64/kernel/head.S
index a06727354fad..22c6a04f6b82 100644
--- a/arch/arm64/kernel/head.S
+++ b/arch/arm64/kernel/head.S
@@ -600,7 +600,7 @@ set_hcr:
isb
ret
-install_el2_stub:
+SYM_INNER_LABEL(install_el2_stub, SYM_L_GLOBAL)
/*
* When VHE is not in use, early init of EL2 and EL1 needs to be
* done here.
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: head: Convert install_el2_stub to SYM_INNER_LABEL
2020-03-23 12:33 [PATCH] arm64: head: Convert install_el2_stub to SYM_INNER_LABEL Mark Brown
@ 2020-03-24 16:57 ` Catalin Marinas
2020-03-24 18:19 ` Ard Biesheuvel
1 sibling, 0 replies; 5+ messages in thread
From: Catalin Marinas @ 2020-03-24 16:57 UTC (permalink / raw)
To: Mark Brown; +Cc: Will Deacon, linux-arm-kernel
On Mon, Mar 23, 2020 at 12:33:36PM +0000, Mark Brown wrote:
> New assembly annotations have recently been introduced which aim to
> make the way we describe symbols in assembly more consistent. Recently the
> arm64 assembler was converted to use these but install_el2_stub was missed.
>
> Signed-off-by: Mark Brown <broonie@kernel.org>
Applied. Thanks.
--
Catalin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: head: Convert install_el2_stub to SYM_INNER_LABEL
2020-03-23 12:33 [PATCH] arm64: head: Convert install_el2_stub to SYM_INNER_LABEL Mark Brown
2020-03-24 16:57 ` Catalin Marinas
@ 2020-03-24 18:19 ` Ard Biesheuvel
2020-03-24 18:33 ` Mark Brown
1 sibling, 1 reply; 5+ messages in thread
From: Ard Biesheuvel @ 2020-03-24 18:19 UTC (permalink / raw)
To: Mark Brown; +Cc: Catalin Marinas, Will Deacon, linux-arm-kernel
On Mon, 23 Mar 2020 at 13:33, Mark Brown <broonie@kernel.org> wrote:
>
> New assembly annotations have recently been introduced which aim to
> make the way we describe symbols in assembly more consistent. Recently the
> arm64 assembler was converted to use these but install_el2_stub was missed.
>
> Signed-off-by: Mark Brown <broonie@kernel.org>
> ---
> arch/arm64/kernel/head.S | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/kernel/head.S b/arch/arm64/kernel/head.S
> index a06727354fad..22c6a04f6b82 100644
> --- a/arch/arm64/kernel/head.S
> +++ b/arch/arm64/kernel/head.S
> @@ -600,7 +600,7 @@ set_hcr:
> isb
> ret
>
> -install_el2_stub:
> +SYM_INNER_LABEL(install_el2_stub, SYM_L_GLOBAL)
Shouldn't this be SYM_L_LOCAL?
> /*
> * When VHE is not in use, early init of EL2 and EL1 needs to be
> * done here.
> --
> 2.20.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: head: Convert install_el2_stub to SYM_INNER_LABEL
2020-03-24 18:19 ` Ard Biesheuvel
@ 2020-03-24 18:33 ` Mark Brown
2020-03-25 11:09 ` Catalin Marinas
0 siblings, 1 reply; 5+ messages in thread
From: Mark Brown @ 2020-03-24 18:33 UTC (permalink / raw)
To: Ard Biesheuvel; +Cc: Catalin Marinas, Will Deacon, linux-arm-kernel
[-- Attachment #1.1: Type: text/plain, Size: 273 bytes --]
On Tue, Mar 24, 2020 at 07:19:56PM +0100, Ard Biesheuvel wrote:
> On Mon, 23 Mar 2020 at 13:33, Mark Brown <broonie@kernel.org> wrote:
> > -install_el2_stub:
> > +SYM_INNER_LABEL(install_el2_stub, SYM_L_GLOBAL)
> Shouldn't this be SYM_L_LOCAL?
I think it could be, yes.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: head: Convert install_el2_stub to SYM_INNER_LABEL
2020-03-24 18:33 ` Mark Brown
@ 2020-03-25 11:09 ` Catalin Marinas
0 siblings, 0 replies; 5+ messages in thread
From: Catalin Marinas @ 2020-03-25 11:09 UTC (permalink / raw)
To: Mark Brown; +Cc: Will Deacon, linux-arm-kernel, Ard Biesheuvel
On Tue, Mar 24, 2020 at 06:33:54PM +0000, Mark Brown wrote:
> On Tue, Mar 24, 2020 at 07:19:56PM +0100, Ard Biesheuvel wrote:
> > On Mon, 23 Mar 2020 at 13:33, Mark Brown <broonie@kernel.org> wrote:
>
> > > -install_el2_stub:
> > > +SYM_INNER_LABEL(install_el2_stub, SYM_L_GLOBAL)
>
> > Shouldn't this be SYM_L_LOCAL?
>
> I think it could be, yes.
I fixed up the patch locally.
--
Catalin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-03-25 11:09 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-23 12:33 [PATCH] arm64: head: Convert install_el2_stub to SYM_INNER_LABEL Mark Brown
2020-03-24 16:57 ` Catalin Marinas
2020-03-24 18:19 ` Ard Biesheuvel
2020-03-24 18:33 ` Mark Brown
2020-03-25 11:09 ` Catalin Marinas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).