From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC262C43331 for ; Fri, 27 Mar 2020 12:44:43 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9899D206F2 for ; Fri, 27 Mar 2020 12:44:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="n8GtSUj6"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GIA92C3G" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9899D206F2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=3KmuH8D1Cg0AcUeyi2uU4u9v5mpbHdFIM3uu8MRc8/U=; b=n8GtSUj6fqjsYvZuW3RNh2zsyj LQs0QtzLfoa+Ajh8aTm1qJIunaPKrdRcR2f0QzLYDZircKkRb+GzaMURhOuG80yqwW925cDhCjSYQ 2W51fNsD9JURvZTjSHTG/S0lxBi5ca8oGaEwjZxcEYJ/xpMTZsmQVsnYtgDNf/t6OaU5wP4nRw7ad L2y1WvGj+i/19Y1L1kSLELEXBJD8gcgojRjQKQZWfRsRq+8Ear59WuTG1NMz1H4dsMcLHmJsOknET QegCEPjYbFCNXyHZiRaNuSFMmRrLucaI/xuyJJ5jBTW1zi0j25dq6nLGXCeF9gomlv3wM6S7v7KXy 3TnKOr3Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jHoLq-0007Yh-MU; Fri, 27 Mar 2020 12:44:42 +0000 Received: from mail-pf1-x442.google.com ([2607:f8b0:4864:20::442]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jHoLg-0007U5-8n for linux-arm-kernel@lists.infradead.org; Fri, 27 Mar 2020 12:44:35 +0000 Received: by mail-pf1-x442.google.com with SMTP id 22so4444891pfa.9 for ; Fri, 27 Mar 2020 05:44:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=OrmCqFezly2Rfxgtc8/QFu/0W5F3zvpkrW43juhNMPA=; b=GIA92C3GyqkFnDX8sA9Rknn8fwTnET1ETunHwCgySE9vDZlgyPZM1GTEDiX4Ed9drc YH4plfCR6mDkoPfE0nOfFfGPjfLT+W2/okVZ5EhQ+LPZD+3k3spQS23pLTXBiYuvPVjx o87eiA3EwHWieUIzUz0Xe1Up70BMgfdBO+fHkji+RKnEtXlrpr8/rOeK064Y/AmaDTya RcA9Vm3DNDRleceqduZA8aNk0u38lr/33qFn8a+ay0hVHF40ghOEWJqr4PkbpBpSavrW ZKpgwHZ525bKABBbRN8QEulmTk7qyiRpqA+dN3IRCfA+WZ+NBdJSPtEJ3DFpcz4HCpN+ r5Gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=OrmCqFezly2Rfxgtc8/QFu/0W5F3zvpkrW43juhNMPA=; b=SU8JjqHQay0uU5v3oFQXEyQ6nttYvs0VipbiQ3N21RN5s5RqVKJa7GwFgK0r+kGV6j FmSiRxzfirnhCx6RFgNSuOWZ+Oy0E5YQO06YzBA5dh7nCDU2w0vBDRd5wiJURH+gkzHm XsQmz9LyjM4pLx1aDZtwwQX3TKfIAZ9dLxfgiIMfOfaSTfAQOyCwmGlsjIJDrQ/rO0Sm n4VeqIPhLC6NSHDBDkDzMp0rbUYbM8MRodUbaajEhA8w+sGNJsGzMKvoZn7wAJL07zbg scnmZVvJf70aqVOm5T7OrRQ1TCZpqdfuoqp1Ieza4ECUPCU3LkoQbQNjwkAo/sphPokh 3tNA== X-Gm-Message-State: ANhLgQ1vDdbTBeFbOeZQ5JdzwXxnJYHxasuYHWJUKcCWa7dth46nWTBi 0+Jg8iPZ0pj9uO+C5XzOXMY= X-Google-Smtp-Source: ADFU+vv89RkFVcocDRn4TLjad8m0Ax5S8FfzmE4pizTzzOO9MsncIbmfrgyhAIrDyE9xef9gEK/Cfg== X-Received: by 2002:a62:6503:: with SMTP id z3mr14798534pfb.232.1585313070409; Fri, 27 Mar 2020 05:44:30 -0700 (PDT) Received: from localhost.localdomain ([49.207.51.33]) by smtp.gmail.com with ESMTPSA id u129sm4070380pfb.101.2020.03.27.05.44.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Mar 2020 05:44:29 -0700 (PDT) From: afzal mohammed List-Id: To: Arnd Bergmann , SoC Team Subject: [PATCH v4 3/5] ARM: cns3xxx: replace setup_irq() by request_irq() Date: Fri, 27 Mar 2020 18:14:22 +0530 Message-Id: <20200327124422.4181-1-afzal.mohd.ma@gmail.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: References: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200327_054432_383411_7F303CD8 X-CRM114-Status: GOOD ( 12.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Jason Cooper , Hartley Sweeten , Tony Lindgren , afzal mohammed , Gregory CLEMENT , Russell King , "linux-kernel@vger.kernel.org" , Lubomir Rintel , arm-soc , =?UTF-8?q?Krzysztof=20Ha=C5=82asa?= , Viresh Kumar , Olof Johansson , Thomas Gleixner , Sebastian Hesselbarth , Alexander Sverdlin , Shiraz Hashim , Linux ARM , Viresh Kumar MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org request_irq() is preferred over setup_irq(). Invocations of setup_irq() occur after memory allocators are ready. Per tglx[1], setup_irq() existed in olden days when allocators were not ready by the time early interrupts were initialized. Hence replace setup_irq() by request_irq(). [1] https://lkml.kernel.org/r/alpine.DEB.2.20.1710191609480.1971@nanos Signed-off-by: afzal mohammed Acked-by: Krzysztof Halasa --- v4: * Add received tags v3: * Split out from series, also split out from ARM patch to subarch level as Thomas suggested to take it thr' respective maintainers * Modify string displayed in case of error as suggested by Thomas * Re-arrange code as required to improve readability * Remove irrelevant parts from commit message & improve v2: * Replace pr_err("request_irq() on %s failed" by pr_err("%s: request_irq() failed" * Commit message massage arch/arm/mach-cns3xxx/core.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/arch/arm/mach-cns3xxx/core.c b/arch/arm/mach-cns3xxx/core.c index 1d61a7701c11..e4f4b20b83a2 100644 --- a/arch/arm/mach-cns3xxx/core.c +++ b/arch/arm/mach-cns3xxx/core.c @@ -189,12 +189,6 @@ static irqreturn_t cns3xxx_timer_interrupt(int irq, void *dev_id) return IRQ_HANDLED; } -static struct irqaction cns3xxx_timer_irq = { - .name = "timer", - .flags = IRQF_TIMER | IRQF_IRQPOLL, - .handler = cns3xxx_timer_interrupt, -}; - /* * Set up the clock source and clock events devices */ @@ -245,7 +239,9 @@ static void __init __cns3xxx_timer_init(unsigned int timer_irq) writel(val, cns3xxx_tmr1 + TIMER1_2_CONTROL_OFFSET); /* Make irqs happen for the system timer */ - setup_irq(timer_irq, &cns3xxx_timer_irq); + if (request_irq(timer_irq, cns3xxx_timer_interrupt, + IRQF_TIMER | IRQF_IRQPOLL, "timer", NULL)) + pr_err("Failed to request irq %d (timer)\n", timer_irq); cns3xxx_clockevents_init(timer_irq); } -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel