From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 094CAC43331 for ; Sun, 29 Mar 2020 09:21:22 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D3E13206CC for ; Sun, 29 Mar 2020 09:21:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="HGN2T3Km"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FnIrRA8B" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D3E13206CC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LzfBLT/tqYPMg2U/VRFwbmJb+/9oGsX/D4D02DYXtkg=; b=HGN2T3KmU/RoOL Zk3IvCRR0C8Utjq+Wgi/VZFvX+B+JrfHKBfl/SR/ZIhgDhKGuQk2coRa/BPJM4ikwO00b0JdGSPeh 0s432IL+k18vXKCdJSFjmsiLT9KPIbIq+f0P8l45Zv8JskryL8tkxzWLhrKyobvMAk/9lgG1O74Ab sJXM1ZJazXf+f7TSyo6l0TE+b23Udz03x0waWpg1cXKPUueCFXL3apixcEj8zAdFAWgKK7OUSvGLK tRq9OzrytVKqTwYZLKctSyq0tJ+6vAa7XPNGCV6HjT6Xl6YDVYtr6WoSzh5lEdml+nUJRP6NKja+v BBEv7JKEyVMBe0LEg22A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jIU88-0002Fq-5D; Sun, 29 Mar 2020 09:21:20 +0000 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jIU84-0002Ev-ML for linux-arm-kernel@lists.infradead.org; Sun, 29 Mar 2020 09:21:18 +0000 Received: by mail-wm1-x343.google.com with SMTP id g62so17778708wme.1 for ; Sun, 29 Mar 2020 02:21:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=x53chI72Z4A5z3wT784xdPISVx+MMGzvobvSOBptE6g=; b=FnIrRA8BoFYj2RWpJ93LBznjfYgaBi8gS487V11zI073uv6ZjT6fmm2u9BwonL5VUY 1lGpxYjz+TIxyNeexabK4v9UKbHKki3PAxlmGGSGPym4tXG6GL1sgKoUPvHghFBMX7JM cPrLvxLtKm6Jm6ODZv4owOGZOISVkpaMaKg4C3KjcC4DVJl04WBoljGuF7CgjTWMSWjm mzddCajS+9G3olNXVUMPSs0AN5m2ylu5FhOkM1Bj843r3zZQ6Z/oswLxMm66QsiRVlKF dpKQiYNzboWBbY2lPXnN7hqU3YhEoeBT8TojL85NRefvN2VUSAQgdxyNfcC5t8nG+zIy m1WA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=x53chI72Z4A5z3wT784xdPISVx+MMGzvobvSOBptE6g=; b=PncveKmIpXem5d1jEskiM2YeKiMNfXf3SD/LaFbYAovnWW4mflOE7sDGToF6fFF5cu lurHEOxIB4hwX9uyVsNGLnBHkQcDgk1YEUumGvVDPyQkchF1ApWqxpX8eZgbIq6qt5sH 0CLE7995QMkrh/wcPfPU4csPk83JCZ+SdSe/ODIXwBlR4UpdDEhFHGvWMEYbYw+nBFcU eDQPLY9goJUS9L/D+w7Ma7fJnTMOYCKVjPwUQWGoDLHogqiFmCv58dG7L49fahBvXDAi WCCrG9a/eVdGtalwY1j+tXzwVo2I4zuRMkmH6O+3U/rzINcF61xtKbtLq1wiR/fSWDFD wwLg== X-Gm-Message-State: ANhLgQ1/6cEAgfaEBI66pektgbw4K7Rt6kmX3K+lh2y7jrXURIm/awS3 y5BUZ2zHE6snfUwMJCbryM8= X-Google-Smtp-Source: ADFU+vtjvZzrvTpz+nRmLxc2pCZraCHS4XlmLXYuXqI1Tsm2DenOisGvZgfCT5iEiIBT6h0G/5Oq0g== X-Received: by 2002:a1c:b7c2:: with SMTP id h185mr7752149wmf.67.1585473673928; Sun, 29 Mar 2020 02:21:13 -0700 (PDT) Received: from eichest-laptop (77-57-203-148.dclient.hispeed.ch. [77.57.203.148]) by smtp.gmail.com with ESMTPSA id x1sm9392665wmj.24.2020.03.29.02.21.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 29 Mar 2020 02:21:13 -0700 (PDT) Date: Sun, 29 Mar 2020 11:20:33 +0200 From: Stefan Eichenberger To: Rabeeh Khoury Subject: Re: [PATCH] arm64: dts: clearfog-gt-8k: fix ge phy reset pin Message-ID: <20200329092032.GA4620@eichest-laptop> References: <20200328212115.12477-1-eichest@gmail.com> <877dz3el4k.fsf@tarshish> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200329_022116_755837_272F5BE3 X-CRM114-Status: GOOD ( 17.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Baruch Siach , Jason Cooper , devicetree@vger.kernel.org, Gregory Clement , linux-kernel@vger.kernel.org, Russell King , Rob Herring , linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Rabeeh and Baruch On Sun, Mar 29, 2020 at 11:42:35AM +0300, Rabeeh Khoury wrote: > On Sun, Mar 29, 2020 at 9:22 AM Baruch Siach wrote: > > > > Hi Stefan, > > > > On Sun, Mar 29 2020, eichest@gmail.com wrote: > > > From: Stefan Eichenberger > > > > > > According to the ClearFog-GT-8K-rev-1_1-Simplified-Schematic the reset > > > pin for the gigabit phy is MPP62 and not MPP43. > > > > Have you tested that on real hardware? > > > > The 1Gb PHY reset on my Clearfog GT-8K is connected to MPP43. Russell's > > commit 46f94c7818e7 ("arm64: dts: clearfog-gt-8k: set gigabit PHY reset > > deassert delay") indicates that this is the case on his board as well. > > > > In case there was a hardware change between board revisions, we need > > another dtb for that revision. > > It's a bug in the simplified schematics since that schematics is based > on rev 1.0 and not rev 1.1 as claimed. > > In rev 1.0; the 1Gbps phy reset was connected to MPP62; but that MPP > is not functional as a GPIO when selecting MPP[56:61] as SD card. > Due to that we manually rewired ALL rev 1.0 PCBs 1Gbps phy to be > connected to MPP43 via R8038 pads. > > Rev 1.1 fixes this by that by disconnecting 1Gbps phy reset from MPP62 > and wiring it to MPP43. > So basically rev 1.0 and rev 1.1 are compatible software wise. We will > fix the schematics. Ahh now I see, I didn't enable the phy driver when I did the test with the default devicetree and then when I changed the devicetree I also enabled the driver, that's my fault. Sorry for the confusion... I can confirm that it works with MPP43. Thanks for the clarification! Regards, Stefan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel