From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 838E3C2D0EF for ; Tue, 31 Mar 2020 08:23:39 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3BD042073B for ; Tue, 31 Mar 2020 08:23:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="UJQO3P+g" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3BD042073B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9KP0c6ykTwTl6VFcCqWmlPG6Z8JdqlErx9O9vsD66OU=; b=UJQO3P+gOqrKRa wgdxDpE0Zo6WllSse9b3+Y8gfI0MzOL8zRaYMchODNiq83ldDQyH5csanS11gtzXd719NLsYagdu0 /Oekt8IHczbOnaGMlFDH/V6UsEy/+4czDFiSNCF1/rRM3M87oBYE3zup1mxkgFoKQTJx85TaZMsV9 Ji8F60oHw7v51H6fxIUiHEuDFKFVA9UW/PFVODUZYrc0BPWj2+23bwREk8tBv1LwblbQlfJclk50u 8gAbSACvBg8FZkVzmFNeG+5MSNcYymAwxDNFRzGlxcpANez8SosSvn+LDXDRgua4nhS7dsm2UNKkq wSVKw+mo0O/dkGbTk7Jg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jJCBO-0003th-Qd; Tue, 31 Mar 2020 08:23:38 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jJCBL-0003sZ-W9 for linux-arm-kernel@lists.infradead.org; Tue, 31 Mar 2020 08:23:37 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6A4D530E; Tue, 31 Mar 2020 01:23:33 -0700 (PDT) Received: from e121166-lin.cambridge.arm.com (e121166-lin.cambridge.arm.com [10.1.196.255]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2C58F3F71E; Tue, 31 Mar 2020 01:23:31 -0700 (PDT) Date: Tue, 31 Mar 2020 09:23:25 +0100 From: Lorenzo Pieralisi To: bjorn@helgaas.com Subject: Re: [PATCH V5 5/5] PCI: tegra: Add support for PCIe endpoint mode in Tegra194 Message-ID: <20200331082325.GA32028@e121166-lin.cambridge.arm.com> References: <20200330214721.GA128269@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200331_012336_122184_EB3ACF67 X-CRM114-Status: GOOD ( 25.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kishon@ti.com, mmaddireddy@nvidia.com, devicetree@vger.kernel.org, kthota@nvidia.com, gustavo.pimentel@synopsys.com, LKML , robh+dt@kernel.org, jonathanh@nvidia.com, thierry.reding@gmail.com, Bjorn Helgaas , linux-pci@vger.kernel.org, linux-tegra@vger.kernel.org, Andrew Murray , Vidya Sagar , ARM , sagar.tv@gmail.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Mar 30, 2020 at 10:00:57PM -0500, Bjorn Helgaas wrote: > On Mon, Mar 30, 2020 at 9:55 PM Vidya Sagar wrote: > > > > > > > > On 3/31/2020 3:17 AM, Bjorn Helgaas wrote: > > > External email: Use caution opening links or attachments > > > > > > > > > On Tue, Mar 03, 2020 at 11:40:52PM +0530, Vidya Sagar wrote: > > >> Add support for the endpoint mode of Synopsys DesignWare core based > > >> dual mode PCIe controllers present in Tegra194 SoC. > > >> > > >> Signed-off-by: Vidya Sagar > > >> Acked-by: Thierry Reding > > >> --- > > >> V5: > > >> * Added Acked-by: Thierry Reding > > >> * Removed unwanted header file inclusion > > >> > > >> V4: > > >> * Addressed Lorenzo's review comments > > >> * Started using threaded irqs instead of kthreads > > >> > > >> V3: > > >> * Addressed Thierry's review comments > > >> > > >> V2: > > >> * Addressed Bjorn's review comments > > >> * Made changes as part of addressing review comments for other patches > > >> > > >> drivers/pci/controller/dwc/Kconfig | 30 +- > > >> drivers/pci/controller/dwc/pcie-tegra194.c | 679 ++++++++++++++++++++- > > >> 2 files changed, 691 insertions(+), 18 deletions(-) > > >> > > >> diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig > > >> index 0830dfcfa43a..169cde58dd92 100644 > > >> --- a/drivers/pci/controller/dwc/Kconfig > > >> +++ b/drivers/pci/controller/dwc/Kconfig > > >> @@ -248,14 +248,38 @@ config PCI_MESON > > >> implement the driver. > > >> > > >> config PCIE_TEGRA194 > > >> - tristate "NVIDIA Tegra194 (and later) PCIe controller" > > >> + tristate > > >> + > > >> +config PCIE_TEGRA194_HOST > > >> + tristate "NVIDIA Tegra194 (and later) PCIe controller - Host Mode" > > >> depends on ARCH_TEGRA_194_SOC || COMPILE_TEST > > >> depends on PCI_MSI_IRQ_DOMAIN > > >> select PCIE_DW_HOST > > >> select PHY_TEGRA194_P2U > > >> + select PCIE_TEGRA194 > > >> + default y > > > > > > Sorry I missed this before, but why is this "default y"? From > > > Documentation/kbuild/kconfig-language.rst: > > > > > > The default value deliberately defaults to 'n' in order to avoid > > > bloating the build. With few exceptions, new config options should > > > not change this. The intent is for "make oldconfig" to add as little > > > as possible to the config from release to release. > > > > > > I do see that several other things in other drivers/pci/ Kconfig files > > > are also "default y", and we should probably change some of them. But > > > I don't want to add even more unless there's a good reason. > > > > > > I'm not looking for more reactions like these: > > > > > > https://lore.kernel.org/r/CAHk-=wiZ24JuVehJ5sEC0UG1Gk2nvB363wO02RRsR1oEht6R9Q@mail.gmail.com > > > https://lore.kernel.org/r/CA+55aFzPpuHU1Nqd595SEQS=F+kXMzPs0Rba9FUgTodGxmXsgg@mail.gmail.com > > > > > > Can you please update this patch to either remove the "default y" or > > > add the rationale for keeping it? > > I'm fine with removing 'default y' line. > > Should I send a patch only with this change? > > I think it's probably just as easy for Lorenzo to delete that line on > his branch. If not, I'll cherry-pick the patches on that branch and > do it locally. Done, pushed out. It is a guideline that it is worth keeping in mind while I review the code, sorry for missing it. Lorenzo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel