From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73E4EC43331 for ; Wed, 1 Apr 2020 07:51:35 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4588320714 for ; Wed, 1 Apr 2020 07:51:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="EX88fkb0"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="HvODtZfZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4588320714 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PducN7IXDUCugATB+s/t1Rx7m0UQ+uL6ej5ASd9pGNU=; b=EX88fkb0OfIFOC W0AGXKKaWjnQY2MRThg9ikyoe76Zh+3P8Y/tImlXLfTAF1vVwlHhlSe6s7T0dxF6bccc9i7FFurPy SKxoNkFKBfvjEs1yo0Jfu5eLBE76MBFGoTY9s4cAE2iCKViZhJIy3XqP+TC6B0WQMIHvJTh85NQfS xtazw1yljBXtUQnjpgXh03jn5+1WKaGRQY4LH8BYU4p7c/aTQ4v2f1P7bsMHPvzWfKXN6TUmq6bjH 0rotdyCNGmtfnUr4o1McU7LpkKJZ7R68EFq5pyvlUpT3+RrQI4WyTGuCIJmaclb1W/po2Jo+LW7py Zs1BSZgJbqBL9Pg366dA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jJY9u-0007hK-SG; Wed, 01 Apr 2020 07:51:34 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jJY9q-0007gM-Vi for linux-arm-kernel@lists.infradead.org; Wed, 01 Apr 2020 07:51:32 +0000 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 88FF420714; Wed, 1 Apr 2020 07:51:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585727490; bh=3D97YiEndMg9UsBuiKsn+vb2S6w3nUXHpMzf6W+i8wI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HvODtZfZL3odvDezrvN07J5/K3/sdhHvG3YXrDo4nE2F8La/AUBNfwA7B6eWITyNk QUxlCVnc7w57AcajUdrw9LIzlD1l/b4kiic5+sQt43IVkwAPwssYO6ZYfFxMIlGH7H xdUizvWplklAiuqX6K9t09hvhdJkApGLL6qqKayU= Date: Wed, 1 Apr 2020 08:51:25 +0100 From: Will Deacon To: Ard Biesheuvel Subject: Re: [PATCH] arm64: bring Image header in line with latest Arm brand guidelines Message-ID: <20200401075125.GA15950@willie-the-truck> References: <20200401065636.1751-1-ardb@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200401065636.1751-1-ardb@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200401_005131_045258_2611C771 X-CRM114-Status: GOOD ( 18.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: catalin.marinas@arm.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Ard, On Wed, Apr 01, 2020 at 08:56:36AM +0200, Ard Biesheuvel wrote: > The Arm brand guidelines are pretty clear when it comes to the way > the brand name 'arm' should be displayed: it should be all lowercase, > and there should be sufficient whitespace around it on all sides. > > Let's use the reserved space we have available in the Image header to > bring it in compliance with this. > > Signed-off-by: Ard Biesheuvel > --- > arch/arm64/include/asm/image.h | 2 +- > arch/arm64/kernel/head.S | 7 +++---- > 2 files changed, 4 insertions(+), 5 deletions(-) > > diff --git a/arch/arm64/include/asm/image.h b/arch/arm64/include/asm/image.h > index c2b13213c720..a52e6eca8118 100644 > --- a/arch/arm64/include/asm/image.h > +++ b/arch/arm64/include/asm/image.h > @@ -3,7 +3,7 @@ > #ifndef __ASM_IMAGE_H > #define __ASM_IMAGE_H > > -#define ARM64_IMAGE_MAGIC "ARM\x64" > +#define ARM64_IMAGE_MAGIC "arm\x64" > > #define ARM64_IMAGE_FLAG_BE_SHIFT 0 > #define ARM64_IMAGE_FLAG_PAGE_SIZE_SHIFT (ARM64_IMAGE_FLAG_BE_SHIFT + 1) > diff --git a/arch/arm64/kernel/head.S b/arch/arm64/kernel/head.S > index 57a91032b4c2..e70d3f96dfe4 100644 > --- a/arch/arm64/kernel/head.S > +++ b/arch/arm64/kernel/head.S > @@ -78,10 +78,9 @@ _head: > le64sym _kernel_offset_le // Image load offset from start of RAM, little-endian > le64sym _kernel_size_le // Effective size of kernel image, little-endian > le64sym _kernel_flags_le // Informative flags, little-endian > - .quad 0 // reserved > - .quad 0 // reserved > - .quad 0 // reserved > - .ascii ARM64_IMAGE_MAGIC // Magic number > + .ascii " " > + .ascii " " ARM64_IMAGE_MAGIC " " // Magic number > + .ascii " " > #ifdef CONFIG_EFI > .long pe_header - _head // Offset to the PE header. Thanks for the patch. As you know, we take this kind of thing very seriously in the kernel community, which is why I'm disappointed not to see you taking this work to its natural conclusion by introducing a new printk format specifier for " arm ", complete with the relevant escapes to ensure the correct shade of blue on terminal emulators that support it. But since the bootloader communities will probably be over the moon with this patch on its own, I see no reason to hold it up: Acked-until-noon-by: Will Deacon Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel