linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Marek Vasut <marex@denx.de>,
	Alexandre Torgue <alexandre.torgue@st.com>,
	Patrice Chotard <patrice.chotard@st.com>,
	Patrick Delaunay <patrick.delaunay@st.com>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
	linux-stm32@st-md-mailman.stormreply.com
Subject: [PATCH V4 07/22] ARM: dts: stm32: Repair PMIC configuration on AV96
Date: Wed,  1 Apr 2020 15:22:22 +0200	[thread overview]
Message-ID: <20200401132237.60880-8-marex@denx.de> (raw)
In-Reply-To: <20200401132237.60880-1-marex@denx.de>

The core and vdd PMIC buck regulators were misconfigured, which caused
instability of the board and malfunction of high-speed interfaces, like
the RGMII. Configure the PMIC correctly to repair these problems.

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Alexandre Torgue <alexandre.torgue@st.com>
Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: Patrice Chotard <patrice.chotard@st.com>
Cc: Patrick Delaunay <patrick.delaunay@st.com>
Cc: linux-stm32@st-md-mailman.stormreply.com
To: linux-arm-kernel@lists.infradead.org
---
V2: Model the Enpirion EP53A8LQI on the DHCOR SoM as a fixed regulator
V3: Move this before the SDMMC2 patch, as there is now a dependency
V4: Rebase on stm32-next
---
 arch/arm/boot/dts/stm32mp157a-avenger96.dts | 20 ++++++++++++++++----
 1 file changed, 16 insertions(+), 4 deletions(-)

diff --git a/arch/arm/boot/dts/stm32mp157a-avenger96.dts b/arch/arm/boot/dts/stm32mp157a-avenger96.dts
index a6f21ac5a94a..260410461dc8 100644
--- a/arch/arm/boot/dts/stm32mp157a-avenger96.dts
+++ b/arch/arm/boot/dts/stm32mp157a-avenger96.dts
@@ -91,6 +91,17 @@ sd_switch: regulator-sd_switch {
 		states = <1800000 0x1>,
 			 <2900000 0x0>;
 	};
+
+	/* Enpirion EP3A8LQI U2 on the DHCOR */
+	vdd_io: regulator-buck-io {
+		compatible = "regulator-fixed";
+		regulator-name = "buck-io";
+		regulator-min-microvolt = <1800000>;
+		regulator-max-microvolt = <1800000>;
+		regulator-always-on;
+		regulator-boot-on;
+		vin-supply = <&vdd>;
+	};
 };
 
 &ethernet0 {
@@ -177,7 +188,7 @@ regulators {
 
 			vddcore: buck1 {
 				regulator-name = "vddcore";
-				regulator-min-microvolt = <1200000>;
+				regulator-min-microvolt = <800000>;
 				regulator-max-microvolt = <1350000>;
 				regulator-always-on;
 				regulator-initial-mode = <0>;
@@ -195,8 +206,8 @@ vdd_ddr: buck2 {
 
 			vdd: buck3 {
 				regulator-name = "vdd";
-				regulator-min-microvolt = <3300000>;
-				regulator-max-microvolt = <3300000>;
+				regulator-min-microvolt = <2900000>;
+				regulator-max-microvolt = <2900000>;
 				regulator-always-on;
 				regulator-initial-mode = <0>;
 				regulator-over-current-protection;
@@ -274,6 +285,7 @@ vbus_otg: pwr_sw1 {
 				regulator-name = "vbus_otg";
 				interrupts = <IT_OCP_OTG 0>;
 				interrupt-parent = <&pmic>;
+				regulator-active-discharge = <1>;
 			};
 
 			vbus_sw: pwr_sw2 {
@@ -304,7 +316,7 @@ &iwdg2 {
 };
 
 &pwr_regulators {
-	vdd-supply = <&vdd>;
+	vdd-supply = <&vdd_io>;
 	vdd_3v3_usbfs-supply = <&vdd_usb>;
 };
 
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2020-04-01 13:24 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-01 13:22 [PATCH V4 00/22] ARM: dts: stm32: Repair AV96 board Marek Vasut
2020-04-01 13:22 ` [PATCH V4 01/22] ARM: dts: stm32: Add alternate pinmux for ethernet RGMII Marek Vasut
2020-04-01 13:22 ` [PATCH V4 02/22] ARM: dts: stm32: Repair ethernet operation on AV96 Marek Vasut
2020-04-01 13:22 ` [PATCH V4 03/22] ARM: dts: stm32: Add missing ethernet PHY reset " Marek Vasut
2020-04-06  6:10   ` Manivannan Sadhasivam
2020-04-01 13:22 ` [PATCH V4 04/22] ARM: dts: stm32: Add missing ethernet PHY skews " Marek Vasut
2020-04-01 13:22 ` [PATCH V4 05/22] ARM: dts: stm32: Add alternate pinmux for SDMMC1 direction pins Marek Vasut
2020-04-01 13:22 ` [PATCH V4 06/22] ARM: dts: stm32: Repair SDMMC1 operation on AV96 Marek Vasut
2020-04-06  6:24   ` Manivannan Sadhasivam
2020-04-01 13:22 ` Marek Vasut [this message]
2020-04-01 13:22 ` [PATCH V4 08/22] ARM: dts: stm32: Repair PMIC interrupt " Marek Vasut
2020-04-01 13:22 ` [PATCH V4 09/22] ARM: dts: stm32: Add alternate pinmux for SDMMC2 pins 4-7 Marek Vasut
2020-04-01 13:22 ` [PATCH V4 10/22] ARM: dts: stm32: Add eMMC attached to SDMMC2 on AV96 Marek Vasut
2020-04-06  6:47   ` Manivannan Sadhasivam
2020-04-01 13:22 ` [PATCH V4 11/22] ARM: dts: stm32: Add QSPI NOR " Marek Vasut
2020-04-06  6:49   ` Manivannan Sadhasivam
2020-04-01 13:22 ` [PATCH V4 12/22] ARM: dts: stm32: Add configuration EEPROM " Marek Vasut
2020-04-01 13:22 ` [PATCH V4 13/22] ARM: dts: stm32: Add alternate pinmux for SDMMC3 pins Marek Vasut
2020-04-01 13:22 ` [PATCH V4 14/22] ARM: dts: stm32: Enable WiFi on AV96 Marek Vasut
2020-04-01 13:22 ` [PATCH V4 15/22] ARM: dts: stm32: Add alternate pinmux for USART2 pins Marek Vasut
2020-04-01 13:22 ` [PATCH V4 16/22] ARM: dts: stm32: Enable Bluetooth on AV96 Marek Vasut
2020-04-01 13:22 ` [PATCH V4 17/22] ARM: dts: stm32: Add alternate pinmux for LTDC pins Marek Vasut
2020-04-01 13:22 ` [PATCH V4 18/22] ARM: dts: stm32: Add bindings for HDMI video on AV96 Marek Vasut
2020-04-06  7:05   ` Manivannan Sadhasivam
2020-04-01 13:22 ` [PATCH V4 19/22] ARM: dts: stm32: Add alternate pinmux for SAI2 pins Marek Vasut
2020-04-01 13:22 ` [PATCH V4 20/22] ARM: dts: stm32: Add bindings for audio on AV96 Marek Vasut
2020-04-01 13:22 ` [PATCH V4 21/22] ARM: dts: stm32: Add bindings for USB " Marek Vasut
2020-04-06  7:22   ` Manivannan Sadhasivam
2020-04-06 11:08     ` Marek Vasut
2020-04-07 18:37       ` Marek Vasut
2020-04-10  9:08         ` Manivannan Sadhasivam
2020-04-10  9:16           ` Marek Vasut
2020-04-10 11:34             ` Manivannan Sadhasivam
2020-04-10 18:02               ` Marek Vasut
2020-04-11  4:12                 ` Manivannan Sadhasivam
2020-04-12  1:54                   ` Marek Vasut
2020-04-01 13:22 ` [PATCH V4 22/22] ARM: dts: stm32: Rename LEDs to match silkscreen " Marek Vasut
2020-04-06  7:24   ` Manivannan Sadhasivam
2020-04-05 14:43 ` [PATCH V4 00/22] ARM: dts: stm32: Repair AV96 board Manivannan Sadhasivam
2020-04-05 14:55   ` Marek Vasut
2020-04-05 18:37     ` Manivannan Sadhasivam
2020-04-05 20:01       ` Marek Vasut
2020-04-06  6:04         ` Manivannan Sadhasivam
2020-04-06  7:27 ` Manivannan Sadhasivam
2020-04-07 15:32   ` Marek Vasut
2020-04-10  9:00     ` Manivannan Sadhasivam
2020-04-10  9:55       ` Marek Vasut
2020-04-10 11:28         ` Manivannan Sadhasivam
2020-04-10 18:03           ` Marek Vasut
2020-04-21 10:30 ` Marek Vasut
2020-04-21 16:04   ` Alexandre Torgue
2020-04-21 17:07     ` Marek Vasut
2020-04-22  7:27       ` Alexandre Torgue

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200401132237.60880-8-marex@denx.de \
    --to=marex@denx.de \
    --cc=alexandre.torgue@st.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=patrice.chotard@st.com \
    --cc=patrick.delaunay@st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).