From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64D44C43331 for ; Thu, 2 Apr 2020 11:59:07 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2B49920757 for ; Thu, 2 Apr 2020 11:59:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="QbgTCeqX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2B49920757 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PsPGpIDEfEIErJnnDQXlh3OPmeO3RCZ6+ie2Et3y0dM=; b=QbgTCeqXjiskkj db2gKZn2AhLJjHsDx3HLhjlZ0+YcdXCiuQu4OMc9pCDveBSt32oNFvMcHKAOtr4PtLlenq3LJxhLf 7mumWGPJL+b5lyqXh1sM7wbH0fYh3hFT6NtHqA4bVWu1v8F9ixQIAbuSeiHwp599P1hfoxkwrCDAY gYHqlIZUusiIFU+kYf/PQSOcwixXE5AWqoLBsa+8SBHGJTtzK3Su0acRT6nfFqMKm8LRvBpDDEpnE E1bXlZOwfcYHKeUkA9IxJC2ySwh/AdCY3swx6T5l9Olv9jZZ+7sYvplNvvKOiuUL8fkXl2RvPUAMf jAJS+SaarMlNlSixc24Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jJyV0-0003zV-BS; Thu, 02 Apr 2020 11:59:06 +0000 Received: from relay6-d.mail.gandi.net ([217.70.183.198]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jJyUs-0003sW-Pd for linux-arm-kernel@lists.infradead.org; Thu, 02 Apr 2020 11:59:00 +0000 X-Originating-IP: 86.202.105.35 Received: from localhost (lfbn-lyo-1-9-35.w86-202.abo.wanadoo.fr [86.202.105.35]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id AE629C0007; Thu, 2 Apr 2020 11:58:51 +0000 (UTC) Date: Thu, 2 Apr 2020 13:58:51 +0200 From: Alexandre Belloni To: Tang Bin Subject: Re: [PATCH] ALSA:atmel:Use platform_get_irq_optional() Message-ID: <20200402115851.GG3683@piout.net> References: <20200402112135.18604-1-tangbin@cmss.chinamobile.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200402112135.18604-1-tangbin@cmss.chinamobile.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200402_045858_962202_A7C5159C X-CRM114-Status: GOOD ( 14.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, tiwai@suse.com, ludovic.desroches@microchip.com, perex@perex.cz, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 02/04/2020 19:21:35+0800, Tang Bin wrote: > In order to simply code,because platform_get_irq() already has > dev_err() message. > But what I see is a dev_dbg message so your patch actually changes the behaviour when debugging is not enabled. > Signed-off-by: Tang Bin > --- > sound/atmel/ac97c.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/atmel/ac97c.c b/sound/atmel/ac97c.c > index a1dce9725..25cfd5710 100644 > --- a/sound/atmel/ac97c.c > +++ b/sound/atmel/ac97c.c > @@ -715,7 +715,7 @@ static int atmel_ac97c_probe(struct platform_device *pdev) > return -ENXIO; > } > > - irq = platform_get_irq(pdev, 0); > + irq = platform_get_irq_optional(pdev, 0); > if (irq < 0) { > dev_dbg(&pdev->dev, "could not get irq: %d\n", irq); > return irq; > -- > 2.20.1.windows.1 > > > -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel