* [PATCH] ALSA:atmel:Use platform_get_irq_optional()
@ 2020-04-02 11:21 Tang Bin
2020-04-02 11:58 ` Alexandre Belloni
0 siblings, 1 reply; 2+ messages in thread
From: Tang Bin @ 2020-04-02 11:21 UTC (permalink / raw)
To: perex, tiwai, nicolas.ferre
Cc: alexandre.belloni, Tang Bin, alsa-devel, linux-kernel,
ludovic.desroches, linux-arm-kernel
In order to simply code,because platform_get_irq() already has
dev_err() message.
Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
---
sound/atmel/ac97c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/atmel/ac97c.c b/sound/atmel/ac97c.c
index a1dce9725..25cfd5710 100644
--- a/sound/atmel/ac97c.c
+++ b/sound/atmel/ac97c.c
@@ -715,7 +715,7 @@ static int atmel_ac97c_probe(struct platform_device *pdev)
return -ENXIO;
}
- irq = platform_get_irq(pdev, 0);
+ irq = platform_get_irq_optional(pdev, 0);
if (irq < 0) {
dev_dbg(&pdev->dev, "could not get irq: %d\n", irq);
return irq;
--
2.20.1.windows.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] ALSA:atmel:Use platform_get_irq_optional()
2020-04-02 11:21 [PATCH] ALSA:atmel:Use platform_get_irq_optional() Tang Bin
@ 2020-04-02 11:58 ` Alexandre Belloni
0 siblings, 0 replies; 2+ messages in thread
From: Alexandre Belloni @ 2020-04-02 11:58 UTC (permalink / raw)
To: Tang Bin
Cc: alsa-devel, linux-kernel, tiwai, ludovic.desroches, perex,
linux-arm-kernel
On 02/04/2020 19:21:35+0800, Tang Bin wrote:
> In order to simply code,because platform_get_irq() already has
> dev_err() message.
>
But what I see is a dev_dbg message so your patch actually changes the
behaviour when debugging is not enabled.
> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
> ---
> sound/atmel/ac97c.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/atmel/ac97c.c b/sound/atmel/ac97c.c
> index a1dce9725..25cfd5710 100644
> --- a/sound/atmel/ac97c.c
> +++ b/sound/atmel/ac97c.c
> @@ -715,7 +715,7 @@ static int atmel_ac97c_probe(struct platform_device *pdev)
> return -ENXIO;
> }
>
> - irq = platform_get_irq(pdev, 0);
> + irq = platform_get_irq_optional(pdev, 0);
> if (irq < 0) {
> dev_dbg(&pdev->dev, "could not get irq: %d\n", irq);
> return irq;
> --
> 2.20.1.windows.1
>
>
>
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-02 11:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-02 11:21 [PATCH] ALSA:atmel:Use platform_get_irq_optional() Tang Bin
2020-04-02 11:58 ` Alexandre Belloni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).