From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0125DC43331 for ; Thu, 2 Apr 2020 13:57:46 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C937C2073B for ; Thu, 2 Apr 2020 13:57:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="GT5UoTnL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C937C2073B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Dg+cjrW3Ol3f/SgV4VYf5wzXIVInAOKoK3W3sAdNCRQ=; b=GT5UoTnLXWqH0mt0wgHUItMXe x3URqNB70pKshV6GDPphq0g4UF/8JeHWOH/zvZolQAoQLc8fjAmmHAcuRQR1qtSbZAWhktY0yZSxn AbHYGWZ6PuiXOc1O+Hze/QL7mk4ROHhTPjPneA48eqZDgFTzqGdw68FwmPVCVr0BdOXI0wkIXwUrl AHUfAtNMftOjOqpB++wMoxn7ivssA1Fb7fN1XM+VkmFyV6CzaFJ2OvCU/eDScwWwZ7yItbIokoFVc wcCbnWSZE5dcCXN6tfAxwHbX1E7NsxQlpEjYlCtDHrMbsafjiViT+CBkZzcST9JGyChSxGXjdRW8j Yyc3Fb7Wg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jK0Lp-00025D-Fc; Thu, 02 Apr 2020 13:57:45 +0000 Received: from relay3-d.mail.gandi.net ([217.70.183.195]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jK0Ll-00022p-Mx for linux-arm-kernel@lists.infradead.org; Thu, 02 Apr 2020 13:57:43 +0000 X-Originating-IP: 93.29.109.196 Received: from aptenodytes (196.109.29.93.rev.sfr.net [93.29.109.196]) (Authenticated sender: paul.kocialkowski@bootlin.com) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id E40DB6000D; Thu, 2 Apr 2020 13:57:31 +0000 (UTC) Date: Thu, 2 Apr 2020 15:57:31 +0200 From: Paul Kocialkowski To: Alexandre Belloni Subject: Re: [PATCH 2/2] rtc: sun6i: switch to rtc_time64_to_tm/rtc_tm_to_time64 Message-ID: <20200402135731.GA625345@aptenodytes> References: <20200330201510.861217-1-alexandre.belloni@bootlin.com> <20200330201510.861217-3-alexandre.belloni@bootlin.com> MIME-Version: 1.0 In-Reply-To: <20200330201510.861217-3-alexandre.belloni@bootlin.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200402_065741_881813_03600416 X-CRM114-Status: GOOD ( 17.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-rtc@vger.kernel.org, Alessandro Zummo , linux-kernel@vger.kernel.org, Maxime Ripard , Chen-Yu Tsai , linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============5515629973468492489==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============5515629973468492489== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="fUYQa+Pmc3FrFX/N" Content-Disposition: inline --fUYQa+Pmc3FrFX/N Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Mon 30 Mar 20, 22:15, Alexandre Belloni wrote: > Call the 64bit versions of rtc_tm time conversion. >=20 > Signed-off-by: Alexandre Belloni This was successfully: Tested-by: Paul Kocialkowski Cheers, Paul > --- > drivers/rtc/rtc-sun6i.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/drivers/rtc/rtc-sun6i.c b/drivers/rtc/rtc-sun6i.c > index 446ce38c1592..e2b8b150bcb4 100644 > --- a/drivers/rtc/rtc-sun6i.c > +++ b/drivers/rtc/rtc-sun6i.c > @@ -498,7 +498,7 @@ static int sun6i_rtc_getalarm(struct device *dev, str= uct rtc_wkalrm *wkalrm) > =20 > wkalrm->enabled =3D !!(alrm_en & SUN6I_ALRM_EN_CNT_EN); > wkalrm->pending =3D !!(alrm_st & SUN6I_ALRM_EN_CNT_EN); > - rtc_time_to_tm(chip->alarm, &wkalrm->time); > + rtc_time64_to_tm(chip->alarm, &wkalrm->time); > =20 > return 0; > } > @@ -519,8 +519,8 @@ static int sun6i_rtc_setalarm(struct device *dev, str= uct rtc_wkalrm *wkalrm) > return -EINVAL; > } > =20 > - rtc_tm_to_time(alrm_tm, &time_set); > - rtc_tm_to_time(&tm_now, &time_now); > + time_set =3D rtc_tm_to_time64(alrm_tm); > + time_now =3D rtc_tm_to_time64(&tm_now); > if (time_set <=3D time_now) { > dev_err(dev, "Date to set in the past\n"); > return -EINVAL; > --=20 > 2.25.1 >=20 >=20 > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --=20 Paul Kocialkowski, Bootlin Embedded Linux and kernel engineering https://bootlin.com --fUYQa+Pmc3FrFX/N Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEJZpWjZeIetVBefti3cLmz3+fv9EFAl6F70sACgkQ3cLmz3+f v9FADgf/Z8x/NG6rzW4iNYoe/p42n/FIn4dXr7WV1OAzVj+G2wBINasXpLZtHsOI yOoKl5GNGQXF85p1b6sQaZ+FVwA0YqZsGfzum93w0s0YeoQpBSMjhYjUuneHarB0 hsQR0LWjcgTe2/FmvBKgsjZ+iAo+6M+iB0R0M/qVLpFl3vzNltJFPcLTABAbdFOX WLy84aeTTrwWnvjPkxIZpMQGXkAnEfYe+NlejO/KqlvUZVvOsbVVokqmCk2/4iib oOV+35FTm8Bg0jwD7VORvp8CcMbNRTDT3dIivW+SzG4qnx2Q1kGyRKxYDpMSdgyc M+gTvQcwLkm5zpwNxP85+Y0aIqBYxA== =/1Dq -----END PGP SIGNATURE----- --fUYQa+Pmc3FrFX/N-- --===============5515629973468492489== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============5515629973468492489==--