From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88747C43331 for ; Fri, 3 Apr 2020 10:47:53 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5ABAC2078C for ; Fri, 3 Apr 2020 10:47:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Eurnodyy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5ABAC2078C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6uWnnJga4ONGnMNtmr96m0dhVi6gfcWKT2DNRM/yHXU=; b=Eurnodyy3RsSts ngFViUcH4bEulrwkH4zjZp089enphQjC2SDZp30mBSU0NiSJAHWV2X2z1hwERpKIXGL5Wz+15w8TD pv1F2+fFH8+MAZWBxdlP5XJUEETXvM5XYCETTltx5NPsdwY8m5kHtV1fKc1oFHYdQCr1hP4JbPd8e 0SDLsoVFFPUrOZwrvzlWfCLxWKRqcTZq+jnV1kjswuUyRFUgxf8fPLWyAvePcgOb3UBcfDHNf3o62 W1F6DIFeDmYGopUmgadAnafDO3jN7XMuVXn/QIMMLTC2ZtF7mNy22fxAIny75eywwiLtVFI/IosDg pJ2+PLv+oc7sNhLryuag==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jKJrc-0005jw-Fv; Fri, 03 Apr 2020 10:47:52 +0000 Received: from mail-ed1-f65.google.com ([209.85.208.65]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jKJrY-0005jJ-WA for linux-arm-kernel@lists.infradead.org; Fri, 03 Apr 2020 10:47:51 +0000 Received: by mail-ed1-f65.google.com with SMTP id e5so8746001edq.5 for ; Fri, 03 Apr 2020 03:47:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=/qsV5G+EWb+7XocHOBXyq0rD3eTdN0wEIFWjn6eqrw0=; b=a4+4gL0YdnSdEnuDKfJla2h4ObUAOP8J5uqPEuidRgtHIcQrymC6uRBzSwKPCNDqPX JdDuoPiF2wZbAJgxbBG4DOI7Ybdzm/zt3fI4/TyQeApVgL+ulWjkMHMUk4pXZT4q2aGr by9838NdCP6jibjRIbB8uZtjYku1t7VjtAwBe7yWTEDkb/A34J3erdNo4PxrEX10qCJ6 kjaRarsohnezvXoymeLiVsL8fHhSIzTt6BlsvZR78/ngaXolhOoMKleueOD7VAdyaBDP 2863jWWPcpkyjq9jYLIkUJlfja5bYxW5tZXETpDkUewho7uRZj7vvAODnmsicI22UPOw otHg== X-Gm-Message-State: AGi0PuZEHyZXpvnqs4P7dT1l2gni/GVJzrEfiIMMIdG23ru2dgpv40Bm zM6l7y5ZwXqdPxaXPcVQn7FgH3Ni X-Google-Smtp-Source: APiQypL5vPUUwU2gK8AJePkOzrdpT7tRJ1mK4h7pF9JSf1Aki52IK/rhR4C/SGne9w6Yo0UNm1UZHA== X-Received: by 2002:a17:906:cc2:: with SMTP id l2mr7897646ejh.115.1585910866860; Fri, 03 Apr 2020 03:47:46 -0700 (PDT) Received: from kozik-lap ([194.230.155.125]) by smtp.googlemail.com with ESMTPSA id gs12sm1565340ejb.86.2020.04.03.03.47.45 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 03 Apr 2020 03:47:46 -0700 (PDT) Date: Fri, 3 Apr 2020 12:47:44 +0200 From: Krzysztof Kozlowski To: Hyunki Koo Subject: Re: [PATCH v3] tty: samsung_tty: 32-bit access for TX/RX hold registers Message-ID: <20200403104744.GA29385@kozik-lap> References: <20200401082721.19431-1-hyunki00.koo@samsung.com> <20200403102041.22015-1-hyunki00.koo@samsung.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200403102041.22015-1-hyunki00.koo@samsung.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200403_034749_037033_4F02A443 X-CRM114-Status: GOOD ( 16.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, Kukjin Kim , linux-serial@vger.kernel.org, Jiri Slaby , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Apr 03, 2020 at 07:20:41PM +0900, Hyunki Koo wrote: > Support 32-bit access for the TX/RX hold registers UTXH and URXH. > > This is required for some newer SoCs. > > Signed-off-by: Hyunki Koo > --- > v3: change rd_regl to rd_reg in line 954 for backward compatibility. I cannot find this change against v2. > --- > > drivers/tty/serial/samsung_tty.c | 76 +++++++++++++++++++++++++++++++++------- > 1 file changed, 64 insertions(+), 12 deletions(-) > > diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c > index 73f951d65b93..a674a80163ed 100644 > --- a/drivers/tty/serial/samsung_tty.c > +++ b/drivers/tty/serial/samsung_tty.c > @@ -154,12 +154,47 @@ struct s3c24xx_uart_port { > #define portaddrl(port, reg) \ > ((unsigned long *)(unsigned long)((port)->membase + (reg))) > > -#define rd_regb(port, reg) (readb_relaxed(portaddr(port, reg))) > +static unsigned int rd_reg(struct uart_port *port, int reg) You should return here u32 to be consistent with readl_relaxed. > +{ > + switch (port->iotype) { > + case UPIO_MEM: > + return readb_relaxed(portaddr(port, reg)); > + case UPIO_MEM32: > + return readl_relaxed(portaddr(port, reg)); > + default: > + return 0; > + } > + return 0; > +} > + > #define rd_regl(port, reg) (readl_relaxed(portaddr(port, reg))) > > -#define wr_regb(port, reg, val) writeb_relaxed(val, portaddr(port, reg)) > +static void wr_reg(struct uart_port *port, int reg, int val) val should be u32. > +{ > + switch (port->iotype) { > + case UPIO_MEM: > + writeb_relaxed(val, portaddr(port, reg)); > + break; > + case UPIO_MEM32: > + writel_relaxed(val, portaddr(port, reg)); > + break; > + } > +} > + > #define wr_regl(port, reg, val) writel_relaxed(val, portaddr(port, reg)) > > +static void write_buf(struct uart_port *port, int reg, int val) buf is misleading, you do not write here any buffer. Maybe "wr_reg_barrier()" or "wr_reg_order()"? Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel