From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E68EBC2BA19 for ; Mon, 6 Apr 2020 13:21:29 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5E62E22525 for ; Mon, 6 Apr 2020 13:21:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="LgEiWHKQ"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="MjUtKAsG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5E62E22525 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zaH/vxMuLjtc41AH5pRl/Bbc5CVSjvDRg0AWMmohXdI=; b=LgEiWHKQVJTS25 888hsl7Q72DcM+Ms7WWWrcpDxv7gA4wvEIcTn0dR0WzUXLAqrGKBXzkHCXRYBTzZS8igYTguYSCir xPD+yQHLpfbaF29kBxVkQXQ9KsSIooEuTITKx2Gvm6xfwTLBdj04Ib/eXDk54jbMPIZ4Uz2Ll8vle hHDMGp/uPSyE1fuBNs9vviMosJHv8hlIlVBQvY9EuZDYas4KluqasXm9Dt2C40XYl+opgvO0NPQGc EIaFP7k90NhO2gV1NbmvkFiT65vZel7m/6hCa+VaKMz16IgXj0BOxr1+1Egg+5agyvoK1bpwjMv0i 0F4xAXLtOiNR9tjWz+TQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jLRgs-0000wx-SA; Mon, 06 Apr 2020 13:21:26 +0000 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120] helo=us-smtp-1.mimecast.com) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jLRgp-0000vL-3Z for linux-arm-kernel@lists.infradead.org; Mon, 06 Apr 2020 13:21:24 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1586179279; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8/l+u68mjtbwHXpzMEw7Dyh8XU04DyaBrG7zHozWjJA=; b=MjUtKAsGw9b9HO1vsKJKXRrg4u8t40KJLkV4gI6YL9jj4SMlY8G/bcJaP/RHR+ZlzTjBZl NfCm/70uUVOFj7gHRCOoNq94TFNKbGBNvGM0MMNLkpF2QKPPbIdjAJyej6Q7Idv1MqMU6n ivSNgEcbas+1KTd4RbfhhH5Kifgr1oo= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-309-Uv9esNOyOtWagpuTAMiTow-1; Mon, 06 Apr 2020 09:21:15 -0400 X-MC-Unique: Uv9esNOyOtWagpuTAMiTow-1 Received: by mail-wm1-f70.google.com with SMTP id 2so4894614wmf.1 for ; Mon, 06 Apr 2020 06:21:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Dt00ToAjgq6odVjJUr2HynAfwKXr6ghEKV21ZUG8JdU=; b=F8lstkPTt4QduOF6IwpGdbIitc3aruraaD7ARwke2bUmA9Tzdb6Z7DN8FXybXJi7iN hyb8D36+eqGAmgdNYwShwkVpHoUjcDyprJw7Z+CzHNF7+TXpaiV03eErhuj+1Fs2Ef2s BWrcMVfr2M2I7WSlI2nUNLFEHG/IqLrcdE9RYTWcJXEZuBmjAPDVHTeoKThgPndUCOsp T7sjPfWChOKvn9ELZGXQcpvShW96jryh4JdMPEjtzjzUET0nVIQlbXQCsYaKGD2MOjSv FVhaDAIsCjkLl2V1jAdEdblicQE+/L5Fv59wA9sbUdN1l8Ni9/9y4cD5jP8QuKhn1aLL sCFg== X-Gm-Message-State: AGi0Puaghu/AndlFo4Qm8ZceoE6tfIXf5IWyB7bZMAreYrydovpIrG2L HWHFiW/b2Ezk3QaD8JYNRq5B9pxd+5GRWZGo+XBy28QTk4WKfqMZB4e5iAZoD6IPnJu5EbjmjWe opTCEElw1p2MJAuw6XctYFo2Dq1PzKQF/AOM= X-Received: by 2002:a5d:42c1:: with SMTP id t1mr11428308wrr.215.1586179274431; Mon, 06 Apr 2020 06:21:14 -0700 (PDT) X-Google-Smtp-Source: APiQypLTm0wN4Ob+KU8r6bjP+vUj5Sc5r+ElDJG7FGW/nVL32K8rRyDddIp810vWUMYetH05ffupWw== X-Received: by 2002:a5d:42c1:: with SMTP id t1mr11428298wrr.215.1586179274273; Mon, 06 Apr 2020 06:21:14 -0700 (PDT) Received: from redhat.com (bzq-79-176-51-222.red.bezeqint.net. [79.176.51.222]) by smtp.gmail.com with ESMTPSA id z11sm11162174wrv.58.2020.04.06.06.21.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Apr 2020 06:21:13 -0700 (PDT) Date: Mon, 6 Apr 2020 09:21:10 -0400 From: "Michael S. Tsirkin" To: Arnd Bergmann Subject: Re: [PATCH v2 2/2] vhost: disable for OABI Message-ID: <20200406092056-mutt-send-email-mst@kernel.org> References: <20200406121233.109889-1-mst@redhat.com> <20200406121233.109889-3-mst@redhat.com> <20200406085707-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200406_062123_225331_AA3A1B36 X-CRM114-Status: GOOD ( 15.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Earnshaw , "kbuild-all@lists.01.org" , kbuild test robot , kvm list , "christophe.lyon@st.com" , Greg Kroah-Hartman , Jason Wang , "richard.henderson@linaro.org" , "linux-kernel@vger.kernel.org" , Sudeep Dutt , Ashutosh Dixit , "daniel.santos@pobox.com" , Russell King , "David S. Miller" , Networking , virtualization@lists.linux-foundation.org, Ard Biesheuvel , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Apr 06, 2020 at 03:15:20PM +0200, Arnd Bergmann wrote: > On Mon, Apr 6, 2020 at 3:02 PM Michael S. Tsirkin wrote: > > > > On Mon, Apr 06, 2020 at 02:50:32PM +0200, Arnd Bergmann wrote: > > > On Mon, Apr 6, 2020 at 2:12 PM Michael S. Tsirkin wrote: > > > > > > > > > > > +config VHOST_DPN > > > > + bool "VHOST dependencies" > > > > + depends on !ARM || AEABI > > > > + default y > > > > + help > > > > + Anything selecting VHOST or VHOST_RING must depend on VHOST_DPN. > > > > + This excludes the deprecated ARM ABI since that forces a 4 byte > > > > + alignment on all structs - incompatible with virtio spec requirements. > > > > + > > > > > > This should not be a user-visible option, so just make this 'def_bool > > > !ARM || AEABI' > > > > > > > I like keeping some kind of hint around for when one tries to understand > > why is a specific symbol visible. > > I meant you should remove the "VHOST dependencies" prompt, not the > help text, which is certainly useful here. You can also use the three lines > > bool > depends on !ARM || AEABI > default y > > in front of the help text, but those are equivalent to the one-line version > I suggested. > > Arnd Oh right. Good point. Thanks! -- MST _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel