From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6DBFC2BA19 for ; Mon, 6 Apr 2020 09:54:33 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AE422206F5 for ; Mon, 6 Apr 2020 09:54:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="M1sFpW9f" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AE422206F5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=G3y1LKG+nWUFuV2vNzRL8erv9Faur8nHM+uPcwKLxTY=; b=M1sFpW9fM7ZxcY B62L7196um+795ytv5J7oGvFk+dn7LViK1RisOACFJeuBexQVjnEmupNSITbMVZ8Qpe0m0n7xoYtJ 4kSdS7JRgMLqFbECVgVM9TJH68iCggUiXb5WirGW8X5Nmk2ndOmap8TGfAy4TF9vySxnQJgza19zK lkaDtrl4AbC7VJJTVnfKhPE6Ef4lh/M1O9MtHpgmmswcbj2lA4EF064e5AIVlhkoa4vK06cG34H/d O/fcxgICW+vV44eGaCUgjWRyxXa7MqCBFv3q5yLdTjCOVATcvKfSQS0VP89eXwUWFcCLvr+M3Gyrw Whf6fN2pbmoFcGbiDd8Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jLOSf-0002Ts-5a; Mon, 06 Apr 2020 09:54:33 +0000 Received: from mail-ed1-f66.google.com ([209.85.208.66]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jLOSb-0002TA-Hs for linux-arm-kernel@lists.infradead.org; Mon, 06 Apr 2020 09:54:31 +0000 Received: by mail-ed1-f66.google.com with SMTP id c7so10719040edl.2 for ; Mon, 06 Apr 2020 02:54:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Jq4dLklSvXAh4mHXbS3uqTp1YFNR8Y8OhfEZxV4SEp8=; b=B7wBcrp4+euem+D5JJuPWiUngGAPGwvTZpWkOThPOH3CncW5rn7JGB72Kp7h6kDyXw zDBFrin+VufKtMDLQ7mZaeO9rbpcOjcwZrzb33CEukZU0nboI4chV8ytwi8qKu/FiBDh DXTcZ/AIqs+u78WNfqGj6AXaHHF2S6rNCaZcn7iGkeD6UeZuIzss6ugfYDHc9GawqppT YxsZwIYJvMXw8U2XiVBmBjqySzgi8TairLUaBy40nd2BRXzzfC/eoR28n16TPgwy63CS K6SGfUyDkfIWqgQ/WMkx7KnDAtblb4I45fJa1Nvxd6iH1NXiet2Fq849ZVwu7CUMgJw2 oijA== X-Gm-Message-State: AGi0PuZDUHUHmwtcEp01G41wpDv1SRbouVM7s9qg1MmAGIsY7pSrLR82 6qkHnUJmvadfb3mXhRm8Din6DXMZ X-Google-Smtp-Source: APiQypIGsI1vy9jtZIncxZtn6HgnNsW1Vh3ZNhBDX+cUzlu30NjC5DdfbDeJxopv+1PyeG+Z0DSLcQ== X-Received: by 2002:a17:906:30c5:: with SMTP id b5mr21234309ejb.102.1586166868311; Mon, 06 Apr 2020 02:54:28 -0700 (PDT) Received: from kozik-lap ([194.230.155.125]) by smtp.googlemail.com with ESMTPSA id y10sm2858156ejm.3.2020.04.06.02.54.27 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 06 Apr 2020 02:54:27 -0700 (PDT) Date: Mon, 6 Apr 2020 11:54:25 +0200 From: 'Krzysztof Kozlowski' To: Hyunki Koo Subject: Re: [PATCH v4] tty: samsung_tty: 32-bit access for TX/RX hold registers Message-ID: <20200406095425.GB13565@kozik-lap> References: <20200401082721.19431-1-hyunki00.koo@samsung.com> <20200403111511.10598-1-hyunki00.koo@samsung.com> <20200403115941.GB29484@kozik-lap> <000001d60b92$2adaee50$8090caf0$@samsung.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <000001d60b92$2adaee50$8090caf0$@samsung.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200406_025429_588674_E7759A2D X-CRM114-Status: GOOD ( 12.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, 'Kukjin Kim' , linux-serial@vger.kernel.org, 'Jiri Slaby' , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Apr 06, 2020 at 06:35:46AM +0900, Hyunki Koo wrote: > On Fri, Apr 03, 2020 at 9:00: 10PM +0900, Krzysztof Kozlowski wrote: > > On Fri, Apr 03, 2020 at 08:15:10PM +0900, Hyunki Koo wrote: > > > Support 32-bit access for the TX/RX hold registers UTXH and URXH. > > > > > > This is required for some newer SoCs. > > > > > > Signed-off-by: Hyunki Koo > > > --- > > > v2: > > > line 954 : change rd_regl to rd_reg in for backward compatibility. > > > > I did not see any change around line 954 in v1... so what was it? > 954 line is changed like below. > V1 : rd_regb --> rd_regl : we thought, this register need to change to > V2: rd_regl --> rd_reg : we discuss internally, and > I decided not to change to existing devices for backward compatibility. > So we changed to rd_reg. Thanks. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel