From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5557C2BA80 for ; Mon, 6 Apr 2020 10:34:41 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7AF68206F5 for ; Mon, 6 Apr 2020 10:34:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="YMUWoijY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7AF68206F5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZLmitBBPmwrA3YUlTHe8MwBtDow4dY9LsYrmSCCvb/M=; b=YMUWoijYfGDWR0 4AkwNaU2d0sHQWu1y0z4QkxPOwWgTxWdLYrYyMrkEznm5RCYhF0WJ2YGt0ejRgCDPuwqGAcnrYxkn d81wUgM9k80K02K8hUxm8xSaNBB8UnFOTqx4f7/iLjR7nmrY5DmWUb0Gugcxkp4Jg97JX6ONpmART ChN4+oCauKLC6zufJj7db8vOAftbljVk5589dbxvyb7RdL0hBD3QWg4jPfxgfzhl2nnSF190z7srt O2/pJ1NKEF5yFGjQWWUwzc4IK435pN1K55VutcHrmjfzmyF6313IDzgJvP24rmnKOV8SIitrrkX7h 5k8mFqRsqlok7uSB+4lQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jLP5V-0002sF-2g; Mon, 06 Apr 2020 10:34:41 +0000 Received: from mail-ed1-f67.google.com ([209.85.208.67]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jLP5R-0002rv-QB for linux-arm-kernel@lists.infradead.org; Mon, 06 Apr 2020 10:34:39 +0000 Received: by mail-ed1-f67.google.com with SMTP id m12so4886191edl.12 for ; Mon, 06 Apr 2020 03:34:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=GCDV/KSvNbnbn8FBlMojoXonpi0B/XmPXkgkMx9qThM=; b=SgnWhnn0sDqLu+7xTP5T/CUJK8mKySH2G8P0UCOhLD2Jd0fscTJUn0eTdthPYYJn4q PGgzrl/G/tE8DsubZeFkKtPD08Ags/3pptr+PaGi0gxNfD5QOT/b2ZEfKOShsCs80x6d sW2wwddOU+Zp9jWKa+8XXFhIk9rCW8eQow6XzQrNv2GpzaCHKU1Fk6ZyIVM6fGkTIcov Aobc30u1AI4oNEQx5QwoodKOrQu2GdxMsJDTYSIx6hEbzid1dCpQlpIALHAsC+53QO2K 2sCIHbcOt8rMoxG+qdlEjiaeGtEj0Zfcbev4UAwezx+wEYgdwGcNDTvg8U9L7SFv1zTG lZvw== X-Gm-Message-State: AGi0PubOu+LP/K1gmJBjA65xjwfClthJgfCQzlepb2qI0fBA1p+obQ5e JdTbybyWrSI6XeKpup1LRWw= X-Google-Smtp-Source: APiQypL+eEKtkUOFf2EjtwdZr1+7NBkU7zGNKIK4C1nCqA7ypoV3kzmuidwmBCJ4nftZsbAUPe55Cw== X-Received: by 2002:aa7:d042:: with SMTP id n2mr18050403edo.374.1586169275172; Mon, 06 Apr 2020 03:34:35 -0700 (PDT) Received: from kozik-lap ([194.230.155.125]) by smtp.googlemail.com with ESMTPSA id f13sm2407349edn.50.2020.04.06.03.34.33 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 06 Apr 2020 03:34:34 -0700 (PDT) Date: Mon, 6 Apr 2020 12:34:32 +0200 From: Krzysztof Kozlowski To: Hyunki Koo Subject: Re: [PATCH v5 2/2] tty: samsung_tty: 32-bit access for TX/RX hold registers Message-ID: <20200406103432.GA16798@kozik-lap> References: <20200401082721.19431-1-hyunki00.koo@samsung.com> <20200406103127.17105-1-hyunki00.koo@samsung.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200406103127.17105-1-hyunki00.koo@samsung.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200406_033437_849367_3690F9A0 X-CRM114-Status: GOOD ( 13.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, Rob Herring , Kukjin Kim , linux-serial@vger.kernel.org, Jiri Slaby , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Apr 06, 2020 at 07:31:25PM +0900, Hyunki Koo wrote: > Support 32-bit access for the TX/RX hold registers UTXH and URXH. > > This is required for some newer SoCs. > > Signed-off-by: Hyunki Koo > --- > v2: > line 954 : change rd_regl to rd_reg in for backward compatibility. > line 2031: Add init value for ourport->port.iotype to UPIO_MEM > v3: > line 2031: remove redundant init value for ourport->port.iotype > v4: > correct variable types and change misleading function name > v5: > add dt-binding and go as first patch in this series. > > --- > drivers/tty/serial/samsung_tty.c | 76 +++++++++++++++++++++++++++++++++------- > 1 file changed, 64 insertions(+), 12 deletions(-) For me it is fine, although Greg wanted the write functions to be consistent with read around default case. Reviewed-by: Krzysztof Kozlowski Tested-by: Krzysztof Kozlowski Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel