From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CDE5C2BA1E for ; Mon, 6 Apr 2020 11:04:21 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 59F65206F5 for ; Mon, 6 Apr 2020 11:04:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="eA2i9/UP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 59F65206F5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dwE821a1f4OZbAZu72xBnDPPMemxem737/YOeVxBzVk=; b=eA2i9/UPNraHvD bV+OYv8zUHy6B3cRkTVxJLeRdJcLV3k7L6wmb9m+6oNa2opPYPS5VbD4qqW5EZy/sI7kc07qwO7b+ 2YcW5h2LLk2jX09M1dY/ZigMsBD5utWXo+nsTvqrNb8sEfsEjqVw8wGNStuzUyvSh/zbSMHDZ4L4X FOPd1aTeXbL/I86Tcl21AyIkWXX9ykH0TueQzfsl93gBqZYOFRIABavVimQDOEu7na58ykZeJI8BU eZclnGGhPgYhX8Uwb1KItILgYc1lvUDWX6DmsuzewXotERJ//Da9fWR/UrwAabJ6cW561IKCNlZ8K QRl4RDLhMPvuHOEy7t4Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jLPYB-0005SQ-9l; Mon, 06 Apr 2020 11:04:19 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jLPY4-0005HX-0O for linux-arm-kernel@lists.infradead.org; Mon, 06 Apr 2020 11:04:13 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id F1B0B30E; Mon, 6 Apr 2020 04:04:08 -0700 (PDT) Received: from red-moon.cambridge.arm.com (unknown [10.57.29.239]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C86403F52E; Mon, 6 Apr 2020 04:04:07 -0700 (PDT) Date: Mon, 6 Apr 2020 12:04:01 +0100 From: Lorenzo Pieralisi To: Ard Biesheuvel Subject: Re: [PATCH] arm64: iort: take _DMA methods into account for named components Message-ID: <20200406110401.GA4650@red-moon.cambridge.arm.com> References: <20200404073047.17898-1-ardb@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200404073047.17898-1-ardb@kernel.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200406_040412_110075_D089820C X-CRM114-Status: GOOD ( 15.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: catalin.marinas@arm.com, will@kernel.org, robin.murphy@arm.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Apr 04, 2020 at 09:30:47AM +0200, Ard Biesheuvel wrote: > Where IORT nodes for named components can describe simple DMA limits > expressed as the number of address bits a device can driver, _DMA methods > in AML can express more complex topologies, involving DMA translation in > particular. > > Currently, we only take this _DMA method into account if it appears on a > ACPI device node describing a PCIe root complex, but it is perfectly > acceptable to attach them to named components as well, so let's ensure > we take them into account in those cases too. ACPI spec v6.3, 6.2.4 _DMA: "_DMA is only defined under devices that represent buses" This should probably be updated and _DMA usage clarified - we can't leave it open to interpretation. Thanks, Lorenzo > Reported-by: Andrei Warkentin > Fixes: 7ad4263980826e8b ("ACPI: Make acpi_dma_configure() DMA regions aware") > Cc: # v4.14+ > Signed-off-by: Ard Biesheuvel > --- > drivers/acpi/arm64/iort.c | 11 ++++------- > 1 file changed, 4 insertions(+), 7 deletions(-) > > diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c > index ed3d2d1a7ae9..07eb78baf198 100644 > --- a/drivers/acpi/arm64/iort.c > +++ b/drivers/acpi/arm64/iort.c > @@ -1146,13 +1146,10 @@ void iort_dma_setup(struct device *dev, u64 *dma_addr, u64 *dma_size) > else > size = 1ULL << 32; > > - if (dev_is_pci(dev)) { > - ret = acpi_dma_get_range(dev, &dmaaddr, &offset, &size); > - if (ret == -ENODEV) > - ret = rc_dma_get_range(dev, &size); > - } else { > - ret = nc_dma_get_range(dev, &size); > - } > + ret = acpi_dma_get_range(dev, &dmaaddr, &offset, &size); > + if (ret == -ENODEV) > + ret = dev_is_pci(dev) ? rc_dma_get_range(dev, &size) > + : nc_dma_get_range(dev, &size); > > if (!ret) { > /* > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel