From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC9D4C2BA17 for ; Mon, 6 Apr 2020 18:23:32 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9C6E220672 for ; Mon, 6 Apr 2020 18:23:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="DULAqy4t"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="UPvVgdH8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9C6E220672 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4NmODEl0TGFTAq+neiZ+M0MZO+EOuommg33Ghr6zYzY=; b=DULAqy4t2OcYcE pZLFie4oP/ubR4ev00olHl0nBZEKkuAG47ZgP6/b/06MuZijD0WTCmm99ATbuY+TNhoNum0l+FaDj rjJDsEddUsucT2pOPuMQQgObxrGmMR0Z9pOFk0oW8gBDI4+YX5gh4uni/hmrPfjcaxRqXaCKq6wt3 lzA4P2qcuhgUg81qAD1UA/swzcWwrFQmUUjGMiCSRJOCRGln64L1T4y4RNopnAaD7z+IeJ6KJNYqt vWJw4urek4DuQcicDoWKS2DBGT05c58ZKpsXDtRK2G/+Ge/OnASoDqNQSlG4Agj/Nz9hBm3B5GC13 DZAJbdhdg1v9GAVVODXA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jLWPD-0002bS-QN; Mon, 06 Apr 2020 18:23:31 +0000 Received: from mail-pj1-x1041.google.com ([2607:f8b0:4864:20::1041]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jLWPA-0002ac-D4 for linux-arm-kernel@lists.infradead.org; Mon, 06 Apr 2020 18:23:29 +0000 Received: by mail-pj1-x1041.google.com with SMTP id ng8so206968pjb.2 for ; Mon, 06 Apr 2020 11:23:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=t1E7i5Ja/N4v3hN9ILxMO9xPBTPnxiRK5Clfelm4oBw=; b=UPvVgdH8M87ZZpVFk710GBac6Ivj+/QhMtWTYlwmRZOj1tj7f2kNEC+ZiI35QZ5dL4 MGx/U2nXkhynTePhJKF2P/g9mbGDtn5+ErGMSjnhl32QKNOfQYn2U+paYJNipAm3VyAA D58HSMWOlbmLBj7Gg5Te2Kpdrw+3StLiF0oh0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=t1E7i5Ja/N4v3hN9ILxMO9xPBTPnxiRK5Clfelm4oBw=; b=nytzA756slKaEEVLgjjNlfmtQTvNQezqlmTEr9xBzsWKs8bCNc4T2mXBqvxIbTM+zt jcu1TRCA4fnNODPQwilyc2YMoU5pzascC9rJclV4qfx1JGrLXuETYXF8W81ypuF5xy2N srUufb4i2ht60NjwL4uBQGrdKYUiAoYCDBXNkRnmWorc/472kq5KFgcOK68DCR7zp/Su ppbvih9r2xpSVs/yYua+3AzfIUt+B6QnlSlLgqPoQD434rQV9EV6VCslHQrIcpUs5qjl LT/1nZ5L5D8tFiEQEIZXOT5UiAh0zjzSvtNKkMvwZb06Dkhvjw50GyJ0M2BuUM5iTDkE t7Qw== X-Gm-Message-State: AGi0PuZL6vVa/Z5KQ0qWOEIZXcAlstyXVAQi2L7PHmgc1TwBEr8BdURm pYHSEh56QCpgkcVPwYbhVkhgBQ== X-Google-Smtp-Source: APiQypIUOtn72OybuMmOpw7ZoRHvYwoqpUGT0d68iEfAhBT8YfgewjV9UGIYBvXQYFb80jItY6ieRQ== X-Received: by 2002:a17:902:d685:: with SMTP id v5mr22055094ply.256.1586197407139; Mon, 06 Apr 2020 11:23:27 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id e184sm12005953pfh.219.2020.04.06.11.23.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Apr 2020 11:23:26 -0700 (PDT) Date: Mon, 6 Apr 2020 11:23:24 -0700 From: Kees Cook To: Sami Tolvanen Subject: Re: [PATCH v10 09/12] arm64: disable SCS for hypervisor code Message-ID: <202004061123.CE436424@keescook> References: <20191018161033.261971-1-samitolvanen@google.com> <20200406164121.154322-1-samitolvanen@google.com> <20200406164121.154322-10-samitolvanen@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200406164121.154322-10-samitolvanen@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200406_112328_472918_80FA2894 X-CRM114-Status: GOOD ( 14.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , clang-built-linux@googlegroups.com, Ard Biesheuvel , Masahiro Yamada , Catalin Marinas , Jann Horn , Nick Desaulniers , linux-kernel@vger.kernel.org, Steven Rostedt , Miguel Ojeda , James Morse , Masami Hiramatsu , Marc Zyngier , kernel-hardening@lists.openwall.com, Laura Abbott , Will Deacon , Dave Martin , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Apr 06, 2020 at 09:41:18AM -0700, Sami Tolvanen wrote: > Disable SCS for code that runs at a different exception level by > adding __noscs to __hyp_text. > > Suggested-by: James Morse > Signed-off-by: Sami Tolvanen Reviewed-by: Kees Cook -Kees > Acked-by: Marc Zyngier > --- > arch/arm64/include/asm/kvm_hyp.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/include/asm/kvm_hyp.h b/arch/arm64/include/asm/kvm_hyp.h > index fe57f60f06a8..875b106c5d98 100644 > --- a/arch/arm64/include/asm/kvm_hyp.h > +++ b/arch/arm64/include/asm/kvm_hyp.h > @@ -13,7 +13,7 @@ > #include > #include > > -#define __hyp_text __section(.hyp.text) notrace > +#define __hyp_text __section(.hyp.text) notrace __noscs > > #define read_sysreg_elx(r,nvh,vh) \ > ({ \ > -- > 2.26.0.292.g33ef6b2f38-goog > -- Kees Cook _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel