From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD95AC2BA17 for ; Mon, 6 Apr 2020 17:32:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B26AB20672 for ; Mon, 6 Apr 2020 17:32:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="bh5oBF/d"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="VYRfYJdn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B26AB20672 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Jogdvvcdk92J/BaJaZ+NS/Tph2oTKx4dcKmHa00No8Y=; b=bh5oBF/dCjh1gc EAYEyF1amWZ+tY2O62Uo69gfR/I8jK09+Omxt+oyun6ZMfA69V6KxAglCmJ+rQ5vFChfCa/o17VKg r+QWkwGcgRK12ZnMSVCK+D68XVadlEZUKgtd+eK0v+Md1K4Pz0ROxzIf/4UI5BPyRbNd14Xy24raf nznrhWodOXNGl4pfKoKIerH/ak6AyYdymzM4kLY2OBIACegGgkcgXef0C4Il1bzF71HQAfwksEF8c wxCxBAxOJBHr484ixqaLGWVSXFuuKenqcPKdDPHeEbUF6A7tXByXwyz+fNZQwhKxlGCaXlEaOUVDF vAkl4RBO/SCQNhc3PGWQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jLVcG-00011y-TL; Mon, 06 Apr 2020 17:32:56 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jLVcE-0000qY-1E for linux-arm-kernel@lists.infradead.org; Mon, 06 Apr 2020 17:32:55 +0000 Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 01CED1031; Mon, 6 Apr 2020 19:32:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1586194364; bh=UvEmac5uaQ/qcTzqBjGKkxMOGVtF/DXYqGMo+nzYdoo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VYRfYJdnA256/yTKJfooJh72XMp690mHO4hGlWRTr6xEALlY8+OECMVFRsfOSoUg9 C23doRU9Itdwlp9uOi/wyyoNqynKJMZXhHMQakFiP0w474D/QpFXXBLj0eK3mwTq3A oImf7aE8hpD/jc9SLOs8Zabkl0X4r989K1fM2wTw= Date: Mon, 6 Apr 2020 20:32:34 +0300 From: Laurent Pinchart To: Sakari Ailus Subject: Re: [PATCH v5 2/5] media: i2c: ov5645: Drop reading clock-frequency dt-property Message-ID: <20200406173234.GD16885@pendragon.ideasonboard.com> References: <1586191361-16598-1-git-send-email-prabhakar.mahadev-lad.rj@bp.renesas.com> <1586191361-16598-3-git-send-email-prabhakar.mahadev-lad.rj@bp.renesas.com> <20200406165108.GA7646@kekkonen.localdomain> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200406165108.GA7646@kekkonen.localdomain> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200406_103254_218962_398A1B0F X-CRM114-Status: GOOD ( 14.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Geert Uytterhoeven , Fabio Estevam , Sascha Hauer , Kieran Bingham , Lad Prabhakar , linux-kernel@vger.kernel.org, Lad Prabhakar , Rob Herring , NXP Linux Team , Pengutronix Kernel Team , Maxime Ripard , Mauro Carvalho Chehab , Shawn Guo , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Sakari, (CC'ing Maxime) On Mon, Apr 06, 2020 at 07:51:08PM +0300, Sakari Ailus wrote: > On Mon, Apr 06, 2020 at 05:42:38PM +0100, Lad Prabhakar wrote: > > Modes in the driver are based on xvclk frequency fixed to 24MHz, but where > > as the OV5645 sensor can support the xvclk frequency ranging from 6MHz to > > 24MHz. So instead making clock-frequency as dt-property just let the > > driver enforce the required clock frequency. > > Even if some current systems where the driver is used are using 24 MHz > clock, that doesn't mean there wouldn't be systems using another frequency > that the driver does not support right now. > > The driver really should not set the frequency unless it gets it from DT, > but I think the preferred means is to use assigned-clock-rates instead, and > not to involve the driver with setting the frequency. > > Otherwise we'll make it impossible to support other frequencies, at least > without more or less random defaults. We're running in circles here. As the driver only supports 24MHz at the moment, the frequency should be set by the driver, as it's a driver limitation. We can then work on supporting additional frequencies, which will require DT to provide a list of supported frequencies for the system, but that can be done on top. -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel