From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A788EC2BA1E for ; Mon, 6 Apr 2020 17:34:39 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7570F206C0 for ; Mon, 6 Apr 2020 17:34:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="aaHMGwIo"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="tcPYpWFF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7570F206C0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=K0xw2es4ntexMJhQlse7C3Uv7LTkgIrRkyEh3uALfyo=; b=aaHMGwIoqdL7Ll HHXBKZJhuEZyle6RaJahAsdyEJK5qqeZaylOyqAf7jI9P3CXEu15Ncke4oDG/49y3HFTqPypvTW2d rdQFZBOcrIrP7+wu/PuYztM8G969WqLq8b1ootZWe5j5f/oupKD+lwV9LLfnG/TdvkscFn2vrfiW5 wTaEyVat5IGzwX1qtjSI3RqLEODzm/i2cdnVIOp9iiyCl0oTfk5kyKGkX5qN/TzTkAd6c5WX62IH9 ieW1C3MH8cGmwmKx+qSxicxEBwqzn3elVyTqNd4qOcEDcuV8H3bdzMEqzCFNBW85/XPX/SH+bUqus Vly6vbDTrvX2ku6nPwTw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jLVdu-0001XH-RJ; Mon, 06 Apr 2020 17:34:38 +0000 Received: from perceval.ideasonboard.com ([2001:4b98:dc2:55:216:3eff:fef7:d647]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jLVds-0001Wp-5s for linux-arm-kernel@lists.infradead.org; Mon, 06 Apr 2020 17:34:37 +0000 Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 2703B1031; Mon, 6 Apr 2020 19:34:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1586194474; bh=OGW4c+P9fFS1PSMqFifiUAu605HJXi05WA0RoAqLBCc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tcPYpWFFD07G9ZvZRgLzeLNEsYyAtR/ugbRuA4O+xeTaVeKLLhI9gATMVR6PVaEtt R+79ybXYpC2Z0yRx/HZQVkIWOHAIykOHWSJtyb89VkEdngDFtdJJVCfazdDYEeiGw2 piIZeBaytyo6ZWhihn9HmYLMzbRsi2fxakI7UoU4= Date: Mon, 6 Apr 2020 20:34:25 +0300 From: Laurent Pinchart To: Lad Prabhakar Subject: Re: [PATCH v5 2/5] media: i2c: ov5645: Drop reading clock-frequency dt-property Message-ID: <20200406173425.GE16885@pendragon.ideasonboard.com> References: <1586191361-16598-1-git-send-email-prabhakar.mahadev-lad.rj@bp.renesas.com> <1586191361-16598-3-git-send-email-prabhakar.mahadev-lad.rj@bp.renesas.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1586191361-16598-3-git-send-email-prabhakar.mahadev-lad.rj@bp.renesas.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200406_103436_378788_FC566F08 X-CRM114-Status: GOOD ( 16.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Pengutronix Kernel Team , Geert Uytterhoeven , Fabio Estevam , Sascha Hauer , Kieran Bingham , linux-kernel@vger.kernel.org, Lad Prabhakar , Rob Herring , NXP Linux Team , Sakari Ailus , Mauro Carvalho Chehab , Shawn Guo , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Prabhakar, Thank you for the patch. On Mon, Apr 06, 2020 at 05:42:38PM +0100, Lad Prabhakar wrote: > Modes in the driver are based on xvclk frequency fixed to 24MHz, but where > as the OV5645 sensor can support the xvclk frequency ranging from 6MHz to > 24MHz. So instead making clock-frequency as dt-property just let the > driver enforce the required clock frequency. > > Signed-off-by: Lad Prabhakar > --- > drivers/media/i2c/ov5645.c | 14 +++++--------- > 1 file changed, 5 insertions(+), 9 deletions(-) > > diff --git a/drivers/media/i2c/ov5645.c b/drivers/media/i2c/ov5645.c > index a6c17d15d754..52848fff8a08 100644 > --- a/drivers/media/i2c/ov5645.c > +++ b/drivers/media/i2c/ov5645.c > @@ -61,6 +61,8 @@ > #define OV5645_SDE_SAT_U 0x5583 > #define OV5645_SDE_SAT_V 0x5584 > > +#define OV5645_XVCLK_FREQ 24000000 > + > /* regulator supplies */ > static const char * const ov5645_supply_name[] = { > "vdddo", /* Digital I/O (1.8V) supply */ > @@ -1094,25 +1096,19 @@ static int ov5645_probe(struct i2c_client *client) > return PTR_ERR(ov5645->xclk); > } > > - ret = of_property_read_u32(dev->of_node, "clock-frequency", &xclk_freq); > + ret = clk_set_rate(ov5645->xclk, OV5645_XVCLK_FREQ); > if (ret) { > - dev_err(dev, "could not get xclk frequency\n"); > + dev_err(dev, "could not set xclk frequency\n"); > return ret; > } > - I think you can keep the blank line here. Reviewed-by: Laurent Pinchart > /* external clock must be 24MHz, allow 1% tolerance */ > + xclk_freq = clk_get_rate(ov5645->xclk); > if (xclk_freq < 23760000 || xclk_freq > 24240000) { > dev_err(dev, "external clock frequency %u is not supported\n", > xclk_freq); > return -EINVAL; > } > > - ret = clk_set_rate(ov5645->xclk, xclk_freq); > - if (ret) { > - dev_err(dev, "could not set xclk frequency\n"); > - return ret; > - } > - > for (i = 0; i < OV5645_NUM_SUPPLIES; i++) > ov5645->supplies[i].supply = ov5645_supply_name[i]; > -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel