From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7AD13C2BA1E for ; Mon, 6 Apr 2020 17:35:49 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 51B0C20672 for ; Mon, 6 Apr 2020 17:35:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="e/AI2Xuh"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="iRfOGyoN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 51B0C20672 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=h3mjxEZfk711fhBe/Rh4TWL0Pmoa7K29rL5pThvsrck=; b=e/AI2XuhGGDZxN rRTDscMXKZ2iEwFjIWhbKdfUmBaifALHUNYlx9XYVx9MTVmqD8iY674B/xfFfhU6RVZnkAsBv7iNC 0cS/o7h06ThGEHk0yMMKduYXCYNwJf9j3bSB0eKtZ6LCSEzL/+ucQtRFZ2OARGp+6DGI+GB5o4sxY tOTtMaMD6DtDoPRLK0NrJNdERAsLSGlQhwY6SdV1qKj+B8Nvnw+XbuKtEdWTizq8YFko6M+c2a7j5 7D2Mek/zwwj2duuGdzaCkGrhg71c7kLGJ6KY7M1bbTZJoG0nJtHRlmWkZQ+39UzsYZMSNkGxGYttS 82gtIClTS2bUpNim2T7w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jLVey-00053f-Ou; Mon, 06 Apr 2020 17:35:44 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jLVeT-00045b-Rd for linux-arm-kernel@lists.infradead.org; Mon, 06 Apr 2020 17:35:17 +0000 Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 43CE11031; Mon, 6 Apr 2020 19:35:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1586194512; bh=2GdPMyBtue+7HjxdIkmbI8MT7kHPXJlMQFDnms22Grg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iRfOGyoNHLTIP8t/BMlEzG8LaBpJJdwZ0CyoIc9N2yRm852YnFtRPoSf5UP26DDbC 0st+N6m66yfe/0t2KgsS6J07tsRzMWM5aVHKGoPwLSOOC9P/ZRKScFg5W+5YFReJtL 3c6SfeuVZYw/uXUa1eAVXBH1hJ+CcW8dnauutFxo= Date: Mon, 6 Apr 2020 20:35:03 +0300 From: Laurent Pinchart To: Lad Prabhakar Subject: Re: [PATCH v5 3/5] media: i2c: ov5645: Turn probe error into warning for xvclk frequency mismatch Message-ID: <20200406173503.GF16885@pendragon.ideasonboard.com> References: <1586191361-16598-1-git-send-email-prabhakar.mahadev-lad.rj@bp.renesas.com> <1586191361-16598-4-git-send-email-prabhakar.mahadev-lad.rj@bp.renesas.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1586191361-16598-4-git-send-email-prabhakar.mahadev-lad.rj@bp.renesas.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200406_103514_149109_9C0CE301 X-CRM114-Status: GOOD ( 14.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Pengutronix Kernel Team , Geert Uytterhoeven , Fabio Estevam , Sascha Hauer , Kieran Bingham , linux-kernel@vger.kernel.org, Lad Prabhakar , Rob Herring , NXP Linux Team , Sakari Ailus , Mauro Carvalho Chehab , Shawn Guo , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Prabhakar, Thank you for the patch. On Mon, Apr 06, 2020 at 05:42:39PM +0100, Lad Prabhakar wrote: > PLL's on platforms might not be so accurate enough to generate the > required clock frequency, so instead of erroring out on xvlck frequency > mismatch just warn the user and continue ahead in probe. > > Signed-off-by: Lad Prabhakar Reviewed-by: Laurent Pinchart > --- > drivers/media/i2c/ov5645.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/media/i2c/ov5645.c b/drivers/media/i2c/ov5645.c > index 52848fff8a08..314760349adf 100644 > --- a/drivers/media/i2c/ov5645.c > +++ b/drivers/media/i2c/ov5645.c > @@ -1103,11 +1103,8 @@ static int ov5645_probe(struct i2c_client *client) > } > /* external clock must be 24MHz, allow 1% tolerance */ > xclk_freq = clk_get_rate(ov5645->xclk); > - if (xclk_freq < 23760000 || xclk_freq > 24240000) { > - dev_err(dev, "external clock frequency %u is not supported\n", > - xclk_freq); > - return -EINVAL; > - } > + if (xclk_freq < 23760000 || xclk_freq > 24240000) > + dev_warn(dev, "xvclk mismatched, modes are based on 24MHz\n"); > > for (i = 0; i < OV5645_NUM_SUPPLIES; i++) > ov5645->supplies[i].supply = ov5645_supply_name[i]; -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel