From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D882C2BB1D for ; Tue, 7 Apr 2020 07:22:35 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EF0EC20678 for ; Tue, 7 Apr 2020 07:22:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="T+JX/Fa1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EF0EC20678 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KO/I3OBk2SIXwj6OVqHL8VSh6b6dUNBp0QY2zzOjRNM=; b=T+JX/Fa1xSOUYF ZSotI7NfFohL0hB70oJ9h5kfEJD+lYlT8oop+P+eJMZNAXXX7j3kQMUYlKBMtTefjxcyTUQrqkg3M XdBSM6ApHCJa++xIQB9yhkZkJ6O3T/osEMmTPHR/LXOJCDLV5lpg10le7xGyZaFQipTE/MOnQC4Da EBejBF2Ie+N67DCt4zyuFMSkPu6U+LRGWFwo1buA8DRwWZ8g386HNtJ+G3rpYz8dRU/+p86AGE8gL 8ZVOmEZu87ee12Ru16pOVz+YkmFCjhXvX6uRcwMk3OqPBk+Htvqt7piD1Tn+Oxu5IMY/ehN7F73uG YZzQDEdIW/IKLVfRLbWQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jLiZ8-00008g-A8; Tue, 07 Apr 2020 07:22:34 +0000 Received: from mail-ed1-f65.google.com ([209.85.208.65]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jLiZ0-00007J-Lk for linux-arm-kernel@lists.infradead.org; Tue, 07 Apr 2020 07:22:32 +0000 Received: by mail-ed1-f65.google.com with SMTP id i16so2726508edy.11 for ; Tue, 07 Apr 2020 00:22:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=2R+3gjNy0SnBLUw5qWy9RI2DQvlFhSy+vrS7w50bWE4=; b=kLxd1J9GyE9leJIuOcBzsFZ8QouJnVXzd6QW1V/Q/4uKoiyPCRpb2KzQ/Q67YxpTB0 jFckIi2US0e33cTe6QeesEl6WeZP5rTUsa21BcQDtK0TTQHyItBExtGoQwycoWpFMnxZ IOucBjcUSST+pJTmxKetXsU+jBeOT1Ap+HXjyLQBq8lcD3Ngi+FD67Wi/N80X3i6U4cK 7NdVROAbed5whYDgIbH09nD16uRwLt6PrXN/Dx9bFT2J4m/m/r/x9FQaL9UwIPamBVY/ uLVR4HRIzv/gNIhGnCxE1jbc9DSNJxt8Z2Zf7KgbUkdQ8WryvJlThitfZjeMnHdDgXKf neCA== X-Gm-Message-State: AGi0PuajC5meuPvi3I5DHF0OvLlzB90Rn4xhFrakeGROx/balMz8alaH yBqmxgc6FlkzkU20rTB6wdM= X-Google-Smtp-Source: APiQypIAGwgfjaRfHihsJeJ737ZyX6DGCobU8BkZcdk7Gc5hUQmvmBkfIOK6sewJ+lnv4/IXbMKBwg== X-Received: by 2002:a50:9b58:: with SMTP id a24mr759017edj.353.1586244144485; Tue, 07 Apr 2020 00:22:24 -0700 (PDT) Received: from kozik-lap ([194.230.155.125]) by smtp.googlemail.com with ESMTPSA id qu11sm230130ejb.12.2020.04.07.00.22.23 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 07 Apr 2020 00:22:23 -0700 (PDT) Date: Tue, 7 Apr 2020 09:22:21 +0200 From: Krzysztof Kozlowski To: Jiri Slaby Subject: Re: [PATCH v6 2/2] tty: samsung_tty: 32-bit access for TX/RX hold registers Message-ID: <20200407072221.GA18236@kozik-lap> References: <20200401082721.19431-1-hyunki00.koo@samsung.com> <20200406230855.13772-1-hyunki00.koo@samsung.com> <62a918df-b3ba-21f4-b3ad-9f638ad104ad@suse.com> <20200407062439.GA21995@kozik-lap> <257f278b-ce96-4cfb-85ff-53e123a076f5@suse.cz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <257f278b-ce96-4cfb-85ff-53e123a076f5@suse.cz> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200407_002230_449712_9E0DB7FC X-CRM114-Status: GOOD ( 18.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, Rob Herring , Kukjin Kim , linux-serial@vger.kernel.org, Hyunki Koo Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Apr 07, 2020 at 08:32:56AM +0200, Jiri Slaby wrote: > On 07. 04. 20, 8:24, Krzysztof Kozlowski wrote: > > On Tue, Apr 07, 2020 at 06:49:29AM +0200, Jiri Slaby wrote: > >> On 07. 04. 20, 1:08, Hyunki Koo wrote: > >>> Support 32-bit access for the TX/RX hold registers UTXH and URXH. > >>> > >>> This is required for some newer SoCs. > >>> > >>> Signed-off-by: Hyunki Koo > >> ... > >>> --- > >>> drivers/tty/serial/samsung_tty.c | 76 +++++++++++++++++++++++++++++++++------- > >>> 1 file changed, 64 insertions(+), 12 deletions(-) > >>> > >>> diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c > >>> index 73f951d65b93..bdf1d4d12cb1 100644 > >>> --- a/drivers/tty/serial/samsung_tty.c > >>> +++ b/drivers/tty/serial/samsung_tty.c > >>> @@ -154,12 +154,47 @@ struct s3c24xx_uart_port { > >> ... > >>> -#define wr_regb(port, reg, val) writeb_relaxed(val, portaddr(port, reg)) > >>> +static void wr_reg(struct uart_port *port, u32 reg, u32 val) > >>> +{ > >>> + switch (port->iotype) { > >>> + case UPIO_MEM: > >>> + writeb_relaxed(val, portaddr(port, reg)); > >>> + break; > >>> + case UPIO_MEM32: > >>> + writel_relaxed(val, portaddr(port, reg)); > >>> + break; > >>> + } > >>> +} > >>> + > >>> #define wr_regl(port, reg, val) writel_relaxed(val, portaddr(port, reg)) > >>> > >>> +static void wr_reg_barrier(struct uart_port *port, u32 reg, u32 val) > >> > >> You need to explain, why you need this _barrier variant now. This change > >> should be done in a separate patch too. > > > > There is no functional change in regard of barrier. The ordered IO was > > used there before. > > The patch changes one wr_reg to wr_reg_barrier without any explanation. > This will hardly be accepted. I cannot find such change... I see only: @@ -2612,7 +2664,7 @@ static void samsung_early_putc(struct uart_port *port, int c) - writeb(c, port->membase + S3C2410_UTXH); + wr_reg_barrier(port, S3C2410_UTXH, c); which is the same except 'b' -> 'b/l'. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel