From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB67BC2D0EA for ; Wed, 8 Apr 2020 10:56:01 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8A04820747 for ; Wed, 8 Apr 2020 10:56:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="kqngx8RU"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="HpNs0wdn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8A04820747 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UGUm3xI3JMujG9F8ZIjY37PO3w2SbnUxrvO/yHo03bM=; b=kqngx8RUiCnsi7 4Ilm3GVUn0Ng7PrXOKqKmjTm5O8GuNYBc1EHarlIFOwBnWGEaTGXsJEmNoUe7QQ7dNoqPz3sLGEex ialFREB+pByJKGOwr12mbnZxnrUMd3GvfVNYpNo6jatoCPJAUntWSKnesNrVKfGUAZ6gKV+A+z1wR N7m+HmG8zWD1jfIUxiOX2eex/c7Y2ydZcvLw1M9YN/EBRlxuxn+PEhPbkzHHvxk1SkMurgULmXh2i Qqcpu+TP+FRW1Qq3Gn7oC6ebSZ8PJnmF8gXhWMs1DxW/eJ+GUZNznIpAY1Mr+49v9yht95cuFH7fZ 9AuyJEWi/nIai7H14TZQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jM8NF-0004Pj-8L; Wed, 08 Apr 2020 10:56:01 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:3201:214:fdff:fe10:1be6]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jM8NB-0004O8-NG for linux-arm-kernel@lists.infradead.org; Wed, 08 Apr 2020 10:55:59 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=w6dHPYMv2i9dm01SaFUvBAnpyuM/9O8Vy7ZNYT4fAcY=; b=HpNs0wdn7sIB4LHpoFt4EPV2v ugIr1QFTho4/bn6ATMEWn/ThHaK3CzQqQX1yYflUUX7BTC4wiB+EmHxzWF0CJrly9cZK1uLca/RZs /SbuAkNVXidImBiJRAWZ40Cf39MVWTyEkXLmYLqCza7ufVHCV3KO+QMqzNe4piJv7pYKWWv3St+BV ir7kkXkdJkNpBkP0ycIJ/q+pejyz/D3ndwa02/VkX/z9OwGn5jb5IxUb95LK9+XEQ/5JHOmMZNmS+ /OizKNwKIM0oBYRYpDTTc0uohJEIOKRoXtBzSdxRCnW/JL30g5ZwWIT3PQv27Pj4tddYvUlHjjEud IMX7H5geg==; Received: from shell.armlinux.org.uk ([2002:4e20:1eda:1:5054:ff:fe00:4ec]:43136) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jM8Mn-0005RT-IU; Wed, 08 Apr 2020 11:55:33 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1jM8Mk-0001mF-Ry; Wed, 08 Apr 2020 11:55:30 +0100 Date: Wed, 8 Apr 2020 11:55:30 +0100 From: Russell King - ARM Linux admin To: Hui Song Subject: Re: [PATCH v1] gpio: mpc8xxx: Add shutdown function. Message-ID: <20200408105530.GR25745@shell.armlinux.org.uk> References: <20200408102118.17572-1-hui.song_1@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200408102118.17572-1-hui.song_1@nxp.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200408_035557_759848_5E59C2C9 X-CRM114-Status: GOOD ( 19.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, Linus Walleij , linux-kernel@vger.kernel.org, Li Yang , Bartosz Golaszewski , Rob Herring , Shawn Guo , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Apr 08, 2020 at 06:21:17PM +0800, Hui Song wrote: > From: Song Hui > > The shutdown function needed to make interrupt handler to be NULL > when kexec execute. > > Signed-off-by: Song Hui Please improve the commit message. You describe what change the patch is making (which we can see from reading the patch), but you don't explain why it is necessary, or really what problem the patch is solving. I'm not aware of other implementations needing this for kexec to work. Thanks. > --- > drivers/gpio/gpio-mpc8xxx.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/drivers/gpio/gpio-mpc8xxx.c b/drivers/gpio/gpio-mpc8xxx.c > index 604dfec..a24e6c5 100644 > --- a/drivers/gpio/gpio-mpc8xxx.c > +++ b/drivers/gpio/gpio-mpc8xxx.c > @@ -446,9 +446,21 @@ static int mpc8xxx_remove(struct platform_device *pdev) > return 0; > } > > +static int mpc8xxx_shutdown(struct platform_device *pdev) > +{ > + struct mpc8xxx_gpio_chip *mpc8xxx_gc = platform_get_drvdata(pdev); > + > + if (mpc8xxx_gc->irq) { > + irq_set_chained_handler_and_data(mpc8xxx_gc->irqn, NULL, NULL); > + irq_domain_remove(mpc8xxx_gc->irq); > + } > + > + return 0; > +} > static struct platform_driver mpc8xxx_plat_driver = { > .probe = mpc8xxx_probe, > .remove = mpc8xxx_remove, > + .shutdown = mpc8xxx_shutdown, > .driver = { > .name = "gpio-mpc8xxx", > .of_match_table = mpc8xxx_gpio_ids, > -- > 2.9.5 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 10.2Mbps down 587kbps up _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel