From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36368C2D0EA for ; Wed, 8 Apr 2020 12:49:09 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 03EB82051A for ; Wed, 8 Apr 2020 12:49:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="SBTeqazQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 03EB82051A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sina.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2R2uIRCIumsZGZmaomguStMJS2YRnzxy36YnKl3mhJM=; b=SBTeqazQlyRBf2 vKdr6qsHXeloiF+Dh4/LFNvzX2Fg7HYV8VvZdA77ta3Vl50rDP5wdwbCwo9EVLMk/4YnKDxVktL3K j8AmGtkbCiIPsrDDdMQXX7YCiS9qGeitKoRGUlRK331FEj31rapRwjpf2sGEvNF1otG3jX/+bqVh5 a60oQCJZXY4YFyd812nYtoi9QJeLEbZvKoCzXZ2B6WEmwUSiK0haaDlCZgRviOUG8mLbzd95Jtan5 tFUbxnhfKHsN3QH9TlgUMIIiKUHt+l2BQpIaVGp3nNCP7S+LXWy8U6p9m2bbTmKdPvu5jYZ+bB+6J dj6SQywTbAfCft3DEOMg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jMA8i-0000mE-C8; Wed, 08 Apr 2020 12:49:08 +0000 Received: from r3-19.sinamail.sina.com.cn ([202.108.3.19]) by bombadil.infradead.org with smtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jMA8d-0000k8-Lk for linux-arm-kernel@lists.infradead.org; Wed, 08 Apr 2020 12:49:06 +0000 Received: from unknown (HELO localhost.localdomain)([114.246.227.120]) by sina.com with ESMTP id 5E8DC8290002A7AA; Wed, 8 Apr 2020 20:48:45 +0800 (CST) X-Sender: hdanton@sina.com X-Auth-ID: hdanton@sina.com X-SMAIL-MID: 82000715073508 From: Hillf Danton To: Christoph Hellwig Subject: Re: [PATCH 02/28] staging: android: ion: use vmap instead of vm_map_ram Date: Wed, 8 Apr 2020 20:48:33 +0800 Message-Id: <20200408124833.13032-1-hdanton@sina.com> In-Reply-To: <20200408115926.1467567-1-hch@lst.de> References: <20200408115926.1467567-1-hch@lst.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200408_054903_922397_F942EB3A X-CRM114-Status: GOOD ( 10.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Christophe Leroy , linux-arch@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-s390@vger.kernel.org, Peter Zijlstra , syzkaller-bugs@googlegroups.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-mm@kvack.org, iommu@lists.linux-foundation.org, Andrew Morton , linuxppc-dev@lists.ozlabs.org, bpf@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 8 Apr 2020 13:59:00 +0200 > > vm_map_ram can keep mappings around after the vm_unmap_ram. Using that > with non-PAGE_KERNEL mappings can lead to all kinds of aliasing issues. > > Signed-off-by: Christoph Hellwig > --- > drivers/staging/android/ion/ion_heap.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/android/ion/ion_heap.c b/drivers/staging/android/ion/ion_heap.c > index 473b465724f1..a2d5c6df4b96 100644 > --- a/drivers/staging/android/ion/ion_heap.c > +++ b/drivers/staging/android/ion/ion_heap.c > @@ -99,12 +99,12 @@ int ion_heap_map_user(struct ion_heap *heap, struct ion_buffer *buffer, > > static int ion_heap_clear_pages(struct page **pages, int num, pgprot_t pgprot) > { > - void *addr = vm_map_ram(pages, num, -1, pgprot); > + void *addr = vmap(pages, num, VM_MAP); A merge glitch? void *vmap(struct page **pages, unsigned int count, unsigned long flags, pgprot_t prot) > > if (!addr) > return -ENOMEM; > memset(addr, 0, PAGE_SIZE * num); > - vm_unmap_ram(addr, num); > + vunmap(addr); > > return 0; > } > -- > 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel