From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0D90C2BA2B for ; Thu, 9 Apr 2020 11:36:49 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7604B20B1F for ; Thu, 9 Apr 2020 11:36:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qTkPt4QN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7604B20B1F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YEh/rsAfe34Ab+v2L7I/mMRaaStimgoRT9gS1L1QrrQ=; b=qTkPt4QN6jQJjc DUGCBXA85DuFa2kahuOxEYY8/sEkddQlSEvp8xEARPFK4f62HMRfsfF+gm1/z1vcoJBzikyqRcG5p hkQ2UL8/RgwqIG4PTAiZM1aEfYrSf1AyPTFVh/wt6BIEQZm1jaUVScHrAY/gLSzhin1h7Mu45UxUd l1qZN68OB/MiZkd/JX7Cx4m74VJ6f5i52z/4a+UlliC1pGYlUOTPrhYC3e1/iLdX2+c5awaWMye5X SCit0RQygoPB7pYJhnJtvrazUpAgWTmHAK/vNfi0ZHq4c8TTRXpXCVtY88SmUsbESHMvnhJrratAc QiT5gwNZsIHluYgKz6fg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jMVUD-0006nG-Rr; Thu, 09 Apr 2020 11:36:45 +0000 Received: from asavdk3.altibox.net ([109.247.116.14]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jMVUA-0006mE-UD for linux-arm-kernel@lists.infradead.org; Thu, 09 Apr 2020 11:36:44 +0000 Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id C574C20047; Thu, 9 Apr 2020 13:36:34 +0200 (CEST) Date: Thu, 9 Apr 2020 13:36:33 +0200 From: Sam Ravnborg To: Guido =?iso-8859-1?Q?G=FCnther?= Subject: Re: [PATCH v10 2/2] drm/bridge: Add NWL MIPI DSI host controller support Message-ID: <20200409113633.GA4330@ravnborg.org> References: <22f34fb7cf7ee4262cf63372aee90bc8e5ae3f35.1584730033.git.agx@sigxcpu.org> <20200408175252.GB24828@ravnborg.org> <20200409104314.GB104945@bogon.m.sigxcpu.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200409104314.GB104945@bogon.m.sigxcpu.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=eMA9ckh1 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=wF2D5j3In6wItstX1c4A:9 a=CjuIK1q_8ugA:10 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200409_043643_147327_85ABADF2 X-CRM114-Status: GOOD ( 10.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Jernej Skrabec , Pengutronix Kernel Team , Arnd Bergmann , Neil Armstrong , David Airlie , Fabio Estevam , Sascha Hauer , Jonas Karlman , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Andrzej Hajda , Rob Herring , NXP Linux Team , Daniel Vetter , Robert Chiras , Lee Jones , Shawn Guo , linux-arm-kernel@lists.infradead.org, Laurent Pinchart Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Guido. > > > + > > > +/* i.MX8 NWL quirks */ > > > +/* i.MX8MQ errata E11418 */ > > > +#define E11418_HS_MODE_QUIRK BIT(0) > > > + > > > +#define NWL_DSI_MIPI_FIFO_TIMEOUT msecs_to_jiffies(500) > > Should the defines be moved to the header file? > > I've used this rules: register layout (that is chip properties) > go to the header file while defines specific to this very driver > go into the .c file. Hope that makes sense. Makes good sense, thanks for the explanation. Sam _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel