From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 979D8C2BB55 for ; Thu, 9 Apr 2020 13:26:44 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6B90520A8B for ; Thu, 9 Apr 2020 13:26:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="OZEFgDp2"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="H9uzvWqk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6B90520A8B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Ldhf5ViAN2gBGVu9u+wb10VOmx9BKVGVmdeMgR+umrY=; b=OZEFgDp2er6WXf ytTo7tqVja9Da7cwAAMl6g3XbpggY9QOdm2lC9zzJt1Ruc81IlVun4lsEJR8kaUJRiuNlNVkYAl2t 4rQHK2pUZ77uW/ZZsrqOmrjZuGxO19BFDq5pPfmF4caxMVDQguZ3gobkh3qzA6OrbLfpU8vTRZjjD pEuWH/qGdjRNWJFmrTI1XU0uU5SS66Z9sLFkhsE+RnAPYVfYLXFLFP+9LrBddkISkRSZl4C0K/zBc WJuoVNDrih9jKwFrGq+lNbs/FYh4/cnBwjXAcb7G4MLsUgYQiQircXUo/ZtAnJ4CTQMWKsJGNB8pr rXGMpzOCRZ3WYYFxzNcA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jMXCe-0007ls-3d; Thu, 09 Apr 2020 13:26:44 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jMXCb-0007lX-Oa for linux-arm-kernel@lists.infradead.org; Thu, 09 Apr 2020 13:26:43 +0000 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 62E882072F; Thu, 9 Apr 2020 13:26:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586438801; bh=cV6hSehyX6lw4Tv9+IglB58tggNYFJ6BalVHwJs8cI8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=H9uzvWqkZoza1WwcQy6lLYj+vDp8hvrlgELwPMjzCUzfYJ5JZZHkeINQiHfngaRFe 7WOLZlaXP9ZxF2dUO/OHweSokzXySPzG3A+GzKiIDeTCRFX6R5SSdhlywofkdfwzLU IdwaSKjwyHFZtTWRiPWDOJOI9+eAPT6vkZvZF0Jk= Date: Thu, 9 Apr 2020 14:26:34 +0100 From: Will Deacon To: Vincenzo Frascino Subject: Re: [PATCH v3 21/26] arm64: Introduce asm/vdso/arch_timer.h Message-ID: <20200409132633.GD13078@willie-the-truck> References: <20200313154345.56760-1-vincenzo.frascino@arm.com> <20200313154345.56760-22-vincenzo.frascino@arm.com> <20200315183151.GE32205@mbp> <4914ad9c-3eaf-b328-f31b-5d3077ef272f@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <4914ad9c-3eaf-b328-f31b-5d3077ef272f@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200409_062641_820259_E2990A93 X-CRM114-Status: GOOD ( 15.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Catalin Marinas , Dmitry Safonov <0x7f454c46@gmail.com>, linux-mips@vger.kernel.org, linux-arch@vger.kernel.org, Marc Zyngier , x86@kernel.org, Russell King , clang-built-linux@googlegroups.com, Ingo Molnar , Kees Cook , Arnd Bergmann , Will Deacon , Borislav Petkov , Andy Lutomirski , Thomas Gleixner , Peter Collingbourne , linux-arm-kernel@lists.infradead.org, Andrei Vagin , Stephen Boyd , Nick Desaulniers , linux-kernel@vger.kernel.org, Mark Salyzyn , Paul Burton Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Vincenzo, Sorry, I was on holiday when you posted this and it slipped through the cracks. On Mon, Mar 16, 2020 at 03:37:23PM +0000, Vincenzo Frascino wrote: > > On Fri, Mar 13, 2020 at 03:43:40PM +0000, Vincenzo Frascino wrote: > >> The vDSO library should only include the necessary headers required for > >> a userspace library (UAPI and a minimal set of kernel headers). To make > >> this possible it is necessary to isolate from the kernel headers the > >> common parts that are strictly necessary to build the library. > >> > >> Introduce asm/vdso/arch_timer.h to contain all the arm64 specific > >> code. This allows to replace the second isb() in __arch_get_hw_counter() > >> with a fake dependent stack read of the counter which improves the vdso > >> library peformances of ~4.5%. Below the results of vdsotest [1] ran for > >> 100 iterations. > > > > The subject seems to imply a non-functional change but as you read, it > > gets a lot more complicated. Could you keep the functional change > > separate from the header clean-up, maybe submit it as an independent > > patch? And it shouldn't go in without Will's ack ;). > > > > It is fine by me. I will repost the series with the required fixes and without > this patch. This will give to me enough time to address Mark's comments as well > and to Will to have a proper look. Please can you post whatever is left at -rc1? I'll have a look then, but let's stick to just moving code around rather than randomly changing it at the same time, ok? Thanks, Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel