From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC7EEC2BBC7 for ; Thu, 9 Apr 2020 14:33:10 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 67FD5215A4 for ; Thu, 9 Apr 2020 14:33:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="P8dbtOdA"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="yegRnYyS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 67FD5215A4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hDP0U9IY2oNaBvW+Gg31dCK8spRANHbTVhnTSZtwSxM=; b=P8dbtOdALjluib wp5/33SYpVluTfcUVtmvI4dG7X6Q3zSuL7dhirbNFAbDNrd3JZzMkZvnbNtCUNMjUDvLXIoEVOF6/ T21hKELufLolmdgNOLe9QEfJ+5ti1UZMbST2zXsHI7Mp4PK/j1H8HfBT7tZKszm6xBM3v7lxbLOud +9KTdZqQRf5TW9KLGBjWGhP1Gqv/th3QsvL6qN0D3w8TftuiUeJDEDhFOmhLgV4+9ZDKQD9yw4Gbm +zzRfE470KICSJzzxoJ1ZNrabO6wGqQ8TWgQFkMDnC1rl/3wziYNI3s06HYLw3NdCSvCDjGzR/EBp Jr5IY0iTggZzKE9uLRhg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jMYEv-0008Ku-5Q; Thu, 09 Apr 2020 14:33:09 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jMYEs-0008Jt-MV for linux-arm-kernel@lists.infradead.org; Thu, 09 Apr 2020 14:33:08 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=t108aSZwNrLLBTSbxD8GRa59ihUeOfYwdyM3oFc/ymk=; b=yegRnYyS0d6o7FbYu4mfEk7ndZ iDEx32RSJY5N+n8TtYqGlRN7WkPP+mAX7DIwPl+nJFE52m+xtOchIwo0CIzlQ/RmS5UVlD39ynfBQ UGa4HGYpMu2HG5t0Rt0CrY0dDDZA5IRTtYF1SpVbWuUZuUJd0hPXZXPu29igqxPcix5Q=; Received: from andrew by vps0.lunn.ch with local (Exim 4.93) (envelope-from ) id 1jMYEV-001omz-2C; Thu, 09 Apr 2020 16:32:43 +0200 Date: Thu, 9 Apr 2020 16:32:43 +0200 From: Andrew Lunn To: Pawel Dembicki Subject: Re: [PATCH v2 2/2] ARM: dts: kirkwood: Add Check Point L-50 board Message-ID: <20200409143243.GK389953@lunn.ch> References: <20200409070448.3209-1-paweldembicki@gmail.com> <20200409070448.3209-2-paweldembicki@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200409070448.3209-2-paweldembicki@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200409_073306_874899_25621F56 X-CRM114-Status: GOOD ( 10.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Jason Cooper , Stephan Gerhold , Heiko Stuebner , Gregory Clement , linux-kernel@vger.kernel.org, Maxime Ripard , Rob Herring , Mark Brown , Sam Ravnborg , Linus Walleij , linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Apr 09, 2020 at 09:04:44AM +0200, Pawel Dembicki wrote: > This patch adds dts for the Check Point L-50 from 600/1100 series > routers. Hi Pawel Looks very good. Just a minor comment: > +ð1 { > + status = "okay"; > + ethernet1-port@0 { > + speed = <1000>; > + duplex = <1>; > + }; > +}; This is a non-standard way of doing a fixed link. But looking at the driver, that is all it supports. I also don't think it is worth the effort converting it. Kirkwood is so old we hardly see any new boards using it. So: Reviewed-by: Andrew Lunn Since we are in the merge window at the moment, this won't be merged for a while. Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel