From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 504C2C2BA2B for ; Thu, 9 Apr 2020 15:59:49 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 219D220768 for ; Thu, 9 Apr 2020 15:59:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="BwNgHK6m" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 219D220768 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Bw6gFpan/prlbOAHsbn9DeqRVGIs4ZQcCsBr0IwGjm0=; b=BwNgHK6mcIzEj9 SDzUVI4kkDpvkixLs6xf85fgu6iZsQzG0jR+B35m1MwDtXO8g5NCWtJ7C84KW2IWUt64NFq4xrOsr kqK2Nsvbk6d/mWvGISwO16XQbjpVyUDeSZr1LFlnQwHcxg0luT+isLmLtAhT+8AFewGmA76YzhdgE kV6fubOX/D/dfdty+oAO0mImpBetH9lPTbJNjjYp7aTcHovWSlLmF7eT7380I+LNJbDTqH4S2/oN7 997Gz8dJk0ErLIfDKnizVA8/JGJqOrG+YtVVKzBKFLDcBJVqiWkyqX6G/RXn34BG8FjLoIMkLfxZL xBAvHRi1JJyQ7PM7chLg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jMZai-00034H-Sz; Thu, 09 Apr 2020 15:59:44 +0000 Received: from relay9-d.mail.gandi.net ([217.70.183.199]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jMZaf-00033e-Gb for linux-arm-kernel@lists.infradead.org; Thu, 09 Apr 2020 15:59:43 +0000 X-Originating-IP: 86.202.105.35 Received: from localhost (lfbn-lyo-1-9-35.w86-202.abo.wanadoo.fr [86.202.105.35]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id E02C2FF802; Thu, 9 Apr 2020 15:59:36 +0000 (UTC) Date: Thu, 9 Apr 2020 17:59:36 +0200 From: Alexandre Belloni To: Aishwarya R Subject: Re: [PATCH] iio: adc: at91-adc: Use devm_platform_ioremap_resource Message-ID: <20200409155936.GV3628@piout.net> References: <20200409151125.32677-1-aishwaryarj100@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200409151125.32677-1-aishwaryarj100@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200409_085941_685570_531A1111 X-CRM114-Status: GOOD ( 14.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, Kefeng Wang , Lars-Peter Clausen , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Stephen Boyd , Ludovic Desroches , Allison Randal , Peter Meerwald-Stadler , Hartmut Knaack , Thomas Gleixner , Jonathan Cameron Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 09/04/2020 20:41:23+0530, Aishwarya R wrote: > Use the helper function that wraps the calls to > platform_get_resource() and devm_ioremap_resource() > together. > Please elaborate the actual value of doing that. > Signed-off-by: Aishwarya R > --- > drivers/iio/adc/at91_adc.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/iio/adc/at91_adc.c b/drivers/iio/adc/at91_adc.c > index abe99856c823..0368b6dc6d60 100644 > --- a/drivers/iio/adc/at91_adc.c > +++ b/drivers/iio/adc/at91_adc.c > @@ -1152,7 +1152,6 @@ static int at91_adc_probe(struct platform_device *pdev) > int ret; > struct iio_dev *idev; > struct at91_adc_state *st; > - struct resource *res; > u32 reg; > > idev = devm_iio_device_alloc(&pdev->dev, sizeof(struct at91_adc_state)); > @@ -1182,9 +1181,7 @@ static int at91_adc_probe(struct platform_device *pdev) > if (st->irq < 0) > return -ENODEV; > > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - > - st->reg_base = devm_ioremap_resource(&pdev->dev, res); > + st->reg_base = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(st->reg_base)) > return PTR_ERR(st->reg_base); > > -- > 2.17.1 > -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel