From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A633C2BA2B for ; Fri, 10 Apr 2020 11:22:46 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 25F6E20753 for ; Fri, 10 Apr 2020 11:22:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="pmEGh5t/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 25F6E20753 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rHaw33EoL/VlkcQnGv/BOaDDy4lzwei+l/he9Dsa12w=; b=pmEGh5t/RN6f8F XurM7+2SICca8H3sQjIXroxUCu2QyBUzCl6vQQ7l89SloeRrzrUSoU78BOyny2awwpEkbXGnBnoiK YHlaI15yEqC/pncX2eL+M4ufmPxMDwHX8Z8kU5+W3UF8/FB2Uz58IvKFaSw4FN2C1Eq3+JliRezvh xjXpPCJSxq0NJDB59XPo3gmpPDbX+Ym5HlVbMAZbX1a36t1ABfTWSjuo0/E2kObwi5H2iY4qJmk5x E0Kaqgvd/HTZnqzWcDd1yUumdeiNFKHjuRS4Dte1fZMHfYvwwu+PIxMfqUhW+1L/0MZ3rRvMxYGK+ 52IXaIBpU+sDqLC0jvOw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jMrkD-0008F9-3M; Fri, 10 Apr 2020 11:22:45 +0000 Received: from relay10.mail.gandi.net ([217.70.178.230]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jMrk9-0008El-BP for linux-arm-kernel@lists.infradead.org; Fri, 10 Apr 2020 11:22:43 +0000 Received: from localhost (lfbn-lyo-1-9-35.w86-202.abo.wanadoo.fr [86.202.105.35]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 5B594240010; Fri, 10 Apr 2020 11:22:36 +0000 (UTC) Date: Fri, 10 Apr 2020 13:22:36 +0200 From: Alexandre Belloni To: Andy Shevchenko Subject: Re: [PATCH] iio: adc: at91-adc: Use devm_platform_ioremap_resource Message-ID: <20200410112236.GX3628@piout.net> References: <20200409151125.32677-1-aishwaryarj100@gmail.com> <20200409155936.GV3628@piout.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200410_042241_528095_DE5544C9 X-CRM114-Status: GOOD ( 14.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm Mailing List , Kefeng Wang , Lars-Peter Clausen , linux-iio , Linux Kernel Mailing List , Stephen Boyd , Ludovic Desroches , Allison Randal , Peter Meerwald-Stadler , Hartmut Knaack , Thomas Gleixner , Aishwarya R , Jonathan Cameron Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/04/2020 13:55:26+0300, Andy Shevchenko wrote: > On Thu, Apr 9, 2020 at 7:00 PM Alexandre Belloni > wrote: > > On 09/04/2020 20:41:23+0530, Aishwarya R wrote: > > > Use the helper function that wraps the calls to > > > platform_get_resource() and devm_ioremap_resource() > > > together. > > > Please elaborate the actual value of doing that. > > Please, elaborate actual value of not doing that. > > Yes, I know that you are p* off of these changes, but why you not > going further and forbid all clean ups we are doing in the code? > > To the point. Above change is reducing code base and showing the new > comers modern APIs to use. > The value of doing it is to reduce the code size by 16 bytes. The same people doing that will actively ruin that by adding error string for error that will never ever happen. Also, the commit message is definitively lacking. A good commit message would say that the patch has been generated using coccinelle, that no testing has been done and that no thought has been given. It would definitively make sense to send one patch per subsystem instead of having 475 different patches each changing only one location. The whole "let's let newcomers fix trivial bugs" thing is definitively not working and it is not leading to an increase of the number of useful reviewers and contributors -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel