From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1840C2BA2B for ; Sat, 11 Apr 2020 09:59:04 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6274F2084D for ; Sat, 11 Apr 2020 09:59:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="pobWC7yh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6274F2084D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GYEGRiefIPigNghnE+NiPBecwcbqq2ZNvJOorwwzaq4=; b=pobWC7yhL+yTgF CxCaYu+EO1qxD+zadqxL4agsQNt0bdMJWCWq6n2ofaDIua44WR3c53h4Uy1MliaDptY6zLdNo4mYX DQTjLq0y2GBqI7fsb9Jo/FeECEog/22u/KYr1qqSIIxXIdULJQvcprJY0tK62majbFyUOExS2ymf4 VdTzT0R51pCgyXPdz/5yvEYBh27rRUGDY0NGTwpm8bmW+ufUA82ukvfljWD4qNwDSWcaRYQz6Tmyr nmDX2tCaOGEQwBGthQx7y0OzczP0XP+STgKgobKhwlwc1GqHYGEZLYe5AdqdM0GS/BQaqaOq1FwRB mj/UliMs3+jYvPaV5iTg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jNCui-0002tL-9F; Sat, 11 Apr 2020 09:59:00 +0000 Received: from relay12.mail.gandi.net ([217.70.178.232]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jNCue-0002jX-PM for linux-arm-kernel@lists.infradead.org; Sat, 11 Apr 2020 09:58:59 +0000 Received: from kb-xps (unknown [78.193.40.249]) (Authenticated sender: kamel.bouhara@bootlin.com) by relay12.mail.gandi.net (Postfix) with ESMTPSA id F0911200007; Sat, 11 Apr 2020 09:58:48 +0000 (UTC) Date: Sat, 11 Apr 2020 11:58:47 +0200 From: Kamel Bouhara To: Randy Dunlap Subject: Re: [PATCH 1/3] counter: add an inkernel API Message-ID: <20200411095847.GA161090@kb-xps> References: <20200406155806.1295169-1-kamel.bouhara@bootlin.com> <20200406155806.1295169-2-kamel.bouhara@bootlin.com> <7651ea0d-91c2-49db-9af7-b01a78868d7e@infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <7651ea0d-91c2-49db-9af7-b01a78868d7e@infradead.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200411_025857_108527_F675D123 X-CRM114-Status: GOOD ( 20.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Alexandre Belloni , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Dmitry Torokhov , William Breathitt Gray , Ludovic Desroches , Rob Herring , Thomas Petazzoni , linux-input@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Apr 10, 2020 at 10:34:34AM -0700, Randy Dunlap wrote: > Hi-- > Hello, > On 4/6/20 8:58 AM, Kamel Bouhara wrote: > > --- > > drivers/counter/counter.c | 213 ++++++++++++++++++++++++++++++++++++++ > > include/linux/counter.h | 27 +++++ > > 2 files changed, 240 insertions(+) > > > > diff --git a/drivers/counter/counter.c b/drivers/counter/counter.c > > index 6a683d086008..f81d2d1dbca7 100644 > > --- a/drivers/counter/counter.c > > +++ b/drivers/counter/counter.c > > [snip] > > Please use > /** > on these functions so that kernel-doc will process them. > OK, fixed. Thanks. > > + > > +/* > > + * devm_counter_get - Obtain an exclusive access to a counter. > > + * @dev: device for counter "consumer" > > + * > > + * Returns a struct counter_device matching the counter producer, or > > + * IS_ERR() condition containing errno. > > + * > > + */ > > +struct counter_device *devm_counter_get(struct device *dev) > > +{ > > + struct counter_device **ptr, *counter; > > + > > + ptr = devres_alloc(devm_counter_release, sizeof(*ptr), GFP_KERNEL); > > + if (!ptr) > > + return ERR_PTR(-ENOMEM); > > + > > + counter = counter_get(dev); > > + if (IS_ERR(counter)) { > > + devres_free(ptr); > > + return counter; > > + } > > + > > + *ptr = counter; > > + devres_add(dev, ptr); > > + > > + return counter; > > +} > > +EXPORT_SYMBOL_GPL(devm_counter_get); > > + > > +/* > > + * counter_action_get - get counter synapse mode > > + * @counter: counter device to operate with > > + * @action: pointer to store the current counter synapse mode > > should be @mode: ^^^^^ > Fixed. Thanks. Kamel > > + * returns: > > + * 0 on success, error code on failure. > > + */ > > +int counter_action_get(struct counter_device *counter, int *mode) > > +{ > > + struct counter_synapse *synapse = counter->counts->synapses; > > + size_t action_index; > > + int err; > > + > > + err = counter->ops->action_get(counter, counter->counts, synapse, > > + &action_index); > > + if (err) > > + return err; > > + > > + *mode = synapse->actions_list[action_index]; > > + > > + return 0; > > +} > > +EXPORT_SYMBOL_GPL(counter_action_get); > > + > > +/* > > + * counter_action_set - set counter device synapse > > + * @counter: counter device to operate with > > + * @action: enum of the synapse mode > > + * returns: > > + * 0 on success, error code on failure. > > + */ > > +int counter_action_set(struct counter_device *counter, > > + enum counter_synapse_action action) > > +{ > > + struct counter_synapse *synapse = counter->counts->synapses; > > + const size_t num_actions = synapse->num_actions; > > + size_t action_index; > > + > > + /* Find requested action mode */ > > + for (action_index = 0; action_index < num_actions; action_index++) { > > + if (action == synapse->actions_list[action_index]) > > + break; > > + } > > + > > + if (action_index >= num_actions) > > + return -EINVAL; > > + > > + return counter->ops->action_set(counter, counter->counts, synapse, > > + action_index); > > +} > > +EXPORT_SYMBOL_GPL(counter_action_set); > > + > > +/* > > + * counter_function_get - get the count function > > + * @counter: pointer to counter device to operate with > > + * @mode: pointer to store the current counter function mode > > + * returns: > > + * 0 on success, error code on failure. > > + */ > > +int counter_function_get(struct counter_device *counter, int *mode) > > +{ > > + size_t func_index; > > + int err; > > + > > + err = counter->ops->function_get(counter, counter->counts, > > + &func_index); > > + if (err) > > + return err; > > + > > + *mode = counter->counts->functions_list[func_index]; > > + > > + return 0; > > +} > > +EXPORT_SYMBOL_GPL(counter_function_get); > > + > > +/* > > + * counter_function_set - set a count function > > + * @counter: pointer to a counter device to operate with > > + * @function: enum of the function mode > > + * returns: > > + * 0 on success, error code on failure. > > + */ > > +int counter_function_set(struct counter_device *counter, > > + enum counter_count_function function) > > +{ > > + const size_t num_functions = counter->counts->num_functions; > > + size_t func_index; > > + > > + for (func_index = 0; func_index < num_functions; func_index++) { > > + if (function == counter->counts->functions_list[func_index]) > > + break; > > + } > > + > > + if (func_index >= num_functions) > > + return -EINVAL; > > + > > + return counter->ops->function_set(counter, counter->counts, func_index); > > +} > > +EXPORT_SYMBOL_GPL(counter_function_set); > > + > > +/* > > + * counter_count_set - set a count value > > + * @counter: pointer to the counter device to operate with > > + * @val: count value to write into the counter > > + * @len: length of the value written to the counter > > + * returns: > > + * bytes length of the value on success, error code on failure. > > + */ > > +size_t counter_count_set(struct counter_device *counter, > > + unsigned long val, size_t len) > > +{ > > + return counter->ops->count_write(counter, counter->counts, val); > > +} > > +EXPORT_SYMBOL_GPL(counter_count_set); > > + > > +/* > > + * counter_count_get - read the count value > > + * @counter: pointer to the counter device to operate with > > + * @val: pointer to store the count value > > + * returns: > > + * 0 on success, error code on failure. > > + */ > > +int counter_count_get(struct counter_device *counter, unsigned long *val) > > +{ > > + return counter->ops->count_read(counter, counter->counts, val); > > +} > > +EXPORT_SYMBOL_GPL(counter_count_get); > > + > > /** > > * devm_counter_unregister - Resource-managed counter_unregister > > * @dev: device this counter_device belongs to > > > thanks. > -- > ~Randy > -- Kamel Bouhara, Bootlin Embedded Linux and kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel