From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51C7EC2BA19 for ; Sat, 11 Apr 2020 18:10:26 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1FA6B20732 for ; Sat, 11 Apr 2020 18:10:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ul7OYUGO"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="dcNVzinV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1FA6B20732 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Hvm712BtBZTZAoPqblDyyyEgD6ddkELCDOAvxtGGQcI=; b=ul7OYUGOgQ8CjE C40oG9BqW4mf7sROugRIAZY14kkOIQImGg4dc0WTCxQ0poAy9Ze5+WT4KPLtF6KRgyD0vTGdp+Ymk 2fLdXQf9HI0qy3K9pElgz9XspjEXUh32QxlBQV8UKKxIhnU1l9Ti4OrFF+Eu09ZIiq7VFTFsBYtDt sbCKkKP2rsNPX6Tufjkpt5yKxt+ydv6dXySubycGrYUEEyALiKYAQfO4CYTcDTCxvig/KcwKyDxZy 6B1Jq4oQDd88/yQVsES8pvzxHnVifLybJxsi5pUDS//0ZcZ9YIXUJnJo/dgsP8826/me2eHNfzAWP z2B9iedl7r5Cb+l22oZg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jNKaG-0003JW-K3; Sat, 11 Apr 2020 18:10:24 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jNKaD-0003J4-G7; Sat, 11 Apr 2020 18:10:22 +0000 Received: from localhost (unknown [213.57.247.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E1AE420732; Sat, 11 Apr 2020 18:10:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586628620; bh=cR0eHiEhVEU/CYCz8ttOIHBrqvYs0p6ey3Uw55qOSGo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dcNVzinV8moP+fO5RfqQizJEQ1Fo5MA/EWcPhgl3anCgpKoqChGaQQMh6g6lxD8Zu U4Uz5GI9QK6vrVpGwcn3HSXE+MfBDWSMFeD7yfpw5OsGv/2b1L7VjOahk8qLWPZWwn jvyrMweq0NnBZhQyYqoGjPPwE0zfMs2kGVTNuapw= Date: Sat, 11 Apr 2020 21:10:15 +0300 From: Leon Romanovsky To: Borislav Petkov Subject: Re: [PATCH] net/3com/3c515: Fix MODULE_ARCH_VERMAGIC redefinition Message-ID: <20200411181015.GC200683@unreal> References: <20200224085311.460338-1-leon@kernel.org> <20200224085311.460338-4-leon@kernel.org> <20200411155623.GA22175@zn.tnic> <20200411161156.GA200683@unreal> <20200411173504.GA11128@zn.tnic> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200411173504.GA11128@zn.tnic> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200411_111021_580232_4395731F X-CRM114-Status: GOOD ( 14.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thor Thayer , Heiko Stuebner , Igor Russkikh , Andreas Larsson , Chris Snook , David Dillow , Jes Sorensen , Iyappan Subramanian , Quan Nguyen , linux-acenic@sunsite.dk, Andy Gospodarek , Arthur Kiyanovski , linux-rockchip@lists.infradead.org, Chen-Yu Tsai , Lino Sanfilippo , Veaceslav Falico , Jakub Kicinski , Tom Lendacky , Jay Cliburn , Jay Vosburgh , Keyur Chudgar , Maxime Ripard , Don Fry , nios2-dev@lists.rocketboards.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Ion Badulescu , Netanel Belgazal , Mark Einon , "David S. Miller" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Apr 11, 2020 at 07:35:04PM +0200, Borislav Petkov wrote: > On Sat, Apr 11, 2020 at 07:11:56PM +0300, Leon Romanovsky wrote: > > Probably, this is the right change, but I have a feeling that the right > > solution will be inside headers itself. It is a little bit strange that > > both very common kernel headers like module.h and vermagic.h are location > > dependant. > > Judging by how only a couple of net drivers include vermagic.h directly, > doh, of course: > > diff --git a/drivers/net/ethernet/3com/3c509.c b/drivers/net/ethernet/3com/3c509.c > index b762176a1406..139d0120f511 100644 > --- a/drivers/net/ethernet/3com/3c509.c > +++ b/drivers/net/ethernet/3com/3c509.c > @@ -85,7 +85,6 @@ > #include > #include > #include > -#include > > #include > #include > diff --git a/drivers/net/ethernet/3com/3c515.c b/drivers/net/ethernet/3com/3c515.c > index 90312fcd6319..47b4215bb93b 100644 > --- a/drivers/net/ethernet/3com/3c515.c > +++ b/drivers/net/ethernet/3com/3c515.c > @@ -22,7 +22,6 @@ > > */ > > -#include > #define DRV_NAME "3c515" > > #define CORKSCREW 1 > > --- > > Drivers include > > #include > > which includes > > #include > > which defines the arch-specific MODULE_ARCH_VERMAGIC. > > Why did you need to include vermagic.h directly? i386 builds fine with > the vermagic.h includes removed or was it some other arches which needed > it? I want to think that it was an outcome of some 0-day kbuild report, but I am not sure about that anymore [1]. Thanks [1] https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org/ > > Thx. > > -- > Regards/Gruss, > Boris. > > https://people.kernel.org/tglx/notes-about-netiquette _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel