From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AF5DC2BA2B for ; Mon, 13 Apr 2020 17:58:45 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0351620737 for ; Mon, 13 Apr 2020 17:58:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="oKolHadb"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="tayvGblV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0351620737 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TPBsDYPsoEifgSnneyOIG6XYoGUMav9rCy1TCpW1KVU=; b=oKolHadbF94ekP MvevbDM7fhvlGjvVh/F/IyGKcsMqo0yVZJXW3IUhPCJWeYJPyP0MgaX/hAPs3lE6GLHYGnYwxVoX6 IHLevYCpyuhqBMPYYv76sZQfYBdQ1r9op+/ttBmOzYjZ5orsHMXHuwoiVsa9B6YFqWDZSkF9IxGjq jbJ1Bt4b+PXiJVxEE/lU8ejfN1djiIHC5JCNWGnkmN2fcgsvoEffHlQhpDr46F5lV0ofJmUp28kyG boMdCWpqZutZ2+vCvEe9PLK6nMbWm/ipgb0mu29Tb7dMpebOkIusAXK1k23pVE9T+x7H8Og+ALl1F t91NRn3ZTJBf/yMjPeSg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jO3M3-0002oD-Sb; Mon, 13 Apr 2020 17:58:43 +0000 Received: from mail-pf1-x444.google.com ([2607:f8b0:4864:20::444]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jO3M0-0002nd-V1 for linux-arm-kernel@lists.infradead.org; Mon, 13 Apr 2020 17:58:42 +0000 Received: by mail-pf1-x444.google.com with SMTP id y25so2555793pfn.5 for ; Mon, 13 Apr 2020 10:58:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=0keu4PMkXs5TE6dOL0jOplSK+Gz3D/D04Bdh0nv5W9k=; b=tayvGblV1EfBLNq0bf+Hjdu/L2wKd2UceRTwQ1v19v8RV3smljbw0OA/W+X5dFWJVr a2+IlQV/BBPuG11edlV+cV365l4aNIk9ep5IDta3jXd09Pu/3xh7uszaCGrFncBaU+Ui EUtGI95pwilWwoK6P+j5LWHGJSFzkwWVgW9/IIOy+WgqrwcjgyseljiidiZJEKCTYBQf KBxn8OO7/b02pl9El+PV0wyK2PT0DEJMObQq8E5N9NJT+JJKwC3F7pTNYIW+oUYUbq5G 6reA87/CXmwnAs2eWMkVK9bfoYolzEwoiHvWtDH1NwjoAuIpL2pmeYVDU5rCm6QWVU5W Tahg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=0keu4PMkXs5TE6dOL0jOplSK+Gz3D/D04Bdh0nv5W9k=; b=Mh0ggi7/52xLugqFbecu3DLboIDw4hb1+bfgGZAKzQZQ/CUYiDfPEGx6KT+Ihg2eIe kTNqDy3gankJJx0yAHipeh5LaKnN06ERBuxRun0jTSrSp1VoE+av3bL+FeR8+qagsa6W dhVBT6spX2U8f9oEpQ4sy0+6c63emiWKxZOxwhSx+nN01VqWqtF7Z0hDFA0rxpnkye5+ aX2pQxbw4zSReBL5xLHS1rK8mVLhgs12gG3DXrTY1sE4c7EuxsZ8kqvF/67hGRN2rWnx YLWsPKjJ/A10YaIeyczp4AdY3B3KQlyF3LE6fdRgHecicWNRMiNZ12i8SkAcFm44UScx 5i3w== X-Gm-Message-State: AGi0PuZigya3x4CHXZKYELhPERpy2jD7CLGnHIOB5hEL9hdJS6TXa5qB NOvFcv0F7/tbJ//lccot3cDPWQ== X-Google-Smtp-Source: APiQypJ4hG26wy+uvhPhK5njQ4Mt6FjcLeTkBC1tThGtSZgPZMfB0noJ/QWQnqj6exVsBvFvBuy8Tw== X-Received: by 2002:a62:7786:: with SMTP id s128mr19494733pfc.144.1586800720395; Mon, 13 Apr 2020 10:58:40 -0700 (PDT) Received: from xps15 (S0106002369de4dac.cg.shawcable.net. [68.147.8.254]) by smtp.gmail.com with ESMTPSA id k14sm9306208pfg.15.2020.04.13.10.58.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Apr 2020 10:58:39 -0700 (PDT) Date: Mon, 13 Apr 2020 11:58:37 -0600 From: Mathieu Poirier To: Jason Yan Subject: Re: [PATCH] coresight: cti: make some symbols static Message-ID: <20200413175837.GE28804@xps15> References: <20200413082224.23090-1-yanaijie@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200413082224.23090-1-yanaijie@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200413_105841_009971_7BE360A5 X-CRM114-Status: GOOD ( 15.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: suzuki.poulose@arm.com, alexander.shishkin@linux.intel.com, linux-kernel@vger.kernel.org, Hulk Robot , linux-arm-kernel@lists.infradead.org, mike.leach@linaro.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Apr 13, 2020 at 04:22:24PM +0800, Jason Yan wrote: > Fix the following sparse warning: > > drivers/hwtracing/coresight/coresight-cti.c:22:1: warning: symbol > 'ect_net' was not declared. Should it be static? > drivers/hwtracing/coresight/coresight-cti.c:625:32: warning: symbol > 'cti_ops_ect' was not declared. Should it be static? > drivers/hwtracing/coresight/coresight-cti.c:630:28: warning: symbol > 'cti_ops' was not declared. Should it be static? > > Reported-by: Hulk Robot > Signed-off-by: Jason Yan > --- > drivers/hwtracing/coresight/coresight-cti.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/hwtracing/coresight/coresight-cti.c b/drivers/hwtracing/coresight/coresight-cti.c > index 9e262f5a85e3..7fc1fc8d7738 100644 > --- a/drivers/hwtracing/coresight/coresight-cti.c > +++ b/drivers/hwtracing/coresight/coresight-cti.c > @@ -19,7 +19,7 @@ > */ > > /* net of CTI devices connected via CTM */ > -LIST_HEAD(ect_net); > +static LIST_HEAD(ect_net); > > /* protect the list */ > static DEFINE_MUTEX(ect_mutex); > @@ -622,12 +622,12 @@ int cti_disable(struct coresight_device *csdev) > return cti_disable_hw(drvdata); > } > > -const struct coresight_ops_ect cti_ops_ect = { > +static const struct coresight_ops_ect cti_ops_ect = { > .enable = cti_enable, > .disable = cti_disable, > }; > > -const struct coresight_ops cti_ops = { > +static const struct coresight_ops cti_ops = { > .ect_ops = &cti_ops_ect, > }; Applied - thanks, Mathieu > > -- > 2.21.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel