From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78A65C2BA19 for ; Tue, 14 Apr 2020 14:21:42 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 48CA02075E for ; Tue, 14 Apr 2020 14:21:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="eDW47QZ6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 48CA02075E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hCKoSNobDoEuzeZiQUOjPN+gLUJT+91IFAZOKCS7eDU=; b=eDW47QZ6DYOvn8 9KUp7f5j/h3KA+jE5Is2ZUF3JS8EIsiiHpVqPeZ1eedoUb160f9Jm3X5GBrH1TVWbNNF8pqbA4LPO oroZoDgUF0e7tuhcXXQlhr9lQy2CG3VPxHC7ZuLOXLHMQ+G1DOREUc0I0UUSRnWuVZqGjx+8fdOT1 zE73IZC5/JhCP1SXNEgnoJZe6FMft4IPSJ2YcIPSpqkwzz4Qa0wJcco93GMbsBAilgtnnTsctyWKx TlQabTR6IkAMq/nQ/uSvu4kq4U2Crc2jN6mGjZA5Yw/0mOFlKDJ+FrBWhDIXFEllR/6wHV2qZjsJs J0dNvvMbYKntwP6THltw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jOMRW-00018O-Jx; Tue, 14 Apr 2020 14:21:38 +0000 Received: from mail-ot1-f65.google.com ([209.85.210.65]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jOMRT-000184-2e for linux-arm-kernel@lists.infradead.org; Tue, 14 Apr 2020 14:21:36 +0000 Received: by mail-ot1-f65.google.com with SMTP id w12so12038937otm.13 for ; Tue, 14 Apr 2020 07:21:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=7qB5XS57n67MYXQJiHnjoHHOlP+v7Plet2PJhhKm2pA=; b=Qpymeh05VwSR73RD8nrGts4ozi7BOZ3DvMSoI6ZYErsuEurzReR+iZFc6sjZBWOhab hJjsFuH01Si72Yy0K+lI0p18mFtNmiR8zU56ZW3TTYFAMAEFJmtWLMxDY7FAmhEzA7e7 4A8M4zOrfgx9ZRQOlluDCc5pQxVQh1bSY+9HLtupuceBWZ7xb7lOO8WLr1DQKgkRT0Ne syb5+nrvMZR5y8a1Z3AoWJS06soPdFAW6UCLCbQ09cNrvwmnBJAbPiu6WMphd7ltj3lp EFTbgGIaeqrEAvAmuFlQCrHzKi6S0nB3Jv0YrBDza8YE9T5uwuRBd5lK1BCPvJRNFYbh 3Tdw== X-Gm-Message-State: AGi0PuZnOuK/raOA0DKs/AKw+fhxeunOKGH4Nes+9eQ5Uw5MN7QWGV3U ouE8ajWeRtY85LRogJKYxQ== X-Google-Smtp-Source: APiQypLoB//SQjLQBkpXtSSlfjCiCaFzojDq5PxSqn/uIWY6+9eAJg0r+nHSgJSEib1fkfvlSTLSsA== X-Received: by 2002:a05:6830:1190:: with SMTP id u16mr19562600otq.83.1586874093641; Tue, 14 Apr 2020 07:21:33 -0700 (PDT) Received: from rob-hp-laptop (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id c7sm1257994otp.3.2020.04.14.07.21.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Apr 2020 07:21:32 -0700 (PDT) Received: (nullmailer pid 18159 invoked by uid 1000); Tue, 14 Apr 2020 14:21:31 -0000 Date: Tue, 14 Apr 2020 09:21:31 -0500 From: Rob Herring To: Masahiro Yamada Subject: Re: [PATCH] dt-bindings: dma: uniphier-xdmac: switch to single reg region Message-ID: <20200414142131.GA18052@bogus> References: <20200401032150.19767-1-yamada.masahiro@socionext.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200401032150.19767-1-yamada.masahiro@socionext.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200414_072135_113429_381320B0 X-CRM114-Status: GOOD ( 15.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Kunihiko Hayashi , linux-kernel@vger.kernel.org, Masahiro Yamada , Vinod Koul , dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 1 Apr 2020 12:21:50 +0900, Masahiro Yamada wrote: > The reg in the example "<0x5fc10000 0x1000>, <0x5fc20000 0x800>" > is wrong. The register region of this controller is much smaller, > and there is no other hardware register interleaved. There is no > good reason to split it into two regions. > > Just use a single, contiguous register region. > > While I am here, I made the 'dma-channels' property mandatory because > otherwise there is no way to determine the number of the channels. > > Please note the original binding was merged recently. Since there > is no user yet, this change has no actual impact. > > Fixes: b9fb56b6ba8a ("dt-bindings: dmaengine: Add UniPhier external DMA controller bindings") > Signed-off-by: Masahiro Yamada > --- > > We do not need to touch the driver either because the second > region is not used. > > > .../devicetree/bindings/dma/socionext,uniphier-xdmac.yaml | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > Reviewed-by: Rob Herring _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel