From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91ADEC2BA19 for ; Tue, 14 Apr 2020 15:08:22 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6380C2076D for ; Tue, 14 Apr 2020 15:08:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="XL6Q3RP+"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="s8K8q5iR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6380C2076D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=edzmuuiiiZw+vO/ILZ1lg8GHh96b9ZLTnHq0JztwnE4=; b=XL6Q3RP+h/koDpSW66TEbCzE8 oxeTrdQQ47p1jzP05/m5HS5t1NfUwGzNhAsTiBgv0ejHDpactamf9NZloZ3PYXR5/xrxjn4mmban4 AVdL9juwvL2eDB77UmmHaAb1c9sY0cyjpRjaTO6vh+93X5YWnj6xIxzbKiqI568m78YnmvTbL85NY UsI1hYeq2b4acIxuR4Yr8/vELF7mYXwBtLhcfXge+uFkYLwQwh5rPMl+XLTV1G195PWdKdmHL9Hpc OquSu83GjsbwzvrZx2dPdEcL508/LcW1PSl0/9V/eEjbw3pSGPKk55TKZQHhN7lAoe42FxYKL0rv+ ent67/b2g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jONAj-0002kc-IX; Tue, 14 Apr 2020 15:08:21 +0000 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jONAg-0002jo-Fl for linux-arm-kernel@lists.infradead.org; Tue, 14 Apr 2020 15:08:19 +0000 Received: by mail-wr1-x441.google.com with SMTP id j2so14734673wrs.9 for ; Tue, 14 Apr 2020 08:08:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=k7q0i04JrV/LeWRv8qAlwGssC6S97Ez37RZ9eJFf4jw=; b=s8K8q5iRtggqNP5qEoyp9NKhh1FcI+I/WpvocM2IwWOsRGN2OhmPWCtRPpKF0pSqur kk6vqF/IOvEFrkaVsK25+SsTVR3Q33zsGE500TdhYf4fhtYvOROG/nhZJGYsK8vBIzQw jTdQSgEfOfsUMZkimdJNkyvA2AyPfUP607BuhA2QDyUpyaTAgDwODdgJne/fIoF4Wax+ njNtUfZ0TJJX6fUbBlsxihKkggxTV5g+hv8GKrdrrUqpfu6QshbWFu9rtMQrmS5kxVss BbkYk/46kdC1TtrT4Zte7uDcDIN0OYATpc38YKttt6+IXg1ZQFuaOdgwqY8bNqBQdBWr xuZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=k7q0i04JrV/LeWRv8qAlwGssC6S97Ez37RZ9eJFf4jw=; b=aaL0A3VubdPxIlho40gLSfLMsK4Z4Dl52s6fGeYb9tIzZPVsWDx8+7pl8GlmXQJotr 4W1suBd3lSjfGlBsYU/8SNoL5vQ2ikPS/nG84WcwMQCSHsF6dflW+Y9xNfMBgwn/u/IE pH/bliZhJjVtKoFGPk1ox2Wn4v/TMvBxRvUrMMSrcsGlMbLGXpePC5cXdREHKDxnJtl8 rQ2HK6YwDI/YB5pcQ+pRqCXBB1xpxZkC/QTEMtL5nrf7XXEOhJS3kt21hQ177eRKQNeA d8ME2pvjy8vfez7AOeid89GHQFsdTDRGD+oMmAqFAY72v8xXdomo5CKnRVT2/GQzr0FT ++Rw== X-Gm-Message-State: AGi0PuYlCVYtsSz6LpQz5rbAJIy1MOhqaeYFt+nYeev2ni6aSj5L6D6w 5TnAN3zOmGgFgA6SjtWMl/A= X-Google-Smtp-Source: APiQypLR+uWxiXs63aPjYfFPWMFe2n0Nn/f6HhopnZJbUeLcgUQfMkrWPO84Tz3WWOc4Hxo4F/dUmA== X-Received: by 2002:a5d:658e:: with SMTP id q14mr25214585wru.92.1586876897235; Tue, 14 Apr 2020 08:08:17 -0700 (PDT) Received: from localhost (pD9E51D62.dip0.t-ipconnect.de. [217.229.29.98]) by smtp.gmail.com with ESMTPSA id m14sm17431931wrs.76.2020.04.14.08.08.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Apr 2020 08:08:15 -0700 (PDT) Date: Tue, 14 Apr 2020 17:08:15 +0200 From: Thierry Reding To: Dmitry Osipenko Subject: Re: [PATCH v6 09/14] memory: tegra: Add EMC scaling support code for Tegra210 Message-ID: <20200414150815.GM3593749@ulmo> References: <20200409175238.3586487-1-thierry.reding@gmail.com> <20200409175238.3586487-10-thierry.reding@gmail.com> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.13.1 (2019-12-14) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200414_080818_526758_C03E37CA X-CRM114-Status: GOOD ( 14.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Stephen Boyd , Michael Turquette , Jon Hunter , Rob Herring , Joseph Lo , linux-tegra@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============9169072578923982654==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============9169072578923982654== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="75WsOQSofUOhcSOp" Content-Disposition: inline --75WsOQSofUOhcSOp Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Apr 10, 2020 at 05:25:06PM +0300, Dmitry Osipenko wrote: > 09.04.2020 20:52, Thierry Reding =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > ... > > +static int tegra210_emc_remove(struct platform_device *pdev) > > +{ > > + struct tegra210_emc *emc =3D platform_get_drvdata(pdev); > > + > > + debugfs_remove_recursive(emc->debugfs.root); > > + tegra210_clk_emc_detach(emc->clk); >=20 > It's great that you want to make this driver modular, but I don't think > that it's a good idea to suddenly rip off the EMC clock from the users. >=20 > It should be better to simply disallow unloading of this driver once > it's loaded. That's not what we're doing. The clock is going to stay around and users will be able to access it. The only thing that the above does is take away the possibility to change the rate of the EMC clock. So I think this actually makes this really nice both for testing that unload/reload works and it also gives users an easy way to disable EMC frequency scaling by simply blacklisting the module. Thierry --75WsOQSofUOhcSOp Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAl6V0d4ACgkQ3SOs138+ s6GsWw/+M5/HCC6YVqevVHN5rlOJp1Ymn8G8PfobgyJaQ+IQ5YBian1VcklzBhNx jqEPh0NaQTMm8Lq30si3Es6lnPugjOhhsYpGP2PVQ8Fpgr33hqoileVYzHYe4uMP uk7SUYzZMoBAdO936koxzvfVIS86NGqzVciHH7xDQqndF1PoRShxkHA+Fmg7FuwA BNKrTPyYObiEZD0KO45fHkyWxrBl7lfk6Qm9gMyM5wpp80JHI/gGkmE3kUocMW/w zYXnGLES5NcrDgBDv1aRAlt8pafa1TrFtZIpADX2Y3q533/TEojbb3f9BtYkLCAP 8cfmAfFdHK9gOo68OGpPFePzFZRYdxEH3xCGOsISgMoE5PRIKpLhVZW1/zlaVGHG yQUuKR2c/G+qlPgD1vb42B7b7cPmA3DU7KGZn7aUhDTuR8ovDd29Xzzqzvf9Gq52 CKZFYirYrVuNF4Yu81JCQejfoOy3dah1EILZ/H4rwsIZGbNmzNt8uMPJ9/b0UAht 9aCgJJC05SNFFeWT7PYgleJHLLl5zpdStTbZgSHdjyS7az2+hTCU/ZxEFVUbfARp yMauGoTgjC+Tmlo2i8u/TO91xvVVLx0jnhAT9QETnjYkTZtr1T5h8jh9u2EIguHb oFtPdGtkf4+73XZxomkd6XA3sThbRwKYCuzJUIupCz+fwe2ByZQ= =UtAs -----END PGP SIGNATURE----- --75WsOQSofUOhcSOp-- --===============9169072578923982654== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============9169072578923982654==--