From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Jason Yan <yanaijie@huawei.com>
Cc: daniel.lezcano@linaro.org, linux-kernel@vger.kernel.org,
ludovic.desroches@microchip.com, tglx@linutronix.de,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] clocksource: atmel-st: remove useless 'status'
Date: Wed, 15 Apr 2020 09:37:11 +0200 [thread overview]
Message-ID: <20200415073711.GM34509@piout.net> (raw)
In-Reply-To: <20200414120238.35704-1-yanaijie@huawei.com>
On 14/04/2020 20:02:38+0800, Jason Yan wrote:
> Fix the following coccicheck warning:
>
> drivers/clocksource/timer-atmel-st.c:142:6-12: Unneeded variable:
> "status". Return "0" on line 166
>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> ---
> drivers/clocksource/timer-atmel-st.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/clocksource/timer-atmel-st.c b/drivers/clocksource/timer-atmel-st.c
> index ab0aabfae5f0..73e8aee445da 100644
> --- a/drivers/clocksource/timer-atmel-st.c
> +++ b/drivers/clocksource/timer-atmel-st.c
> @@ -139,7 +139,6 @@ static int
> clkevt32k_next_event(unsigned long delta, struct clock_event_device *dev)
> {
> u32 alm;
> - int status = 0;
> unsigned int val;
>
> BUG_ON(delta < 2);
> @@ -163,7 +162,7 @@ clkevt32k_next_event(unsigned long delta, struct clock_event_device *dev)
> alm += delta;
> regmap_write(regmap_st, AT91_ST_RTAR, alm);
>
> - return status;
> + return 0;
> }
>
> static struct clock_event_device clkevt = {
> --
> 2.21.1
>
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-04-15 7:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-14 12:02 [PATCH] clocksource: atmel-st: remove useless 'status' Jason Yan
2020-04-15 7:37 ` Alexandre Belloni [this message]
2020-04-15 8:57 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200415073711.GM34509@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=daniel.lezcano@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=tglx@linutronix.de \
--cc=yanaijie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).